diff mbox series

[06/18] [BUGFIXiwlwifi: make MVM and DVM depend on MAC80211

Message ID 20181214202945.32375-7-luca@coelho.fi (mailing list archive)
State Accepted
Delegated to: Luca Coelho
Headers show
Series iwlwifi: updates intended for v4.21 2018-12-14 | expand

Commit Message

Luca Coelho Dec. 14, 2018, 8:29 p.m. UTC 
From: Luca Coelho <luciano.coelho@intel.com>

It's not the iwlwifi module that depends on mac80211, but iwlmvm and
iwldvm.  To reflect this better, make MVM and DVM Kconfig options
depend on MAC80211 instead.

Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/Kconfig | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Kalle Valo Dec. 18, 2018, 4:17 p.m. UTC | #1 
Luca Coelho <luca@coelho.fi> writes:

> From: Luca Coelho <luciano.coelho@intel.com>
>
> It's not the iwlwifi module that depends on mac80211, but iwlmvm and
> iwldvm.  To reflect this better, make MVM and DVM Kconfig options
> depend on MAC80211 instead.
>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

The subject is broken, stray "[BUGFIX". I think you are offline already
so I can fix it myself but I need to rebase the patches. I assume that's
ok unless someone from Intel objects :)
Luca Coelho Dec. 19, 2018, 10:24 a.m. UTC | #2 
On Tue, 2018-12-18 at 18:17 +0200, Kalle Valo wrote:
> Luca Coelho <luca@coelho.fi> writes:
> 
> > From: Luca Coelho <luciano.coelho@intel.com>
> > 
> > It's not the iwlwifi module that depends on mac80211, but iwlmvm and
> > iwldvm.  To reflect this better, make MVM and DVM Kconfig options
> > depend on MAC80211 instead.
> > 
> > Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> 
> The subject is broken, stray "[BUGFIX". I think you are offline already
> so I can fix it myself but I need to rebase the patches. I assume that's
> ok unless someone from Intel objects :)

Ouch, sorry.  Internal tag leaked out.  That's what happens when you try
to finish too many things in a hurry before vacations. :(

--
Luca.
diff mbox series

Patch

diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig
index e5a2fc738ac3..491ca3c8b43c 100644
--- a/drivers/net/wireless/intel/iwlwifi/Kconfig
+++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
@@ -1,6 +1,6 @@ 
 config IWLWIFI
 	tristate "Intel Wireless WiFi Next Gen AGN - Wireless-N/Advanced-N/Ultimate-N (iwlwifi) "
-	depends on PCI && MAC80211 && HAS_IOMEM
+	depends on PCI && HAS_IOMEM
 	select FW_LOADER
 	---help---
 	  Select to build the driver supporting the:
@@ -53,6 +53,7 @@  config IWLWIFI_LEDS
 
 config IWLDVM
 	tristate "Intel Wireless WiFi DVM Firmware support"
+	depends on MAC80211
 	help
 	  This is the driver that supports the DVM firmware. The list
 	  of the devices that use this firmware is available here:
@@ -61,6 +62,7 @@  config IWLDVM
 config IWLMVM
 	tristate "Intel Wireless WiFi MVM Firmware support"
 	select WANT_DEV_COREDUMP
+	depends on MAC80211
 	help
 	  This is the driver that supports the MVM firmware. The list
 	  of the devices that use this firmware is available here: