diff mbox series

mwifiex: delete unused mwifiex_get_intf_num()

Message ID 20191210003911.28066-1-briannorris@chromium.org
State Accepted
Commit 1c9f329b084b7b8ea6d60d91a202e884cdcf6aae
Delegated to: Kalle Valo
Headers show
Series mwifiex: delete unused mwifiex_get_intf_num() | expand

Commit Message

Brian Norris Dec. 10, 2019, 12:39 a.m. UTC
Commit 7afb94da3cd8 ("mwifiex: update set_mac_address logic") fixed the
only user of this function, partly because the author seems to have
noticed that, as written, it's on the borderline between highly
misleading and buggy.

Anyway, no sense in keeping dead code around: let's drop it.

Fixes: 7afb94da3cd8 ("mwifiex: update set_mac_address logic")
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
 drivers/net/wireless/marvell/mwifiex/main.h | 13 -------------
 1 file changed, 13 deletions(-)

Comments

Kalle Valo Dec. 18, 2019, 7:05 p.m. UTC | #1
Brian Norris <briannorris@chromium.org> wrote:

> Commit 7afb94da3cd8 ("mwifiex: update set_mac_address logic") fixed the
> only user of this function, partly because the author seems to have
> noticed that, as written, it's on the borderline between highly
> misleading and buggy.
> 
> Anyway, no sense in keeping dead code around: let's drop it.
> 
> Fixes: 7afb94da3cd8 ("mwifiex: update set_mac_address logic")
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Patch applied to wireless-drivers-next.git, thanks.

1c9f329b084b mwifiex: delete unused mwifiex_get_intf_num()
diff mbox series

Patch

diff --git a/drivers/net/wireless/marvell/mwifiex/main.h b/drivers/net/wireless/marvell/mwifiex/main.h
index 095837fba300..56a18a7f6853 100644
--- a/drivers/net/wireless/marvell/mwifiex/main.h
+++ b/drivers/net/wireless/marvell/mwifiex/main.h
@@ -1294,19 +1294,6 @@  mwifiex_copy_rates(u8 *dest, u32 pos, u8 *src, int len)
 	return pos;
 }
 
-/* This function return interface number with the same bss_type.
- */
-static inline u8
-mwifiex_get_intf_num(struct mwifiex_adapter *adapter, u8 bss_type)
-{
-	u8 i, num = 0;
-
-	for (i = 0; i < adapter->priv_num; i++)
-		if (adapter->priv[i] && adapter->priv[i]->bss_type == bss_type)
-			num++;
-	return num;
-}
-
 /*
  * This function returns the correct private structure pointer based
  * upon the BSS type and BSS number.