From patchwork Tue Dec 17 16:14:36 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 11298193 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 60B3714B7 for ; Tue, 17 Dec 2019 16:20:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 345B624686 for ; Tue, 17 Dec 2019 16:20:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.b="h+3IXTKK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728456AbfLQQOo (ORCPT ); Tue, 17 Dec 2019 11:14:44 -0500 Received: from mail-eopbgr680046.outbound.protection.outlook.com ([40.107.68.46]:59543 "EHLO NAM04-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728419AbfLQQOk (ORCPT ); Tue, 17 Dec 2019 11:14:40 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dPZXVAmDtp4MUAgnt+hI7+Y55sx29UDw3sE8FE45HJ5sHA0QCafp4eF1kDJwTsw1UPqjwoInWXJgeALfnr8IdeLjvPKIV8Tpf28PekE7xpkzx3/6WLeAAIm05K6NCj9TAGDCtCQol4AEc0q3WThg9ycKZdTY/TRydYufElwwQEbSBbo7HUSW0e56wM+v3iOSovEInF/rCTckV6vGgT+fR/75WmYGAKn/27n3kqjF9jcz6K6w2mya2zT8ybUudzoxF4rnsQfmG1yprHRnpuWEqJTRrJ0eXShsaqd7BdCEakSP3Hms2cXRW0gicRlIxLgoo+jEovTXjwenOjMHsZNX3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iAWqkFdigmw4vHi00yhGVa3Yk42MHGcrKV2JTpUIO70=; b=dn6DWWCjPvTJ1qO04N5WNAonV5tp4vXzLmdefy0BAStrQxiK4662NzmcSSETKpdNuIhfrWURkZGBAI0INVvGEw8hZc1A84LajJ93+5/nVZM+uouuW2nNG7N26b7n73h4MiPP+YR8j+Z3Am/CjA2EgXeK8H1Ny+yKpFyVQ1lQDxIA1xO92VYi56g4Ir9bgB4JjdSH0Tdawxi3y8uHUObjBXqqmD40QLIMuMAxiGTz75jBbsa+TNO9aVHrqRnEXF1qyLKlHoS+ItAOCm/NXQlygGvLHiSOfVuZ+z1s8wfNFSLkMXvAyhBsmJVzvDoA3gPwhZWpynGPrn77giS6e2JcjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iAWqkFdigmw4vHi00yhGVa3Yk42MHGcrKV2JTpUIO70=; b=h+3IXTKK4QvkTCDry+qkYqil0uUq6vvT4vMDYYlsUK/yrAwzR6ezqwdyxzKgtjRe9eSeLmXE3SWGfmtAHAHAZvJZXBiOCQtsSxWLwR/4Wj1lg9XYC8kbESgy9Fp3/TvMe5uci6ZgkCczcHlPj+OsH8MVqTnd08bOhN5xE/4KEts= Received: from MN2PR11MB4063.namprd11.prod.outlook.com (10.255.180.22) by MN2PR11MB3791.namprd11.prod.outlook.com (20.178.254.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.18; Tue, 17 Dec 2019 16:14:36 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::f46c:e5b4:2a85:f0bf]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::f46c:e5b4:2a85:f0bf%4]) with mapi id 15.20.2538.019; Tue, 17 Dec 2019 16:14:36 +0000 From: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= To: "devel@driverdev.osuosl.org" , "linux-wireless@vger.kernel.org" CC: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH v2 07/55] staging: wfx: ensure that retry policy always fallbacks to MCS0 / 1Mbps Thread-Topic: [PATCH v2 07/55] staging: wfx: ensure that retry policy always fallbacks to MCS0 / 1Mbps Thread-Index: AQHVtPUT+yUvhYCIm0KyGJu97eaKNA== Date: Tue, 17 Dec 2019 16:14:36 +0000 Message-ID: <20191217161318.31402-8-Jerome.Pouiller@silabs.com> References: <20191217161318.31402-1-Jerome.Pouiller@silabs.com> In-Reply-To: <20191217161318.31402-1-Jerome.Pouiller@silabs.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: PR0P264CA0174.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1c::18) To MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.24.0 x-originating-ip: [37.71.187.125] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bc678263-495c-4532-b880-08d7830c35a4 x-ms-traffictypediagnostic: MN2PR11MB3791: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 02543CD7CD x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(376002)(366004)(346002)(136003)(39860400002)(189003)(199004)(2906002)(52116002)(107886003)(2616005)(86362001)(478600001)(6486002)(4326008)(64756008)(66556008)(66476007)(81156014)(66946007)(6506007)(1076003)(316002)(66446008)(8936002)(71200400001)(81166006)(5660300002)(36756003)(26005)(186003)(8676002)(85202003)(85182001)(110136005)(54906003)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR11MB3791;H:MN2PR11MB4063.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: leZLjiVrzJfidGWQITFSyNjWBRCkCBfIiITNV2890hNPHJKwqxBpfUqNdTau0q7wIkN8Qhf1sY5+I4pztaz1OorVffkmULM9mpkGbIcDyd4dxD6d+vtIMIbJCZr8ZTRdnvQ0sU7tuwmpuZi5imaKOGbQCT378vZetxu6u+RNY+Ef7o3GqdXhY9xgEXQJp6Ok6iPnMu/ds1Er9BAcjnouI6aCMJ8Uo388iaeM17woHblu3J1dkfgI2H0vf13cd5HEwug4w1tvlmfpKoeZY3TLzo1pBbxRBsBLQWR+7pTcRx1oKvWRzZE/ackJnyhD/J8NsACRLXbuxwiGSvSJ6wZacwh3dLwJu6QOrfhtaW43+Rln7FiVCWkGarZgs7FI7Pgh2SZyKJlLcfimv9ybbB7o7I2WfsajS6spHLSpnrKZqU3qejy8UbK3Vt3JD/MvqufZ Content-ID: <9D60EB79FDE4ED4DA3DE161AAD87AE13@namprd11.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc678263-495c-4532-b880-08d7830c35a4 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2019 16:14:36.0547 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +6LO3KIpEs+uh+fi0grOjai9/n4fzk3hqgymL5TLWYY0smfn+nWoO4ExYbXaFCMIuEQ1/MeZnWrfuyZAaMXjuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3791 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller When not using HT mode, minstrel always includes 1Mbps as fallback rate. But, when using HT mode, this fallback is not included. Yet, it seems that it could save some frames. So, this patch add it unconditionally. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/data_tx.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c index 46ad83b95f52..738a6ca5edad 100644 --- a/drivers/staging/wfx/data_tx.c +++ b/drivers/staging/wfx/data_tx.c @@ -538,6 +538,17 @@ static void wfx_tx_fixup_rates(struct ieee80211_tx_rate *rates) } } } while (!finished); + // Ensure that MCS0 or 1Mbps is present at the end of the retry list + for (i = 0; i < IEEE80211_TX_MAX_RATES; i++) { + if (rates[i].idx == 0) + break; + if (rates[i].idx == -1) { + rates[i].idx = 0; + rates[i].count = 8; // == hw->max_rate_tries + rates[i].flags = rates[i - 1].flags & IEEE80211_TX_RC_MCS; + break; + } + } // All retries use long GI for (i = 1; i < IEEE80211_TX_MAX_RATES; i++) rates[i].flags &= ~IEEE80211_TX_RC_SHORT_GI;