From patchwork Thu Sep 10 06:54:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11766831 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 74EDA618 for ; Thu, 10 Sep 2020 07:17:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B05F207EA for ; Thu, 10 Sep 2020 07:17:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NSqRghSS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729993AbgIJHQx (ORCPT ); Thu, 10 Sep 2020 03:16:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726961AbgIJG4b (ORCPT ); Thu, 10 Sep 2020 02:56:31 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D1A5C061387 for ; Wed, 9 Sep 2020 23:55:07 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id y15so4635403wmi.0 for ; Wed, 09 Sep 2020 23:55:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=watylvtavvjnlIiL88AKksk2UODGv6ozdE6QDJoiV0Y=; b=NSqRghSS5cx169+IIyEEIA1pUSywUIf49yMu9NjwR/xkjzO8d+5PfOmm/TYRQ/f1mB 6haERzzrHCa7y3x7YGpFMKZxl18fS2UOM03jbFZpzIxhw5FccwGMDO5OePh43gsFdrB/ +5aespm/3GiFg8l6B+zhD45sSafvLk2OGp0CJXT8oBww2J9WynDl3a2vwR+iVNQ/RdbZ /9QQbYRMc2jiSjkec3omZrbtZFJ62tfzvXKNtCU7vvZIOV+Tj3mdh3z0cUa9dmXXIWS9 x2RrSWUpMB6gM7zUhAPhiu+5qja0KiPaNBvVhZsENyHzniZz03hBFq+ediLRAtlirXcG UQWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=watylvtavvjnlIiL88AKksk2UODGv6ozdE6QDJoiV0Y=; b=cuVYA4zVNqH+/c/JfSLyEG8zJplYyDvS1yfbfV/42/2mnXSNRkkgikuHH2a3+s8LSm fEQcGpX0YzqELymWYvgibcaFPHF8cx6Pk8gm5xsC79pmByTWbTviPtpadDlW4ZNXKCWs JNfXH2cDfEJq9z9t8zM+9BxgH/yqupXYWWOCAxTFU5n+LphytkJa2arm40oVFAoPfxOF 58unhpaNdPq9XDhxnRlqt52pyAatPoIjmHbZsfoTM2iw6xx2/ZvpVg81DXIfQT7RtEZ5 Ty2zJuJSM/oJdcw1LNkNTEU0cKvgskpp2H1ynwn/wl1lzEaWThstN1wwErd7F55xKeEh Kw/g== X-Gm-Message-State: AOAM530WUxL8OTHgTpX/SOhKGACvmiLCN976S7aBsGy9DLD1+8bBNKWm /1swQmm2GCGSxQK4KOJRiIa9FQ== X-Google-Smtp-Source: ABdhPJzWXsjc1qiY/ASKSBUySqorjX/uq7tPPkWgWr2DpV+zKNAZ9eOWEtsMDRTvwiFH7rKrsK7pIw== X-Received: by 2002:a1c:6254:: with SMTP id w81mr6750493wmb.94.1599720905943; Wed, 09 Sep 2020 23:55:05 -0700 (PDT) Received: from dell.default ([91.110.221.246]) by smtp.gmail.com with ESMTPSA id m3sm2444028wme.31.2020.09.09.23.55.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 23:55:05 -0700 (PDT) From: Lee Jones To: kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Lee Jones , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless Subject: [PATCH 11/29] iwlwifi: dvm: scan: Demote a few nonconformant kernel-doc headers Date: Thu, 10 Sep 2020 07:54:13 +0100 Message-Id: <20200910065431.657636-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200910065431.657636-1-lee.jones@linaro.org> References: <20200910065431.657636-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org 2 of which do not attempt to document their parameters, 1 does a poor job. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/dvm/scan.c:193: warning: Function parameter or member 'priv' not described in 'iwl_scan_cancel' drivers/net/wireless/intel/iwlwifi/dvm/scan.c:205: warning: Function parameter or member 'priv' not described in 'iwl_scan_cancel_timeout' drivers/net/wireless/intel/iwlwifi/dvm/scan.c:570: warning: Function parameter or member 'frame' not described in 'iwl_fill_probe_req' drivers/net/wireless/intel/iwlwifi/dvm/scan.c:570: warning: Function parameter or member 'ta' not described in 'iwl_fill_probe_req' drivers/net/wireless/intel/iwlwifi/dvm/scan.c:570: warning: Function parameter or member 'ies' not described in 'iwl_fill_probe_req' drivers/net/wireless/intel/iwlwifi/dvm/scan.c:570: warning: Function parameter or member 'ie_len' not described in 'iwl_fill_probe_req' drivers/net/wireless/intel/iwlwifi/dvm/scan.c:570: warning: Function parameter or member 'ssid' not described in 'iwl_fill_probe_req' drivers/net/wireless/intel/iwlwifi/dvm/scan.c:570: warning: Function parameter or member 'ssid_len' not described in 'iwl_fill_probe_req' drivers/net/wireless/intel/iwlwifi/dvm/scan.c:570: warning: Function parameter or member 'left' not described in 'iwl_fill_probe_req' Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlwifi/dvm/scan.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/scan.c b/drivers/net/wireless/intel/iwlwifi/dvm/scan.c index 1d8590046ff7d..832fcbb787e98 100644 --- a/drivers/net/wireless/intel/iwlwifi/dvm/scan.c +++ b/drivers/net/wireless/intel/iwlwifi/dvm/scan.c @@ -186,7 +186,7 @@ static void iwl_do_scan_abort(struct iwl_priv *priv) IWL_DEBUG_SCAN(priv, "Successfully send scan abort\n"); } -/** +/* * iwl_scan_cancel - Cancel any currently executing HW scan */ int iwl_scan_cancel(struct iwl_priv *priv) @@ -196,10 +196,9 @@ int iwl_scan_cancel(struct iwl_priv *priv) return 0; } -/** +/* * iwl_scan_cancel_timeout - Cancel any currently executing HW scan * @ms: amount of time to wait (in milliseconds) for scan to abort - * */ void iwl_scan_cancel_timeout(struct iwl_priv *priv, unsigned long ms) { @@ -560,10 +559,9 @@ static int iwl_get_channels_for_scan(struct iwl_priv *priv, return added; } -/** +/* * iwl_fill_probe_req - fill in all required fields and IE for probe request */ - static u16 iwl_fill_probe_req(struct ieee80211_mgmt *frame, const u8 *ta, const u8 *ies, int ie_len, const u8 *ssid, u8 ssid_len, int left)