diff mbox series

brcmsmac: main: Eliminate empty brcms_c_down_del_timer()

Message ID 20200910140446.1168049-1-yanaijie@huawei.com
State Accepted
Commit b86acf155c1c350e576daa1c80cf091e0141c6e3
Delegated to: Kalle Valo
Headers show
Series brcmsmac: main: Eliminate empty brcms_c_down_del_timer() | expand

Commit Message

Jason Yan Sept. 10, 2020, 2:04 p.m. UTC
This function does nothing so remove it. This addresses the following
coccicheck warning:

drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c:5103:6-15:
Unneeded variable: "callbacks". Return "0" on line 5105

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
 drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 9 ---------
 1 file changed, 9 deletions(-)

Comments

Kalle Valo Sept. 16, 2020, 6:05 a.m. UTC | #1
Jason Yan <yanaijie@huawei.com> wrote:

> This function does nothing so remove it. This addresses the following
> coccicheck warning:
> 
> drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c:5103:6-15:
> Unneeded variable: "callbacks". Return "0" on line 5105
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>

Patch applied to wireless-drivers-next.git, thanks.

b86acf155c1c brcmsmac: main: Eliminate empty brcms_c_down_del_timer()
diff mbox series

Patch

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c
index 21691581b532..763e0ec583d7 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c
@@ -5085,13 +5085,6 @@  int brcms_c_up(struct brcms_c_info *wlc)
 	return 0;
 }
 
-static uint brcms_c_down_del_timer(struct brcms_c_info *wlc)
-{
-	uint callbacks = 0;
-
-	return callbacks;
-}
-
 static int brcms_b_bmac_down_prep(struct brcms_hardware *wlc_hw)
 {
 	bool dev_gone;
@@ -5201,8 +5194,6 @@  uint brcms_c_down(struct brcms_c_info *wlc)
 			callbacks++;
 		wlc->WDarmed = false;
 	}
-	/* cancel all other timers */
-	callbacks += brcms_c_down_del_timer(wlc);
 
 	wlc->pub->up = false;