From patchwork Tue Mar 16 19:29:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhishek Kumar X-Patchwork-Id: 12143609 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D164EC433DB for ; Tue, 16 Mar 2021 19:31:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD63764EB3 for ; Tue, 16 Mar 2021 19:31:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236898AbhCPTbT (ORCPT ); Tue, 16 Mar 2021 15:31:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237014AbhCPTbA (ORCPT ); Tue, 16 Mar 2021 15:31:00 -0400 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46DDCC06174A for ; Tue, 16 Mar 2021 12:30:59 -0700 (PDT) Received: by mail-pg1-x534.google.com with SMTP id n10so23292515pgl.10 for ; Tue, 16 Mar 2021 12:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pLdF7zoGUozqAe1+lMlJqQTbxjR6BOgEH8RjV/EprUs=; b=S9byXezpGreH4LtkD9u2ztQy1B8C65vjJLVCFOyWBRglz6j8bvwRfaqnDF29WvAy3q FRZxA2UFRBEZ2IDi5SIXjU1ZulqieQZDIBsglTXcYK/l7R2LO7f/sbUBtydFhnsavsMu RKScPGQrJ8kce0XWvyAsS9Xv4hCkT1IQNrz94= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pLdF7zoGUozqAe1+lMlJqQTbxjR6BOgEH8RjV/EprUs=; b=fWJddViwaXRttxy0ixEeWeocoKtYCrjGGjJje5DdZ3fClFiq0laX2giCwknITT5aBo lCP+UEFsarR7XVVkA4JQIzDD6idsGiEzQ8wjzKxlicj0o2seU6ZccX4nLD0smLwNwmQ5 T7LnVDLTOQbU3a8CBXK4dfn3IeqXZKRXUxSnLVcDYGrq6A2/QCh9PxWo/TWLQ4n2VBjo +ffTDAPhO4kz4La5R+eak/z3N2ULkXSp+5cOqJYDZpKbCpxZzzmNbuMP9zy/s0RhuRks M46sbi8feLna2Di9T4jfspaOflldEL5WVu9Eca0/5nxiG19K6EpzdCQiu1Vx4F0AJB3O aOSA== X-Gm-Message-State: AOAM531/K2Qoyp3nlGbIGV4oNNRHGf9FrpWaNlvKTIG0rxRCiNp6QSxp GWonyIr5mFL1mT+x+BAz7cdSqg== X-Google-Smtp-Source: ABdhPJyEfD5qyUJpXMnmRwF8LdnvbWjp80VfMkefbF3lX/KgC03qypJ+fvZnPJ5Q4ek1QE9pAW0Wnw== X-Received: by 2002:a05:6a00:1390:b029:20a:5a18:ad0f with SMTP id t16-20020a056a001390b029020a5a18ad0fmr886287pfg.66.1615923058874; Tue, 16 Mar 2021 12:30:58 -0700 (PDT) Received: from kuabhs-cdev.c.googlers.com.com (254.80.82.34.bc.googleusercontent.com. [34.82.80.254]) by smtp.gmail.com with ESMTPSA id d6sm17097605pfq.109.2021.03.16.12.30.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 12:30:58 -0700 (PDT) From: Abhishek Kumar To: johannes@sipsolutions.net Cc: kuabhs@chromium.org, netdev@vger.kernel.org, "David S . Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org, briannorris@chromium.org, linux-wireless@vger.kernel.org Subject: [PATCH] net: wireless: search and hold bss in cfg80211_connect_done Date: Tue, 16 Mar 2021 19:29:58 +0000 Message-Id: <20210316192919.1.I26d48d8a4d06ef9bd2b57f857c58ae681cc33783@changeid> X-Mailer: git-send-email 2.31.0.rc2.261.g7f71774620-goog MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If BSS instance is not provided in __cfg80211_connect_result then a get bss is performed. This can return NULL if the BSS for the given SSID is expired due to delayed scheduling of connect result event in rdev->event_work. This can cause WARN_ON(!cr->bss) in __cfg80211_connect_result to be triggered and cause cascading failures. To mitigate this, initiate a get bss call in cfg80211_connect_done itself and hold it to ensure that the BSS instance does not get expired. Signed-off-by: Abhishek Kumar Reported-by: kernel test robot --- net/wireless/sme.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/net/wireless/sme.c b/net/wireless/sme.c index 07756ca5e3b5..52f65991accd 100644 --- a/net/wireless/sme.c +++ b/net/wireless/sme.c @@ -724,15 +724,8 @@ void __cfg80211_connect_result(struct net_device *dev, } #endif - if (!cr->bss && (cr->status == WLAN_STATUS_SUCCESS)) { + if (cr->status == WLAN_STATUS_SUCCESS) WARN_ON_ONCE(!wiphy_to_rdev(wdev->wiphy)->ops->connect); - cr->bss = cfg80211_get_bss(wdev->wiphy, NULL, cr->bssid, - wdev->ssid, wdev->ssid_len, - wdev->conn_bss_type, - IEEE80211_PRIVACY_ANY); - if (cr->bss) - cfg80211_hold_bss(bss_from_pub(cr->bss)); - } if (wdev->current_bss) { cfg80211_unhold_bss(wdev->current_bss); @@ -882,6 +875,18 @@ void cfg80211_connect_done(struct net_device *dev, ev->cr.fils.update_erp_next_seq_num = params->fils.update_erp_next_seq_num; if (params->fils.update_erp_next_seq_num) ev->cr.fils.erp_next_seq_num = params->fils.erp_next_seq_num; + + /* Acquire and hold the bss if bss is not provided in argument. + * This ensures that the BSS does not get expired if the schedule + * of the rdev->event_work gets delayed. + */ + if (!params->bss && params->bssid) + params->bss = cfg80211_get_bss(wdev->wiphy, NULL, + params->bssid, + wdev->ssid, wdev->ssid_len, + wdev->conn_bss_type, + IEEE80211_PRIVACY_ANY); + if (params->bss) cfg80211_hold_bss(bss_from_pub(params->bss)); ev->cr.bss = params->bss;