| Message ID | 20210330120533.102712-1-zhangjianhua18@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [-next,v2] drivers: net: CONFIG_ATH9K select LEDS_CLASS and NEW_LEDS | expand |
Zhang Jianhua <zhangjianhua18@huawei.com> wrote: > If CONFIG_ATH9K=y, the following errors will be seen while compiling > gpio.c > > drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_deinit_leds': > gpio.c:(.text+0x604): undefined reference to `led_classdev_unregister' > gpio.c:(.text+0x604): relocation truncated to fit: R_AARCH64_CALL26 > against undefined symbol `led_classdev_unregister' > drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_init_leds': > gpio.c:(.text+0x708): undefined reference to `led_classdev_register_ext' > gpio.c:(.text+0x708): relocation truncated to fit: R_AARCH64_CALL26 > against undefined symbol `led_classdev_register_ext' > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhang Jianhua <zhangjianhua18@huawei.com> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Recently there was a related fix, I need more information about this problem. What is exactly causing this? Is this a recent regression or an old problem? Can someone review this?
Zhang Jianhua <zhangjianhua18@huawei.com> wrote: > If CONFIG_ATH9K=y, the following errors will be seen while compiling > gpio.c > > drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_deinit_leds': > gpio.c:(.text+0x604): undefined reference to `led_classdev_unregister' > gpio.c:(.text+0x604): relocation truncated to fit: R_AARCH64_CALL26 > against undefined symbol `led_classdev_unregister' > drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_init_leds': > gpio.c:(.text+0x708): undefined reference to `led_classdev_register_ext' > gpio.c:(.text+0x708): relocation truncated to fit: R_AARCH64_CALL26 > against undefined symbol `led_classdev_register_ext' > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Zhang Jianhua <zhangjianhua18@huawei.com> No responses to my questions so I'm dropping this. Patch set to Changes Requested.
diff --git a/drivers/net/wireless/ath/ath9k/Kconfig b/drivers/net/wireless/ath/ath9k/Kconfig index e150d82eddb6..0a73ede3148a 100644 --- a/drivers/net/wireless/ath/ath9k/Kconfig +++ b/drivers/net/wireless/ath/ath9k/Kconfig @@ -24,6 +24,8 @@ config ATH9K select MAC80211_LEDS if LEDS_CLASS=y || LEDS_CLASS=MAC80211 select ATH9K_HW select ATH9K_COMMON + select NEW_LEDS + select LEDS_CLASS help This module adds support for wireless adapters based on Atheros IEEE 802.11n AR5008, AR9001 and AR9002 family
If CONFIG_ATH9K=y, the following errors will be seen while compiling gpio.c drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_deinit_leds': gpio.c:(.text+0x604): undefined reference to `led_classdev_unregister' gpio.c:(.text+0x604): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `led_classdev_unregister' drivers/net/wireless/ath/ath9k/gpio.o: In function `ath_init_leds': gpio.c:(.text+0x708): undefined reference to `led_classdev_register_ext' gpio.c:(.text+0x708): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `led_classdev_register_ext' Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhang Jianhua <zhangjianhua18@huawei.com> --- v2: add 'select NEW_LEDS' --- drivers/net/wireless/ath/ath9k/Kconfig | 2 ++ 1 file changed, 2 insertions(+)