diff mbox series

brcmfmac: Add DMI nvram filename quirk for Cyberbook T116 tablet

Message ID 20210928160633.96928-1-hdegoede@redhat.com (mailing list archive)
State Accepted
Commit 49c3eb3036e6359c5c20fe76c611a2c0e0d4710e
Delegated to: Kalle Valo
Headers show
Series brcmfmac: Add DMI nvram filename quirk for Cyberbook T116 tablet | expand

Commit Message

Hans de Goede Sept. 28, 2021, 4:06 p.m. UTC
The Cyberbook T116 tablet contains quite generic names in the sys_vendor
and product_name DMI strings, without this patch brcmfmac will try to load:
"brcmfmac43455-sdio.Default string-Default string.txt" as nvram file which
is way too generic.

The nvram file shipped on the factory Android image contains the exact
same settings as those used on the AcePC T8 mini PC, so point the new
DMI nvram filename quirk to the acepc-t8 nvram file.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Kalle Valo Oct. 5, 2021, 5:31 a.m. UTC | #1
Hans de Goede <hdegoede@redhat.com> wrote:

> The Cyberbook T116 tablet contains quite generic names in the sys_vendor
> and product_name DMI strings, without this patch brcmfmac will try to load:
> "brcmfmac43455-sdio.Default string-Default string.txt" as nvram file which
> is way too generic.
> 
> The nvram file shipped on the factory Android image contains the exact
> same settings as those used on the AcePC T8 mini PC, so point the new
> DMI nvram filename quirk to the acepc-t8 nvram file.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Patch applied to wireless-drivers-next.git, thanks.

49c3eb3036e6 brcmfmac: Add DMI nvram filename quirk for Cyberbook T116 tablet
diff mbox series

Patch

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c
index 6d5188b78f2d..0af452dca766 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/dmi.c
@@ -75,6 +75,16 @@  static const struct dmi_system_id dmi_platform_data[] = {
 		},
 		.driver_data = (void *)&acepc_t8_data,
 	},
+	{
+		/* Cyberbook T116 rugged tablet */
+		.matches = {
+			DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"),
+			DMI_EXACT_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
+			DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "20170531"),
+		},
+		/* The factory image nvram file is identical to the ACEPC T8 one */
+		.driver_data = (void *)&acepc_t8_data,
+	},
 	{
 		/* Match for the GPDwin which unfortunately uses somewhat
 		 * generic dmi strings, which is why we test for 4 strings.