diff mbox series

rtw89: fix error function parameter

Message ID 20211019035311.974706-1-lv.ruyi@zte.com.cn (mailing list archive)
State Changes Requested
Delegated to: Kalle Valo
Headers show
Series rtw89: fix error function parameter | expand

Commit Message

CGEL Oct. 19, 2021, 3:53 a.m. UTC 
From: Lv Ruyi <lv.ruyi@zte.com.cn>

This patch fixes the following Coccinelle warning:
drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
WARNING  possible condition with no effect (if == else)

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
---
 drivers/net/wireless/realtek/rtw89/rtw8852a.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ping-Ke Shih Oct. 19, 2021, 5:21 a.m. UTC | #1 
> -----Original Message-----
> From: cgel.zte@gmail.com <cgel.zte@gmail.com>
> Sent: Tuesday, October 19, 2021 11:53 AM
> To: kvalo@codeaurora.org
> Cc: davem@davemloft.net; kuba@kernel.org; Pkshih <pkshih@realtek.com>; lv.ruyi@zte.com.cn;
> linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zeal
> Robot <zealci@zte.com.cn>
> Subject: [PATCH] rtw89: fix error function parameter
> 
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
> 
> This patch fixes the following Coccinelle warning:
> drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> WARNING  possible condition with no effect (if == else)
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>

Thanks for the catch.

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
>  drivers/net/wireless/realtek/rtw89/rtw8852a.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> index b1b87f0aadbb..5c6ffca3a324 100644
> --- a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> +++ b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
> @@ -753,11 +753,11 @@ static void rtw8852a_ctrl_ch(struct rtw89_dev *rtwdev, u8 central_ch,
>                 if (is_2g)
>                         rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
>                                               B_P1_MODE_SEL,
>                                               1, phy_idx);
>  		else
>  			rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
>  					      B_P1_MODE_SEL,
> -					      1, phy_idx);
> +					      0, phy_idx);
>  		/* SCO compensate FC setting */
>  		sco_comp = rtw8852a_sco_mapping(central_ch);
>  		rtw89_phy_write32_idx(rtwdev, R_FC0_BW, B_FC0_BW_INV,
> --
> 2.25.1
Kalle Valo Oct. 20, 2021, 8:50 a.m. UTC | #2 
cgel.zte@gmail.com wrote:

> From: Lv Ruyi <lv.ruyi@zte.com.cn>
> 
> This patch fixes the following Coccinelle warning:
> drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> WARNING  possible condition with no effect (if == else)
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>

Failed to apply, please rebase on top of wireless-drivers-next.

error: patch failed: drivers/net/wireless/realtek/rtw89/rtw8852a.c:753
error: drivers/net/wireless/realtek/rtw89/rtw8852a.c: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch' to see the failed patch
Applying: rtw89: fix error function parameter
Using index info to reconstruct a base tree...
Patch failed at 0001 rtw89: fix error function parameter

Patch set to Changes Requested.
Ping-Ke Shih Oct. 20, 2021, 9:46 a.m. UTC | #3 
> -----Original Message-----
> From: kvalo=codeaurora.org@mg.codeaurora.org <kvalo=codeaurora.org@mg.codeaurora.org> On Behalf Of Kalle
> Valo
> Sent: Wednesday, October 20, 2021 4:50 PM
> To: cgel.zte@gmail.com
> Cc: davem@davemloft.net; kuba@kernel.org; Pkshih <pkshih@realtek.com>; lv.ruyi@zte.com.cn;
> linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zeal Robot
> <zealci@zte.com.cn>
> Subject: Re: [PATCH] rtw89: fix error function parameter
> 
> cgel.zte@gmail.com wrote:
> 
> > From: Lv Ruyi <lv.ruyi@zte.com.cn>
> >
> > This patch fixes the following Coccinelle warning:
> > drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> > WARNING  possible condition with no effect (if == else)
> >
> > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> > Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> 
> Failed to apply, please rebase on top of wireless-drivers-next.
> 
> error: patch failed: drivers/net/wireless/realtek/rtw89/rtw8852a.c:753
> error: drivers/net/wireless/realtek/rtw89/rtw8852a.c: patch does not apply
> error: Did you hand edit your patch?
> It does not apply to blobs recorded in its index.
> hint: Use 'git am --show-current-patch' to see the failed patch
> Applying: rtw89: fix error function parameter
> Using index info to reconstruct a base tree...
> Patch failed at 0001 rtw89: fix error function parameter
> 
> Patch set to Changes Requested.
> 

I think this is because the patch is translated into spaces instead of tabs, 
in this and following statements.
"                if (is_2g)"

--
Ping-Ke
Kalle Valo Oct. 20, 2021, 10:03 a.m. UTC | #4 
Pkshih <pkshih@realtek.com> writes:

>> -----Original Message-----
>> From: kvalo=codeaurora.org@mg.codeaurora.org
>> <kvalo=codeaurora.org@mg.codeaurora.org> On Behalf Of Kalle
>> Valo
>> Sent: Wednesday, October 20, 2021 4:50 PM
>> To: cgel.zte@gmail.com
>> Cc: davem@davemloft.net; kuba@kernel.org; Pkshih
>> <pkshih@realtek.com>; lv.ruyi@zte.com.cn;
>> linux-wireless@vger.kernel.org; netdev@vger.kernel.org;
>> linux-kernel@vger.kernel.org; Zeal Robot
>> <zealci@zte.com.cn>
>> Subject: Re: [PATCH] rtw89: fix error function parameter
>> 
>> cgel.zte@gmail.com wrote:
>> 
>> > From: Lv Ruyi <lv.ruyi@zte.com.cn>
>> >
>> > This patch fixes the following Coccinelle warning:
>> > drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
>> > WARNING  possible condition with no effect (if == else)
>> >
>> > Reported-by: Zeal Robot <zealci@zte.com.cn>
>> > Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
>> > Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>> 
>> Failed to apply, please rebase on top of wireless-drivers-next.
>> 
>> error: patch failed: drivers/net/wireless/realtek/rtw89/rtw8852a.c:753
>> error: drivers/net/wireless/realtek/rtw89/rtw8852a.c: patch does not apply
>> error: Did you hand edit your patch?
>> It does not apply to blobs recorded in its index.
>> hint: Use 'git am --show-current-patch' to see the failed patch
>> Applying: rtw89: fix error function parameter
>> Using index info to reconstruct a base tree...
>> Patch failed at 0001 rtw89: fix error function parameter
>> 
>> Patch set to Changes Requested.
>> 
>
> I think this is because the patch is translated into spaces instead of tabs, 
> in this and following statements.
> "                if (is_2g)"

Ah, I did wonder why it failed as I didn't see any similar patches. We
have an item about this in the wiki:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#format_issues
Ping-Ke Shih Oct. 21, 2021, 1:34 a.m. UTC | #5 
> -----Original Message-----
> From: kvalo=codeaurora.org@mg.codeaurora.org <kvalo=codeaurora.org@mg.codeaurora.org> On Behalf Of Kalle
> Valo
> Sent: Wednesday, October 20, 2021 6:04 PM
> To: Pkshih <pkshih@realtek.com>
> Cc: cgel.zte@gmail.com; davem@davemloft.net; kuba@kernel.org; lv.ruyi@zte.com.cn;
> linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zeal Robot
> <zealci@zte.com.cn>
> Subject: Re: [PATCH] rtw89: fix error function parameter
> 
> Pkshih <pkshih@realtek.com> writes:
> 
> >> -----Original Message-----
> >> From: kvalo=codeaurora.org@mg.codeaurora.org
> >> <kvalo=codeaurora.org@mg.codeaurora.org> On Behalf Of Kalle
> >> Valo
> >> Sent: Wednesday, October 20, 2021 4:50 PM
> >> To: cgel.zte@gmail.com
> >> Cc: davem@davemloft.net; kuba@kernel.org; Pkshih
> >> <pkshih@realtek.com>; lv.ruyi@zte.com.cn;
> >> linux-wireless@vger.kernel.org; netdev@vger.kernel.org;
> >> linux-kernel@vger.kernel.org; Zeal Robot
> >> <zealci@zte.com.cn>
> >> Subject: Re: [PATCH] rtw89: fix error function parameter
> >>
> >> cgel.zte@gmail.com wrote:
> >>
> >> > From: Lv Ruyi <lv.ruyi@zte.com.cn>
> >> >
> >> > This patch fixes the following Coccinelle warning:
> >> > drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> >> > WARNING  possible condition with no effect (if == else)
> >> >
> >> > Reported-by: Zeal Robot <zealci@zte.com.cn>
> >> > Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> >> > Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> >>
> >> Failed to apply, please rebase on top of wireless-drivers-next.
> >>
> >> error: patch failed: drivers/net/wireless/realtek/rtw89/rtw8852a.c:753
> >> error: drivers/net/wireless/realtek/rtw89/rtw8852a.c: patch does not apply
> >> error: Did you hand edit your patch?
> >> It does not apply to blobs recorded in its index.
> >> hint: Use 'git am --show-current-patch' to see the failed patch
> >> Applying: rtw89: fix error function parameter
> >> Using index info to reconstruct a base tree...
> >> Patch failed at 0001 rtw89: fix error function parameter
> >>
> >> Patch set to Changes Requested.
> >>
> >
> > I think this is because the patch is translated into spaces instead of tabs,
> > in this and following statements.
> > "                if (is_2g)"
> 
> Ah, I did wonder why it failed as I didn't see any similar patches. We
> have an item about this in the wiki:
> 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#format_issues
> 

I don't know why neither.

I check the mail header of this patch, the mailer is
"X-Mailer: git-send-email 2.25.1". It should work properly.

Lv Ruyi, could you help to check what happens?

--
Ping-Ke
CGEL Oct. 21, 2021, 3:10 a.m. UTC | #6 
On Thu, Oct 21, 2021 at 01:34:25AM +0000, Pkshih wrote:
> 
> > -----Original Message-----
> > From: kvalo=codeaurora.org@mg.codeaurora.org <kvalo=codeaurora.org@mg.codeaurora.org> On Behalf Of Kalle
> > Valo
> > Sent: Wednesday, October 20, 2021 6:04 PM
> > To: Pkshih <pkshih@realtek.com>
> > Cc: cgel.zte@gmail.com; davem@davemloft.net; kuba@kernel.org; lv.ruyi@zte.com.cn;
> > linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zeal Robot
> > <zealci@zte.com.cn>
> > Subject: Re: [PATCH] rtw89: fix error function parameter
> > 
> > Pkshih <pkshih@realtek.com> writes:
> > 
> > >> -----Original Message-----
> > >> From: kvalo=codeaurora.org@mg.codeaurora.org
> > >> <kvalo=codeaurora.org@mg.codeaurora.org> On Behalf Of Kalle
> > >> Valo
> > >> Sent: Wednesday, October 20, 2021 4:50 PM
> > >> To: cgel.zte@gmail.com
> > >> Cc: davem@davemloft.net; kuba@kernel.org; Pkshih
> > >> <pkshih@realtek.com>; lv.ruyi@zte.com.cn;
> > >> linux-wireless@vger.kernel.org; netdev@vger.kernel.org;
> > >> linux-kernel@vger.kernel.org; Zeal Robot
> > >> <zealci@zte.com.cn>
> > >> Subject: Re: [PATCH] rtw89: fix error function parameter
> > >>
> > >> cgel.zte@gmail.com wrote:
> > >>
> > >> > From: Lv Ruyi <lv.ruyi@zte.com.cn>
> > >> >
> > >> > This patch fixes the following Coccinelle warning:
> > >> > drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> > >> > WARNING  possible condition with no effect (if == else)
> > >> >
> > >> > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > >> > Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> > >> > Acked-by: Ping-Ke Shih <pkshih@realtek.com>
> > >>
> > >> Failed to apply, please rebase on top of wireless-drivers-next.
> > >>
> > >> error: patch failed: drivers/net/wireless/realtek/rtw89/rtw8852a.c:753
> > >> error: drivers/net/wireless/realtek/rtw89/rtw8852a.c: patch does not apply
> > >> error: Did you hand edit your patch?
> > >> It does not apply to blobs recorded in its index.
> > >> hint: Use 'git am --show-current-patch' to see the failed patch
> > >> Applying: rtw89: fix error function parameter
> > >> Using index info to reconstruct a base tree...
> > >> Patch failed at 0001 rtw89: fix error function parameter
> > >>
> > >> Patch set to Changes Requested.
> > >>
> > >
> > > I think this is because the patch is translated into spaces instead of tabs,
> > > in this and following statements.
> > > "                if (is_2g)"
> > 
> > Ah, I did wonder why it failed as I didn't see any similar patches. We
> > have an item about this in the wiki:
> > 
> > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#format_issues
> > 
> 
> I don't know why neither.
> 
> I check the mail header of this patch, the mailer is
> "X-Mailer: git-send-email 2.25.1". It should work properly.
> 
> Lv Ruyi, could you help to check what happens?
> 
> --
> Ping-Ke

Thanks for Ping-Ke's suggestion,you are right.The previous patch
is translated into spaces instead of tabs,and I will submitt a
new correct one.
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtw89/rtw8852a.c b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
index b1b87f0aadbb..5c6ffca3a324 100644
--- a/drivers/net/wireless/realtek/rtw89/rtw8852a.c
+++ b/drivers/net/wireless/realtek/rtw89/rtw8852a.c
@@ -753,11 +753,11 @@  static void rtw8852a_ctrl_ch(struct rtw89_dev *rtwdev, u8 central_ch,
                if (is_2g)
                        rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
                                              B_P1_MODE_SEL,
                                              1, phy_idx);
 		else
 			rtw89_phy_write32_idx(rtwdev, R_P1_MODE,
 					      B_P1_MODE_SEL,
-					      1, phy_idx);
+					      0, phy_idx);
 		/* SCO compensate FC setting */
 		sco_comp = rtw8852a_sco_mapping(central_ch);
 		rtw89_phy_write32_idx(rtwdev, R_FC0_BW, B_FC0_BW_INV,