From patchwork Wed Feb 16 09:31:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 12748308 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6619AC4332F for ; Wed, 16 Feb 2022 09:31:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232254AbiBPJcE (ORCPT ); Wed, 16 Feb 2022 04:32:04 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:48790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232231AbiBPJcB (ORCPT ); Wed, 16 Feb 2022 04:32:01 -0500 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2063.outbound.protection.outlook.com [40.107.220.63]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D09449AE43; Wed, 16 Feb 2022 01:31:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jBgdlHH1+pApWcpY/R8vTzeC9fAf/H4gFdkyWRoUflIkOacGuF/0fp0WdwWc6rNjXD1/+/K9aCzWZd/t6xpToe40tA+nwlVQfDkJk0oSCsvlvQR+mciuAJPJ175mLeAHzIO2s4aD38ORmX7ZcLPtJlaWKE1vvi24eW8yeu4AIwF2P8qXzLwyuJfH7l8Ah8/5UylLp+rrsVMXG9kNksJ20pqYa8oAv58MR1MkRSaYX1ABcmMGdAxRyME+eyarFcZqjotXSAvcMcg7GGHqJsuNlrIQxrXC+UsK3Wq8qsoiITRIdJMOiDDVsRiNJ+NdHiDm6JlfrEfq3GwaWjXGYgwWLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aXUUviQ9L3vGUdKHjfXlc+gn0liG7pMo//txll0Wcf0=; b=Y128oF2/rvtGP8kdfgBb5J5qvWPU8SUxr44cHCeBweh6eEbzmUpMmkvbRaLpvWxKQaXkRs02586pW5UFNUGs5Ubya2cY3HsoHbzb5z5oxUGlv07cAyauFbIEgS49KEAXeqmJRy6ugWElbQY8o0sGCD0jsqKRtmJomTuOH8amHqcykH6RMger383rzdMCUFprV4Md7DpzhWlWxI1zFVBwXnjJoQ9J8uGTL8eo5OliWEpTdoZI/23It17icanNW+bLs9L7UT9JkU8CG2z2EZRo1IQq3D0K3SL5OaNaSzR8bOlOiC9UMwBF59OcYFl5/4DhnmCe1AcwhgYCVrCQFlMC5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aXUUviQ9L3vGUdKHjfXlc+gn0liG7pMo//txll0Wcf0=; b=RVM0fuhtzRaZnARPECRxj4XCjxDU3uyMBEO6w+ZQh1EyOiVEpmJQDqZoaYnhlkELmHW1QUMkEeqh5i98AcFpCGIzwzugAXBzSAfHQMqrlrHm2e7iccQ4sqeIPIJr+W7fKj9UJoauj+TWUtBswhnJ+txawKPyBAcoBJf3UbapHc4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silabs.com; Received: from PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) by PH0PR11MB5143.namprd11.prod.outlook.com (2603:10b6:510:3f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Wed, 16 Feb 2022 09:31:45 +0000 Received: from PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::1b3:e483:7396:1f98]) by PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::1b3:e483:7396:1f98%3]) with mapi id 15.20.4975.019; Wed, 16 Feb 2022 09:31:45 +0000 From: Jerome Pouiller To: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Kalle Valo Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "David S . Miller" , linux-mmc@vger.kernel.org, =?utf-8?q?Pali_Roh=C3=A1r?= , Ulf Hansson , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 1/2] staging: wfx: WF200 has no official SDIO IDs Date: Wed, 16 Feb 2022 10:31:11 +0100 Message-Id: <20220216093112.92469-2-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220216093112.92469-1-Jerome.Pouiller@silabs.com> References: <20220216093112.92469-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR3P189CA0050.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:53::25) To PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 09a763c6-9436-474b-77c5-08d9f12f261b X-MS-TrafficTypeDiagnostic: PH0PR11MB5143:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2331; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9To83nnaBYzEmXl8G1IBDQrI6iDo49RXbxXSn9nCYeDhwqjiZP/MAaMuYYmycbEFg5lrNFqopep6BQxAgvIeNE4ud6owEMpZLwXDzDhgBrTz2XA+02q63mEPQsm0kyDeKFkY9j5cuudCyVHLn+ooCC870xgwRwrfmhK5kF1o91NMNI0pUsQgbPBTko6qJRhrjN/Wc+lvEUFuEzGBHAFdyuu/zhklzqypprazVDMFk3S1EltLoU140sGvh/rE6WV3wpionU+zHcquYxKKVrDe9da2V2z1yC98VctjjezbbuVRPkK4u5RHl8327PhOkQw0qhtMtVZi04daOjSunm+vJblLv9wc/mRN9H2hUNCFO3sDGkwNx89rwxJeFPPLPNmUmKXfHc0qOpOfaaMN//uFqpVCbI40s36hIxqdTbsH8PDva5VNTNrOksewSd+LssIDg1ATC/RX03oVh3dCra4NVsqyK7khHrt4IS+NLLpTXvmaYA4xucMTkxmunKFeN2fzRpRl2cQ9hIJttD2QE7tDjP0W9wuh/exkGxbPBMzIVavNrO8g0Uo/dHNVCZoiyVAQqg8IlSCRSTaNKJJnLVjPszlkiqhtHZsTv5MH25fWgxIkvkyXB++nAD5RcLK9qvPwWuiQVbLLzFzIjOhQogVlD52wtpb8pHxdatyTjd27/Qif7IS0b2nmLkYKXYvxRHFA0m59ar+z2RhiBWXqT+22pA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5657.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(7416002)(36756003)(2906002)(26005)(107886003)(83380400001)(2616005)(6666004)(1076003)(186003)(6512007)(6506007)(52116002)(316002)(508600001)(6486002)(66946007)(54906003)(38350700002)(5660300002)(8936002)(8676002)(6916009)(66476007)(4326008)(66556008)(38100700002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?2fPuho9SO7DgjQWX+ZVp/2eOeYna?= =?utf-8?q?uXm/zuj9vS8SM7lU6vrFTvsug70+UE0/3vQ/DwUDfYK8igtC/4pbm8OVE14m0mYP6?= =?utf-8?q?2y0M3SEYfrQSCEBvbmvl/6EVdOYYuFbwxg5vUnCmSu1JrASuuyXO/9jWBXWf3flNH?= =?utf-8?q?I4C/B4a9kVSJ9fDkRprerrMSC9r6Dv8cRRZp+MLqXYLYoKcJnPGz7fziQgUmu7Qt/?= =?utf-8?q?uPG0UXi/a6ehUz8olhnxt9pnpf25pp+SXDXuJx/VRRH/twGIUuNZu3KZHGVcTkx2D?= =?utf-8?q?M/U494La9QBmCgJU8peDZ5CbiiMdCmcyIcCdKpfDN2WyTDAgxnzuLwe7Na/tjS7Uh?= =?utf-8?q?LCRmr2FFJcApSFGMMWRpsK3gxCEPAI/QQrHM41RKak0DvreLZF4JlT+UqIJRKfrzg?= =?utf-8?q?e9gaBUkDo9pQznJtQqQK8CW2Wj5FdI5zZHoBLZpeHnt5V+mxzw5Z1NnJqArbHXVj1?= =?utf-8?q?tDcNI9XwtiWy6YcA+U6BRX9GIIuxNryCsbJMbS7DE+kSLK7BkbKcLQZJAZirjkLE6?= =?utf-8?q?t3zfdGL7qinpycBtHTDg9bJ0gVd+38eJc+poVVLTVPOVNuFkYY8ZVMtRZ42VUfz1v?= =?utf-8?q?aSGVHVkZfM3WKMKRQJshg1qVHV8HFRTPVdbcnbtXgtzeHhGq52JzwZcBgV9TmzRFg?= =?utf-8?q?20joCbavxBdbQMsuVbc69pLLQ/qRV2KyOsLuCJ1tDS7rwm97IY44f8y1t6wPz3ff8?= =?utf-8?q?NEYo6mB/cdkSv9RkP2xKU3TfZloVSIGSTl2BilCt4X8U+O/CG/xFdQ2PvItBWd5Fx?= =?utf-8?q?gXMJuKFDqTjITMmkReIiJ/De66ILCbZ72KP+yDYgI9O7cNzCvOjKb58C8IxQgNzmG?= =?utf-8?q?EuxDo5xUjzmdShQTBd9+uu1hxFLU7DBPJPykt9ep71/bxPPoAuKwAlJeoBqOIeFPN?= =?utf-8?q?OlFxyrp5MbexxgLlAXmePpZ5wzo7MnR9nG8mrWvMzjGHJl0lLdPGvNlZql3wzTSy6?= =?utf-8?q?tL4Cq8oxxYlu7aBZ7diGCY/tEzm1aMsAAoxcJXfo4f6YFGAeD6yay/0qleCkdusoE?= =?utf-8?q?jdkehCojb3Fcz+dJ+LMOJ5PC5MYZXhpcOLrGalzuXr2CJbiYbTj4gcbiJp629bkSK?= =?utf-8?q?V5FLNXukthCUHU0zBZ5rYfh2Stn7zAq2YeDIuJZ0joXeYUsCCdQxZ2GGydcclns30?= =?utf-8?q?6MKID1Kx/GhDyNEjHlUjArofjkwlIDMVwKTXiR6RXsZyGbrICCzlhFBK7oHK5YRGI?= =?utf-8?q?CkX5x0e3t+CSvc9JHiJRNqlnFENW9/evdcB83hk0dKAadD6PA4VOjVdU/M67B3I+1?= =?utf-8?q?7Pt1OvPaCtUaK9Gupj/seFu5YVPv16knIPahNXWpQjt6vS3HZNDhyEevCah5Qoane?= =?utf-8?q?K2zYeZ7/YU2Y8vgUXpFmQ5Hl8Nu53TSwFhEl3s/oMBw11eNML18+2uwBWMk4p5EF4?= =?utf-8?q?0TyAgmnm/RjDk8SqIpuUtya1Qku5M7IZ1C5/uIMKlt53kgN01xR0tRjnbpk4jbUNk?= =?utf-8?q?2Z7dZuXAg75GwJUIF8KIRFM4yx5ZtYl+NwducwA65P/dIXSylsx/UuJyZgCnzCQQk?= =?utf-8?q?kD5UzGwI2yBTOG9o9b8VEsvwPniqCZaR86Yfwc/GHXYbjEeadKzeryY=3D?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09a763c6-9436-474b-77c5-08d9f12f261b X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2022 09:31:45.6926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: da021bhSjbv4tUy7GNF4GXdd+l+1V2M/BOFX2StnnzsuUqt4k5HFawPPO6uu9X2FT0u53zOTEoz00w7Nj89Vqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5143 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller Some may think that SDIO_VENDOR_ID_SILABS / SDIO_DEVICE_ID_SILABS_WF200 are official SDIO IDs. However, it is not the case, the values used by WF200 are not official (BTW, the driver rely on the DT rather than on the SDIO IDs to probe the device). To avoid any confusion, remove the definitions SDIO_*_ID_SILABS* and use raw values. Signed-off-by: Jérôme Pouiller Reviewed-by: Pali Rohár --- drivers/staging/wfx/bus_sdio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wfx/bus_sdio.c b/drivers/staging/wfx/bus_sdio.c index bc3df85a05b6..312d2d391a24 100644 --- a/drivers/staging/wfx/bus_sdio.c +++ b/drivers/staging/wfx/bus_sdio.c @@ -257,10 +257,9 @@ static void wfx_sdio_remove(struct sdio_func *func) sdio_release_host(func); } -#define SDIO_VENDOR_ID_SILABS 0x0000 -#define SDIO_DEVICE_ID_SILABS_WF200 0x1000 static const struct sdio_device_id wfx_sdio_ids[] = { - { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF200) }, + /* WF200 does not have official VID/PID */ + { SDIO_DEVICE(0x0000, 0x1000) }, { }, }; MODULE_DEVICE_TABLE(sdio, wfx_sdio_ids);