From patchwork Fri Feb 25 11:23:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 12760122 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DA2CC433F5 for ; Fri, 25 Feb 2022 11:24:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240099AbiBYLZ2 (ORCPT ); Fri, 25 Feb 2022 06:25:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240105AbiBYLZ0 (ORCPT ); Fri, 25 Feb 2022 06:25:26 -0500 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2056.outbound.protection.outlook.com [40.107.100.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F5B41DBA91; Fri, 25 Feb 2022 03:24:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T0IzxDssojy0s0/kNJLPqddgCTscyaTVgcUXJk3WwnQl4f79r8A+KMNIITf+AwCAWu8ZlvTcV2SB4KDh1dNG4doZnUIfUXLL3NPZ35HZTfSnl0utko6GB/gtmIZ8HOy98cBQwThZToVdQNFYb9V+wPuvE5lOmXquhctgpqj5PPBqWIji15ECt1vXOdfYjjwIEmOKsm7POBM8wV7LLZmMYTK927tB3HXe15HAKNOWMarCXfhNLlonVJP/d5qQJlupPj4QHPt/xE//Q9z5Ep5OEV363DlT2Ssn0oabYPrIFJO39POpf/xYU8U+3wBXb5eC9Wn9n3eVJfW3j7J1rHgofg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=028fwsTfDIyITA6iQaqifK+WmjUP+SPDAeGTjiM6TDU=; b=QIRVeONeDiwyoyqRQrgw9qvhiB0kB6bqexXpWCEbUGTxDrKMSGTqMRB/mq5I9byNhC+/XIPdt214Oq9sCJrdCX3gxK368oZTyfXs0Ei2EJtkSAChv7ZLGKJKBYDua7Pg8Qsv7emrBk/11eN/r0QhkK8XbM0OtC0xHLUd3d0t9St5NR6ZedDA5DIMrMa5DqzG64tHnyY7rB4egRSisYkYNlsT24c6ICm57n9rSxY3FHqTAVX1KJ533meDRAUH97Bpwo7UKFs41YQHd6gtE2TOFNbxV1VkFSIgEUcCvQncPL4iJGpExaQnR3bo+GY7iCmJCUl6bzTHM6f//9OYvYvMUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=028fwsTfDIyITA6iQaqifK+WmjUP+SPDAeGTjiM6TDU=; b=NMGEkD65IA39wQh2FfyaONzgpyM9KFOaatZZ3MKD3Q4n414ukoIPuKiDY/a0UW/l9F6dDve3WL8kmNAafXH0JRDNauPbYKhgeMit2EfIFdK9srKJ7LWinyW7dQR7+a0gVceIa7dByzmaabTOaPosO5c8ojVBup/co9j2lAf8wi8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=silabs.com; Received: from PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) by DM6PR11MB4362.namprd11.prod.outlook.com (2603:10b6:5:1dd::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Fri, 25 Feb 2022 11:24:41 +0000 Received: from PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66]) by PH0PR11MB5657.namprd11.prod.outlook.com ([fe80::dd2e:8a4e:fc77:1e66%5]) with mapi id 15.20.5017.023; Fri, 25 Feb 2022 11:24:41 +0000 From: Jerome Pouiller To: linux-wireless@vger.kernel.org, Kalle Valo Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , =?utf-8?b?SsOpcsO0bWUgUG91?= =?utf-8?b?aWxsZXI=?= Subject: [PATCH 03/10] staging: wfx: format comments on 100 columns Date: Fri, 25 Feb 2022 12:23:58 +0100 Message-Id: <20220225112405.355599-4-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> References: <20220225112405.355599-1-Jerome.Pouiller@silabs.com> X-ClientProxiedBy: PR3P189CA0052.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:53::27) To PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8e236a48-cd28-41a1-8250-08d9f8516a02 X-MS-TrafficTypeDiagnostic: DM6PR11MB4362:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uStitFjVazwJCymupZaVSIEEQZPWRP+ufbyfCuL0lEy0M7S4JOAFhLswoJsFfbNAaHKPTJZzLgZpHYGYr0wc9t7FbzJgbIJdZI1dWe3J0jWiqHHpDZJJE/9/8gkynTkpv/H5sfPtUIiiuZ5pFSiU2rct/e8ExEMZKnSvRRDa7p6UJV1S6ILXCTV8bt/mgvynawvO72mMLLYzhTuPwm51U7+qkpf33QDFwxQCA86RbIA5sqCdzl/b67IKfDDmCW+Uf2licJ5qVsGGdSaQX0B4bjVtXnk+VZMFIFRkwlB6DiIfmE/ETT/RqaCWJj+PoIXo1Ylc8jxAzl+EO5mP9gp014+BXGsO7DWN+E8c1jt7tuWQjliKVLssYQYokDHrlli7tchaLSBasfalRYI1PWbCy61bpv6MPjQD8xBDOn37TeYosdIIFjx1G0IaOEe978FkNiTsh8ERNVq6MV5o8VHOawEjaHDz4Jqr7enW1rX3Ml7VGOiDV0bWqwYHBdc20gbS6WG5dpjr11yfIm9YaNwcHmVmCv5EeuUVMesO7ekOAannFpCMmbKW2gfc7ZBxpuKX8izbol2bUp/yy1M+inZatv9KRszgAGEuZcA87Fvj1BlNi1esHO26xudtrmFPEV0XAnSI3kE7JhLso0g70qhLjdPOu5LznILPCumYexBGGrrcBdel2UlrN4lCYSGioHERoqHj4ESv+meoHXQ/bfAhWkMsT0ct4rYDCiaero74R2977zpcuLesWm87v9yqHDNP X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR11MB5657.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6512007)(6506007)(1076003)(66946007)(52116002)(8676002)(2616005)(66574015)(26005)(66476007)(5660300002)(66556008)(508600001)(2906002)(83380400001)(54906003)(38100700002)(4326008)(86362001)(6486002)(8936002)(186003)(6666004)(107886003)(36756003)(316002)(38350700002)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?NtGlQzY7kBeQpT5pfUAGaLv5FgHZ?= =?utf-8?q?x7au5D4zCiSp47+rqZZ5lAWVtqoqDd2LAyFTZ9CEbj43u7fgZLbMVjnAZ/3tJm18F?= =?utf-8?q?tzQe6Wed5cEB8nxkQj/07UsJhgx8op6xqlz2U5A+pxy5p/QWKKBGc+c6fGy+Wc9aW?= =?utf-8?q?9cnd+7eV0TzPZ3ABM9v5TuqHiFiA2WP05SNWv/mKI1CK0si1CgCX8HywfHnPbl/cD?= =?utf-8?q?2g9/S5bZML5JttSSKRygbooqg93IjvQ4xSc427V6jpxtvb01FvonweJ7U1DtsZOQn?= =?utf-8?q?sVRtZIkMCIW8XJAc4pjxeyqh94wX8+i+JSOLJLmD1Yf62aVmcPVUswiprgvvdMC4Z?= =?utf-8?q?gHryeARXpFSVTF50+dDnwuNUpbjF5McfArSKi6jn/glK3zBkHtGydzzldCENTA3iP?= =?utf-8?q?HPQOnt4rOQ7cOEy1CUu3w74Uji2oM0ys7hKQQNPjF8ZmTX2FAQY13O/M2AgnkujeY?= =?utf-8?q?mC+RqwCioYLgz8rXeGLAgRfP+y7bVUekM3RBlvE/ib485JQj0uzatMsOCVMQtgsWE?= =?utf-8?q?cW1toC0JwsFyqMqKcxAM3ITxG7bL6gDXvr/13oMTubg2UV+cLCAfczwPVuDysQetU?= =?utf-8?q?HwlLhvwpbH1SL5Ft6oyD7gxhMITvWdg+Zb1YzAEn32naHO8WQZHmRi6c+aD8sKIJg?= =?utf-8?q?nUlkmq6MDkhA1U1jLp0ISKolSPKPmuM4xfcUjz7vP+4+nR3KJ8bVN0SYO/O5qcTu3?= =?utf-8?q?0q3Kw13z/SivqGlkwZQWEg4R8iVCPoO/F1BwNs+1CYKqN5cQU7NjPj5xqKe2vMU2V?= =?utf-8?q?xfoNItrn3yaBwJKyKkkxKwm7HAbwx+dWw7VSWNng4KiDvIbT62CF3v8Wi3zWN5QOP?= =?utf-8?q?Ekls78+DfYHX7NEuClmfsQGuvQ4lib7b3e4jemDNr7l9Yx676ZM5dVUQrZd3xvzU7?= =?utf-8?q?R72HWjJJhHRpU3394iTGkoYNMVRavT1Ihq1UzNCeuaAyg3PPzqh3azvuE/AggV8XF?= =?utf-8?q?6YBAgtG1WRA6yDT/4DNl/C2piLtKCPb98WIZW6SHwWlN+MvbWZK0F9NY+n0CA5RUi?= =?utf-8?q?Y3mXZvCAjvgR7OpRvZz5fysRu5r6DaLKio76eN1STCx9CzsiI4n+OKFi7CV0S9S3/?= =?utf-8?q?rl6eKirW18lJx3p5GSVy+waiACeEYL8lchl1i3Wt5maIAAQDHOvGjuK1CS8shfnZH?= =?utf-8?q?5B22tiPKzoz5GpHKeb4ATJTSJ8SamWCOnTtfX20YuUKtASyPPWIT5exmPn1B9qL+r?= =?utf-8?q?L2RmSuZME2kL12s27vaHicmskFagqEgxENoNc7TdDgUmycXKqLAwcpiIO4PQ+klEb?= =?utf-8?q?O/tbTLi+rPNSjvLN+ZSmW0FEAdV9HMSKh/7QYTe9YHxq3hOZMY+LwnUyM+QOkUbzd?= =?utf-8?q?cUfQMqrQSQ3SfULR+L2/UwM5a8z81UmPATRF9adePFy+aqYTh7xRmLpsiPURHGXO1?= =?utf-8?q?HUx24oMK+BqF0ZWdVr+xFq9PiR0W1XPo8bQbvmdJnyNtgVrv9jC+w3H0eY80qPn0p?= =?utf-8?q?KPYTxzrVOAs+dg9FrZa1o8CZHe32iSdxq4FMk62asgTW7hfAwO9tSVoTcV5ecEwlo?= =?utf-8?q?fcKVZSiU2Q7UP7p/PdXqNFHuGcipb7IQrDixQRmD1SCcrvYCzlrs8Ss=3D?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e236a48-cd28-41a1-8250-08d9f8516a02 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5657.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2022 11:24:40.5453 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WD3kmLrIpsxNlv1kplirVznwDkyJdrnzgfooO2dcPtO6dvXQZUVvbdRPuwDt8fSgYYBhMt67j6ObgVjR43RGZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4362 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Jérôme Pouiller A few comments were not yet formatted on 100 columns. Signed-off-by: Jérôme Pouiller --- drivers/staging/wfx/data_tx.c | 8 ++------ drivers/staging/wfx/queue.c | 9 ++++----- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c index d7bcf3bae08a..e07381b2ff4d 100644 --- a/drivers/staging/wfx/data_tx.c +++ b/drivers/staging/wfx/data_tx.c @@ -117,9 +117,7 @@ static int wfx_tx_policy_get(struct wfx_vif *wvif, struct ieee80211_tx_rate *rat if (idx >= 0) { *renew = false; } else { - /* If policy is not found create a new one using the oldest - * entry in "free" list - */ + /* If policy is not found create a new one using the oldest entry in "free" list */ *renew = true; entry = list_entry(cache->free.prev, struct wfx_tx_policy, link); memcpy(entry->rates, wanted.rates, sizeof(entry->rates)); @@ -494,9 +492,7 @@ void wfx_tx_confirm_cb(struct wfx_dev *wdev, const struct wfx_hif_cnf_tx *arg) wfx_tx_fill_rates(wdev, tx_info, arg); skb_trim(skb, skb->len - tx_priv->icv_size); - /* From now, you can touch to tx_info->status, but do not touch to - * tx_priv anymore - */ + /* From now, you can touch to tx_info->status, but do not touch to tx_priv anymore */ /* FIXME: use ieee80211_tx_info_clear_status() */ memset(tx_info->rate_driver_data, 0, sizeof(tx_info->rate_driver_data)); memset(tx_info->pad, 0, sizeof(tx_info->pad)); diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c index 9186726ff07f..729825230db2 100644 --- a/drivers/staging/wfx/queue.c +++ b/drivers/staging/wfx/queue.c @@ -210,8 +210,8 @@ bool wfx_tx_queues_has_cab(struct wfx_vif *wvif) if (wvif->vif->type != NL80211_IFTYPE_AP) return false; for (i = 0; i < IEEE80211_NUM_ACS; ++i) - /* Note: since only AP can have mcast frames in queue and only - * one vif can be AP, all queued frames has same interface id + /* Note: since only AP can have mcast frames in queue and only one vif can be AP, + * all queued frames has same interface id */ if (!skb_queue_empty_lockless(&wvif->tx_queue[i].cab)) return true; @@ -253,9 +253,8 @@ static struct sk_buff *wfx_tx_queues_get_skb(struct wfx_dev *wdev) skb = skb_dequeue(&queues[i]->cab); if (!skb) continue; - /* Note: since only AP can have mcast frames in queue - * and only one vif can be AP, all queued frames has - * same interface id + /* Note: since only AP can have mcast frames in queue and only one vif can + * be AP, all queued frames has same interface id */ hif = (struct wfx_hif_msg *)skb->data; WARN_ON(hif->interface != wvif->id);