From patchwork Tue Dec 6 10:49:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Kosyh X-Patchwork-Id: 13065669 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E456C352A1 for ; Tue, 6 Dec 2022 10:56:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234444AbiLFK4b (ORCPT ); Tue, 6 Dec 2022 05:56:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234417AbiLFK43 (ORCPT ); Tue, 6 Dec 2022 05:56:29 -0500 X-Greylist: delayed 421 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 06 Dec 2022 02:56:28 PST Received: from forward101p.mail.yandex.net (forward101p.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A1DE38AC for ; Tue, 6 Dec 2022 02:56:28 -0800 (PST) Received: from iva8-7349aab11ef6.qloud-c.yandex.net (iva8-7349aab11ef6.qloud-c.yandex.net [IPv6:2a02:6b8:c0c:77a0:0:640:7349:aab1]) by forward101p.mail.yandex.net (Yandex) with ESMTP id DC8CF59CDB63; Tue, 6 Dec 2022 13:49:25 +0300 (MSK) Received: by iva8-7349aab11ef6.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id KnUKKV0YX8c1-DP2ttQIo; Tue, 06 Dec 2022 13:49:25 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1670323765; bh=nX5rRc1fYE1rUYGX4czhmXiyglfPlnnMYmPDIfaYWsI=; h=Message-Id:Date:Cc:Subject:To:From; b=WK3fA+FOCJEB15gwNSdsUK768K+sa5yZwNsulpHDlfd6eYEXrHzrXuFgePewB+z88 mpsTm+QFta0iO1D0DehajL1WZ/SHFa6yjbuQvN2F+hJ8nMV8ERC5ipJlSVuJM24474 s16qeLQ1SYkWydmYRmD6tVp9Exx2qMS3RX+9oeDQ= Authentication-Results: iva8-7349aab11ef6.qloud-c.yandex.net; dkim=pass header.i=@yandex.ru From: Peter Kosyh To: Ping-Ke Shih Cc: Peter Kosyh , Kalle Valo , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] rtlwifi: btcoexist: fix conditions branches that are never executed Date: Tue, 6 Dec 2022 13:49:19 +0300 Message-Id: <20221206104919.739746-1-pkosyh@yandex.ru> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Commit 40ca18823515 ("rtlwifi: btcoex: 23b 1ant: fine tune for wifi not connected") introduced never executed branches. Compile test only. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Peter Kosyh Acked-by: Ping-Ke Shih --- I'm not sure that patch do right thing! But these two places are really never executed and should be fixed. I hope that Ping-Ka could check this. .../net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c index 70492929d7e4..039bbedb41c2 100644 --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c @@ -1903,7 +1903,7 @@ btc8723b1ant_action_wifi_not_conn_scan(struct btc_coexist *btcoexist) true, 32); halbtc8723b1ant_coex_table_with_type(btcoexist, NORMAL_EXEC, 4); - } else if (bt_link_info->a2dp_exist) { + } else if (bt_link_info->pan_exist) { halbtc8723b1ant_ps_tdma(btcoexist, NORMAL_EXEC, true, 22); halbtc8723b1ant_coex_table_with_type(btcoexist, @@ -1964,8 +1964,7 @@ static void btc8723b1ant_action_wifi_conn_scan(struct btc_coexist *btcoexist) true, 32); halbtc8723b1ant_coex_table_with_type(btcoexist, NORMAL_EXEC, 4); - } else if (bt_link_info->a2dp_exist && - bt_link_info->pan_exist) { + } else if (bt_link_info->pan_exist) { halbtc8723b1ant_ps_tdma(btcoexist, NORMAL_EXEC, true, 22); halbtc8723b1ant_coex_table_with_type(btcoexist,