| Message ID | 20230420130815.8425-1-wangjikai@hust.edu.cn (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [1/2] wifi: mt7601u: delete dead code checking debugfs returns | expand |
On Thu, 20 Apr 2023 13:08:14 +0000 Wang Jikai wrote: > Smatch reports that: > drivers/net/wireless/mediatek/mt7601u/debugfs.c:130 > mt7601u_init_debugfs() warn: 'dir' is an error pointer or valid". > > Debugfs code is not supposed to need error checking so instead of > changing this to if (IS_ERR()) the correct thing is to just delete > the dead code. > > Fixes: c869f77d6abb ("add mt7601u driver") Don't add a Fixes tag on this cleanup. one - dead code is not a bug two - the semantics have changed since the driver was added so it's certainly not the right Fixes tag
diff --git a/drivers/net/wireless/mediatek/mt7601u/debugfs.c b/drivers/net/wireless/mediatek/mt7601u/debugfs.c index 230b0e1061a7..dbddf256921b 100644 --- a/drivers/net/wireless/mediatek/mt7601u/debugfs.c +++ b/drivers/net/wireless/mediatek/mt7601u/debugfs.c @@ -127,8 +127,6 @@ void mt7601u_init_debugfs(struct mt7601u_dev *dev) struct dentry *dir; dir = debugfs_create_dir("mt7601u", dev->hw->wiphy->debugfsdir); - if (!dir) - return; debugfs_create_u8("temperature", 0400, dir, &dev->raw_temp); debugfs_create_u32("temp_mode", 0400, dir, &dev->temp_mode);
Smatch reports that: drivers/net/wireless/mediatek/mt7601u/debugfs.c:130 mt7601u_init_debugfs() warn: 'dir' is an error pointer or valid". Debugfs code is not supposed to need error checking so instead of changing this to if (IS_ERR()) the correct thing is to just delete the dead code. Fixes: c869f77d6abb ("add mt7601u driver") Signed-off-by: Wang Jikai <wangjikai@hust.edu.cn> --- The issue is found by static analysis and remains untested. --- drivers/net/wireless/mediatek/mt7601u/debugfs.c | 2 -- 1 file changed, 2 deletions(-)