From patchwork Tue Jan 23 18:08:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miri Korenblit X-Patchwork-Id: 13527939 X-Patchwork-Delegate: johannes@sipsolutions.net Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EE9F81AC1 for ; Tue, 23 Jan 2024 18:09:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706033353; cv=none; b=BeF7IWyA525xu0QeYPixTTVIP6j1TSLRosLNrggVvWyvZR1uDL/8FR/sX7snVrPQoFQ35otj+MtQZdrYNXWHGoDGd7T4Dvx+VFvIeitZ1jPtTRFz/vO9IgW9gmQMjbevFb+nKXC6tktjbLYvao7WqqAd3sIajoUGKQk7WkYr4uI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706033353; c=relaxed/simple; bh=Fr9Tk3R/5MGDCJ3wxnmfSBFh1krGYhQix5fL+25htlE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nSNrLCUI8iiEXTF7jAT2HmQKuzZ/BtZw3qExzwEBy5f4hvR9eEyY3FwnHWmpTbQiRRNpBJEDSuwbkhUeCwMRwv0TqPVkblZYnsWTQtnGx6vZwKauJWSP9gy50A24r1IR1V9cawodYnR5mycneYX7cCU+qBrjzJpwxbcLOa7ZspY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=MuQtRPoI; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MuQtRPoI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706033352; x=1737569352; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Fr9Tk3R/5MGDCJ3wxnmfSBFh1krGYhQix5fL+25htlE=; b=MuQtRPoIVUy8eU+DyZNMiD8vjGpgM4owyBj2vW8jl4LzwkIC43uQfAKg uCgkm7ME8HBi3QKkGq6iRqIiC0rp9ZXxUCmKqlHqrtdHmC26xKdZlB/i5 NYmEpI1Xgb0YRlf8mgelU18Gs0LJQKDca3ygeMfd4LT0N/krcdoQWaGVj VQdLphyU10YoCQtpd0tsVzya91WHODZbj6slncrNEM48S5juzKnuZYvaU yXhaNfkB5soX6RPZEPuLpuNU+rJTJqT0X/HswjVR8F327sYHuuXuuQj0g ahbyCXSSHT1lYX3qFBXfwSy/Ker9AeFeW/OhD1K1RGgB2KTVRwhCwde+Z A==; X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="501923" X-IronPort-AV: E=Sophos;i="6.05,215,1701158400"; d="scan'208";a="501923" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2024 10:09:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,215,1701158400"; d="scan'208";a="1666592" Received: from unknown (HELO WEIS0040.iil.intel.com) ([10.12.217.108]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2024 10:09:09 -0800 From: Miri Korenblit To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Benjamin Berg , Gregory Greenman , Johannes Berg Subject: [PATCH 10/15] wifi: iwlwifi: skip affinity setting on non-SMP Date: Tue, 23 Jan 2024 20:08:18 +0200 Message-Id: <20240123200528.ed9094390731.Ic4e5e019c01fd4231b99cf4919af5d19d6353869@changeid> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240123180823.2441162-1-miriam.rachel.korenblit@intel.com> References: <20240123180823.2441162-1-miriam.rachel.korenblit@intel.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Israel (74) Limited From: Benjamin Berg Without SMP the function is just a stub that returns an error code. Add a compile time check for CONFIG_SMP in the interest of not logging an error if setting affinity is not possible anyway. Signed-off-by: Benjamin Berg Reviewed-by: Gregory Greenman Reviewed-by: Johannes Berg Signed-off-by: Miri Korenblit --- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c index 63e13577aff8..b5756e168f49 100644 --- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c +++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c @@ -1718,6 +1718,7 @@ iwl_pcie_set_interrupt_capa(struct pci_dev *pdev, static void iwl_pcie_irq_set_affinity(struct iwl_trans *trans) { +#if defined(CONFIG_SMP) int iter_rx_q, i, ret, cpu, offset; struct iwl_trans_pcie *trans_pcie = IWL_TRANS_GET_PCIE_TRANS(trans); @@ -1738,6 +1739,7 @@ static void iwl_pcie_irq_set_affinity(struct iwl_trans *trans) "Failed to set affinity mask for IRQ %d\n", trans_pcie->msix_entries[i].vector); } +#endif } static int iwl_pcie_init_msix_handler(struct pci_dev *pdev,