From patchwork Tue Feb 4 04:23:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Kumar Singh X-Patchwork-Id: 13958587 X-Patchwork-Delegate: quic_jjohnson@quicinc.com Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAB891FFC6E for ; Tue, 4 Feb 2025 04:24:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738643048; cv=none; b=SovWlMDtfhI0eWiLD6MhdqaITwD9iIqrV6YcbyuTnb2wSO7BTipwdKocx2rnqqRrhSos9+PM7MEZj7i/NEb7lk8s82dFTVoOG6/RvqKFtW//iiUQ6nQP4gSxb1BZOekc7j2JaccKZFV1TaVJcFOqst3DIl8/d/F//nLbR7QkNi4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738643048; c=relaxed/simple; bh=2EiBqGmjjFeGbES49N7jBmM1eqO4+flMSSconJRqC+M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CoeiwcKzQXio7cB23RGuSV4PgmgVQNMVGAG9rBy3QNfSOqBKOfXEN6m0qHrV4mLSBz7HWOLlQB6PyOJhjxWx6UYDb0/oBDZixscSBTVi86ikPs1BUWRlOjv93KO7nTkkyhbPAdioh2aXfEiVUh0bOC930YFTC6clvfG8gZOZvtk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UZwRpsvg; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UZwRpsvg" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 5141agpM003953 for ; Tue, 4 Feb 2025 04:24:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LqFb+cP0lljHDkbZ2f9V4FJId+CUmhUIBF5/NENtV5o=; b=UZwRpsvgE66B5fsQ aI5KY/1NRCbroSvbKop353xhUyqvyz3kA8R9jQ7BpdLKAfbEpiCZDJ/2Rb4B5fwM jnImr+5dXYuAmrMCRtLUySv4DFzNxvp+8DhF4ukugLnHaQJw9xDjqOQAuKvQHfxn dE4Med1rZcNiqmspA/WtX8ibOdPSXNhxL9qTD4ruj7ZcrN2lPUsqJMckov/8qjBD ++hV9T1rBijs8A8anovBuJLt0aVRhRqBMtfZfd+hRPHX178Ssv7U7DwSuEWvnq/N 1jmPWeruvr7pOq86V38iXXEPlqhUc3dnroFf8WufdBDqAl71OIMiKKC4W7uD6Szw eec33A== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44k9cn08rf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 04 Feb 2025 04:24:06 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-2f129f7717fso10027758a91.0 for ; Mon, 03 Feb 2025 20:24:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738643045; x=1739247845; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LqFb+cP0lljHDkbZ2f9V4FJId+CUmhUIBF5/NENtV5o=; b=RyRJ/6jRDGhdr39GjGh3knoTYXXEWfOeHTfM9/+yc2pN4D0izWawkmI+fjdxyNbakm 1sLeZFU8P3bVuIy7wkodcj6qMvPmlbWaEC3lxx335Ep7RSAzosoz4YQN1mWq4qDnlio9 N31CG1Wpm4ZQpciuUaN2+JT4ZfzrKl8uUQqri6mD55vepU/h6lM4zryIrFz5WAeVi6Gp 4irMc999E9D9Jl+8Qpk8ajXEwzRxNaxp8pdjlt/fqLmYvXlbJ17RfV6mWo6jbq2+pEln cO79JrwtoraCMNu16aP9B50bFesiVpaarEeL/1MT9PiNOW2MsbjDjv4uhivVxj6A7ris 3Yzw== X-Gm-Message-State: AOJu0YyzWIE5YErkrTYsMLnzFjqflqtoJdozBw/kSTTiIvG2viOGvlke JlSfc5TBdK13Nre7d0r4tr3PRk2m2DPcMe+Izcr8vgGL0+KWvu3pFME/ELmPeysWis19kvY8Yc5 U0Jvh+LXiYwkxlv6Th2KGYV4MQ5PBQJyaiSS2+UNu75SkwhHZc8t2T5HRSGrDGTsZ0Q== X-Gm-Gg: ASbGnctW3Htti1jTrNS18nLX2I1xtX1CUQo49dykctaHx/X055AbQZGrAUCSoEuXPS+ /OYSciCHrwCBOlFwXDlYCAc2s8wWRyQau7OJzhaPaooGNpgh+kQeXC737/OOoXSMrVx8YgbXd4H t+1Nh8qb0+bChkT2UTmQvbIQwAwsku3zhLYIGwjO4MYEDOyzuS7ZSzc1N0LJ38K3ot77xeC/1IJ aHE9bvSEHmoscvhDn3v9CJA7rX3hCWxqBs3BBESe10+JSWBrmUE4yduEibg8A3jW/XDd0jRyU6x d65QiOc+EQtHD4ozAEtsYBpQiN/jdi4HPewVX58FpdFdCHx5+7QdY8y+O6PFVN8RKcTfuCacWJn 16j7dAYU5ZQSStZ8WNZ5Vc15RGzJmqg== X-Received: by 2002:a05:6a20:1596:b0:1e1:ab51:f531 with SMTP id adf61e73a8af0-1ed7a63cc71mr42599423637.22.1738643045175; Mon, 03 Feb 2025 20:24:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IF09iljl5xk+oLZXpbhxTgvu0aBdVTIyAYQE/2Jkms4zcEywMp0Em1Jpv+9zSV+CcejUShJ9g== X-Received: by 2002:a05:6a20:1596:b0:1e1:ab51:f531 with SMTP id adf61e73a8af0-1ed7a63cc71mr42599365637.22.1738643044359; Mon, 03 Feb 2025 20:24:04 -0800 (PST) Received: from hu-adisi-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-acec04796e1sm8897144a12.58.2025.02.03.20.24.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2025 20:24:04 -0800 (PST) From: Aditya Kumar Singh Date: Tue, 04 Feb 2025 09:53:43 +0530 Subject: [PATCH 3/8] wifi: ath12k: remove redundant vif settings during link interface creation Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250204-unlink_link_arvif_from_chanctx-v1-3-675bd4cea339@oss.qualcomm.com> References: <20250204-unlink_link_arvif_from_chanctx-v1-0-675bd4cea339@oss.qualcomm.com> In-Reply-To: <20250204-unlink_link_arvif_from_chanctx-v1-0-675bd4cea339@oss.qualcomm.com> To: Kalle Valo , Jeff Johnson Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org, Aditya Kumar Singh X-Mailer: b4 0.14.2 X-Proofpoint-GUID: ZDS3q5qrsvpwKkFZz60rbMTGtAafMa1i X-Proofpoint-ORIG-GUID: ZDS3q5qrsvpwKkFZz60rbMTGtAafMa1i X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-04_02,2025-01-31_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 clxscore=1015 phishscore=0 suspectscore=0 priorityscore=1501 adultscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2501170000 definitions=main-2502040032 Currently, vif level settings are done in ath12k_mac_assign_link_vif() as well as in ath12k_mac_op_add_interface(). Since it is vif level settings, doing this on per link does not make sense and it contributes to redundant code. Get rid of this redundant code from ath12k_mac_assign_link_vif(). Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 Signed-off-by: Aditya Kumar Singh Reviewed-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath12k/mac.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c index 16e6f2fae943d3fa6a46ab1ba6780c9070418279..7defc2b20fb61dcaec06d0e332c48a1b6cd2f5d6 100644 --- a/drivers/net/wireless/ath/ath12k/mac.c +++ b/drivers/net/wireless/ath/ath12k/mac.c @@ -4022,13 +4022,6 @@ static struct ath12k_link_vif *ath12k_mac_assign_link_vif(struct ath12k_hw *ah, sizeof(arvif->bitrate_mask.control[i].vht_mcs)); } - /* Allocate Default Queue now and reassign during actual vdev create */ - vif->cab_queue = ATH12K_HW_DEFAULT_QUEUE; - for (i = 0; i < ARRAY_SIZE(vif->hw_queue); i++) - vif->hw_queue[i] = ATH12K_HW_DEFAULT_QUEUE; - - vif->driver_flags |= IEEE80211_VIF_SUPPORTS_UAPSD; - rcu_assign_pointer(ahvif->link[arvif->link_id], arvif); ahvif->links_map |= BIT(link_id); synchronize_rcu();