From patchwork Tue May 12 21:54:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 6392021 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1A1E69F32E for ; Tue, 12 May 2015 21:55:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3EAC620380 for ; Tue, 12 May 2015 21:55:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 601C22035D for ; Tue, 12 May 2015 21:55:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933972AbbELVzE (ORCPT ); Tue, 12 May 2015 17:55:04 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:53771 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932808AbbELVzC (ORCPT ); Tue, 12 May 2015 17:55:02 -0400 Received: from wuerfel.localnet ([149.172.15.242]) by mrelayeu.kundenserver.de (mreue103) with ESMTPSA (Nemesis) id 0MRB2F-1YmPw90DPj-00UZ9b; Tue, 12 May 2015 23:54:30 +0200 From: Arnd Bergmann To: Arend Van Spriel Cc: Pieter-Paul Giesberts , "John W. Linville" , linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com, Brett Rudley , Franky Lin , Hante Meuleman , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH] brcmfmac: avoid gcc-5.1 warning Date: Tue, 12 May 2015 23:54:25 +0200 Message-ID: <2201884.BixNBcLJhn@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:DF5zir2frb8andNe6lk3CIGyjidGMXlG5MzRGx2H3rjHoOWam/p QFVHfF7/W4d/6I/+BbL5Uqp0gna+XtKrNKe6/cuF0kGRdhIwTXHRcMNI5eU9MyWrtJC0xT7 fnl2sv1ufJwPTmD5OP+HupCoRZxY4aAaL25wzUnUSDiXXfg6dRVlQUgvD5VqOIuBpTMpjM0 AuSSjFhAhdE6gYGAyGVdQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP gcc-5.0 gained a new warning in the fwsignal portion of the brcmfmac driver: drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c: In function 'brcmf_fws_txs_process': drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c:1478:8: warning: 'skb' may be used uninitialized in this function [-Wmaybe-uninitialized] This is a false positive, and marking the brcmf_fws_hanger_poppkt function as 'static inline' makes the warning go away. I have checked the object file output and while a little code gets moved around, the size of the binary remains identical. Signed-off-by: Arnd Bergmann --- Found while building the ARM imx_v6_v7_defconfig configuration with gcc-5. We try to get all ARM defconfigs to build without warnings normally. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c index f0dda0ecd23b..5017eaa4af45 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c @@ -635,7 +635,7 @@ static int brcmf_fws_hanger_pushpkt(struct brcmf_fws_hanger *h, return 0; } -static int brcmf_fws_hanger_poppkt(struct brcmf_fws_hanger *h, +static inline int brcmf_fws_hanger_poppkt(struct brcmf_fws_hanger *h, u32 slot_id, struct sk_buff **pktout, bool remove_item) {