From patchwork Mon Aug 5 16:29:17 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Lutomirski X-Patchwork-Id: 2838819 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 267D49F479 for ; Mon, 5 Aug 2013 16:29:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D418F2012B for ; Mon, 5 Aug 2013 16:29:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 777D520303 for ; Mon, 5 Aug 2013 16:29:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753292Ab3HEQ3Y (ORCPT ); Mon, 5 Aug 2013 12:29:24 -0400 Received: from mail-pb0-f42.google.com ([209.85.160.42]:57768 "EHLO mail-pb0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752078Ab3HEQ3W (ORCPT ); Mon, 5 Aug 2013 12:29:22 -0400 Received: by mail-pb0-f42.google.com with SMTP id un15so3559693pbc.29 for ; Mon, 05 Aug 2013 09:29:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=GylkllAfo7FfMbkm2ZbwlKJG2HohZ7KWh9SDO17TmY8=; b=X9/Su2kaMPtfG55Jp6F4m02nNRXvXoChecvt0x1I8qLtdbLM+DHMGwd0AzCA9/SeWr dSlCuPk55SLDYayBzD1SdX9J7lg75myImjSa9kOqG3y37xigVnHrpyKGE9n739iCuSnn GdjfaRP9IzxsQFhZHLzD5Dfx+SP4yMWe2fqILZNIZlXI9ao61qSh9ngUbkyKfgrP1N4n h8uByevb/NG8WJWeOXo8MmcmvIvO7SSesrl0bTTEaoCFXmymyprjM3OKLz6i3TdStixN lLiwMzZ3UniqepmGsvgzeUYmlmCNqZ+Be0xgmBq/R7NxXbohbE1fYnLHQT1F//9WmM1W uDrA== X-Received: by 10.68.170.227 with SMTP id ap3mr23081306pbc.194.1375720161430; Mon, 05 Aug 2013 09:29:21 -0700 (PDT) Received: from localhost ([2001:5a8:4:83c0:6917:4cbc:4e7:289d]) by mx.google.com with ESMTPSA id xe9sm28345783pbc.21.2013.08.05.09.29.19 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 05 Aug 2013 09:29:20 -0700 (PDT) From: Andy Lutomirski To: linux-kernel@vger.kernel.org, Kay Sievers Cc: =?ISO-8859-2?Q?Zbigniew_J=EAdrzejewski=2DSzmek?= , systemd-devel@lists.freedesktop.org, Linux Wireless List , linux-hotplug@vger.kernel.org, Intel Linux Wireless , Johannes Berg , Andy Lutomirski Subject: [PATCH] Change CONFIG_FW_LOADER_USER_HELPER to default n and don't select it Date: Mon, 5 Aug 2013 09:29:17 -0700 Message-Id: <325b19bb936d7ebae11edad86aac8f0931e8abd9.1375719828.git.luto@amacapital.net> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: References: X-Gm-Message-State: ALoCoQmYHA4oVBLK6VPn8cseKNs32tr2kOyo37Ub5eUnuj9et6ghoeMmrsgv0CcFf6V790oSKFVd Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The systemd commit below can delay firmware loading by multiple minutes if CONFIG_FW_LOADER_USER_HELPER=y. Unfortunately no one noticed that the systemd-udev change would break new kernels as well as old kernels. Since the kernel apparently can't count on reasonable userspace support, turn this thing off by default. commit a3bd8447be4ea2ce230eb8ae0e815c04d85fa15a Author: Tom Gundersen Date: Mon Mar 18 15:12:18 2013 +0100 udev: make firmware loading optional and disable by default Distros that whish to support old kernels should set --with-firmware-dirs="/usr/lib/firmware/updates:/usr/lib/firmware" to retain the old behaviour. --- drivers/base/Kconfig | 15 +++++++++++---- drivers/firmware/Kconfig | 1 - 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig index 5daa259..de3903e 100644 --- a/drivers/base/Kconfig +++ b/drivers/base/Kconfig @@ -146,13 +146,20 @@ config EXTRA_FIRMWARE_DIR config FW_LOADER_USER_HELPER bool "Fallback user-helper invocation for firmware loading" depends on FW_LOADER - default y + default n help This option enables / disables the invocation of user-helper (e.g. udev) for loading firmware files as a fallback after the - direct file loading in kernel fails. The user-mode helper is - no longer required unless you have a special firmware file that - resides in a non-standard path. + direct file loading in kernel fails. + + Since March 2013, a default udev build does not understand + firmware loading requests. These udev versions will not + even indicate failure; instead they cause long timeouts. + This can dramatically slow down the boot process. + + Say Y only if you have special firmware-loading requirements + and if you have a non-standard helper that will handle these + requests. config DEBUG_DRIVER bool "Driver Core verbose debug messages" diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index 07478728..9387630 100644 --- a/drivers/firmware/Kconfig +++ b/drivers/firmware/Kconfig @@ -64,7 +64,6 @@ config DELL_RBU tristate "BIOS update support for DELL systems via sysfs" depends on X86 select FW_LOADER - select FW_LOADER_USER_HELPER help Say m if you want to have the option of updating the BIOS for your DELL system. Note you need a Dell OpenManage or Dell Update package (DUP)