From patchwork Mon Oct 19 09:39:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 7434841 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 77195BEEA4 for ; Mon, 19 Oct 2015 09:40:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 95D5E2065D for ; Mon, 19 Oct 2015 09:40:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B16D32064E for ; Mon, 19 Oct 2015 09:40:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753585AbbJSJkG (ORCPT ); Mon, 19 Oct 2015 05:40:06 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:57741 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753192AbbJSJkE (ORCPT ); Mon, 19 Oct 2015 05:40:04 -0400 Received: from wuerfel.localnet ([134.3.118.24]) by mrelayeu.kundenserver.de (mreue102) with ESMTPSA (Nemesis) id 0LlFeI-1aMciZ0ZOg-00az8k; Mon, 19 Oct 2015 11:39:33 +0200 From: Arnd Bergmann To: Tony Cho Cc: gregkh@linuxfoundation.org, Stanislav Kholmanskikh , Johnny Kim , Rachel Kim , Chris Park , Glen Lee , Leo Kim , linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] staging/wilc: fix Kconfig dependencies, second try Date: Mon, 19 Oct 2015 11:39:31 +0200 Message-ID: <4253270.hGxaSY0VLA@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <5624A1AF.8080607@atmel.com> References: <5446980.8Rmykv9Tt3@wuerfel> <5624A1AF.8080607@atmel.com> MIME-Version: 1.0 X-Provags-ID: V03:K0:e6yk3FJz8Fkdhdw21jGW27xkgFnlOA6pG7FmNWRkAF9w8pnuXFB dUwkeOSBL1gmaOXLBqa9l9+1UbPR/pI8Yy12izDowMRrYjKfB+6wE+TRa4zeVM74an0ASmN JbAgbqTZtu4ErVJCzk6flugePcqLEf/FXZwgkimSTwF4Gc8P2ClyqoTgQ/TMpfBKb460bkG ppc1PDn/0K8gVdh+nNKWw== X-UI-Out-Filterresults: notjunk:1; V01:K0:SpF4HXfVsrk=:ea0iF7cLor0xQc4Ql/AGyQ SOrd5srU+S10S9kXQCyMoPhDOqR+JgV328A2Qc5jJSOCF5Ec4zvgZ3e/YZhQBrbRuYhx1t+fR PMLx6KyVgB8hQo3o4zAb5NKFwIvlda0yHAiXZM9yAfxnmidR6uHThCjtE86xdqUa9SUZ0J+je TFImZmfElPy7KtV0tfW7O0zmZ6T9Gulz8Du3UaUk/vbUXPWXGw5HpCE0KsgTOSG+VQPX+54dt jZvwy0s2nfvKVjL/ddai0zHlqFuF9N5nmMaEOUn6Wq3lvOG+FzoMzkLqnk6Gi1TqUuGarD+t2 1oPaRVOyZJI7yFbfoPAJtAG2wyGe0R2RD1kHi0mjcMAAgqW4znlzUfP59xDlkVx/nGG+SLvgc aSG6KelpaoDkjFfW8UvsEaBikK52yw52LT7gIr7EqENDpKyzv06cCY1TGRQZktDATorHUqrtt m9A9Yj/f60BIyyliHtLvmO1ng+2qTZ8pT03e+pl28Wux2Wp8pVZ1mtdAOt/fcNhlgvFDeKJiK dfQ6tll8HaWKjLufLS6ZNIXrWP36+cI3kviQ9mjO4EfDKvPM2XNxE/kToMJzGemhUG+QMs3He Vl4Gq3fnotAaMVwWebeJ3pP+MO8FPX80XppkLYZNOf1L0P743gU3UjQ02qR1zHaEdcugVhaFc dIpEBIO14phULmfoCyyhBGj6iWGS0ucw5Fv5tgXUoZxANVA112qPQjhCFGHnNRvOItfGnLl/N bN9SBsa+sgQz+rKQ Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Monday 19 October 2015 16:54:23 Tony Cho wrote: > Hi Arnd Bergmann, > > When I apply this patch, I cannot make WILC1000 module (wilc1000.ko) because CONFIG_WILC1000 is y and also I can see some link errors for the cfg80211 APIs. > > Can you consider this patch? Ah, you are right. I see the same thing now and don't know what caused me to send the patch in an incomplete state. I hope this snippet is the last missing piece: I'll do a few hundred more randconfig builds with this on top and submit it once it succeeds. Arnd --- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/staging/wilc1000/Kconfig b/drivers/staging/wilc1000/Kconfig index ee51b4278088..e3f109655be4 100644 --- a/drivers/staging/wilc1000/Kconfig +++ b/drivers/staging/wilc1000/Kconfig @@ -1,6 +1,7 @@ config WILC1000_DRIVER - bool "WILC1000 support (WiFi only)" + tristate "WILC1000 support (WiFi only)" depends on CFG80211 && WEXT_CORE && INET + depends on MMC || SPI ---help--- This module only support IEEE 802.11n WiFi. @@ -35,7 +36,7 @@ choice config WILC1000_SDIO bool "SDIO support" - depends on MMC + depends on MMC=y || (MMC=m && WILC1000_DRIVER=m) select WILC1000 ---help--- This module adds support for the SDIO interface of adapters using