From patchwork Wed Dec 16 13:08:06 2009
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Roel Kluin <roel.kluin@gmail.com>
X-Patchwork-Id: 68353
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by demeter.kernel.org (8.14.3/8.14.2) with ESMTP id nBI4ixo1005715
	for <patchwork-linux-wireless@patchwork.kernel.org>;
	Fri, 18 Dec 2009 04:46:05 GMT
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933409AbZLPNGQ (ORCPT
	<rfc822;patchwork-linux-wireless@patchwork.kernel.org>);
	Wed, 16 Dec 2009 08:06:16 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755078AbZLPNGP
	(ORCPT <rfc822;linux-wireless-outgoing>);
	Wed, 16 Dec 2009 08:06:15 -0500
Received: from mail-fx0-f221.google.com ([209.85.220.221]:58111 "EHLO
	mail-fx0-f221.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751296AbZLPNGO (ORCPT
	<rfc822;linux-wireless@vger.kernel.org>);
	Wed, 16 Dec 2009 08:06:14 -0500
Received: by fxm21 with SMTP id 21so855788fxm.21
	for <multiple recipients>; Wed, 16 Dec 2009 05:06:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:message-id:date:from
	:user-agent:mime-version:to:subject:content-type
	:content-transfer-encoding;
	bh=cyQQuM30WotJozgclV3SIXBF1o9Qau8JYTpdDIh2Py0=;
	b=kJTy7f6/25rBbODWvjXbugRrBf7t72OOjb7AE3aCsJEIB1oEvv0/dGiVU5mAiuui2M
	xpYRwqeP9YsAotFEurSTgKp2Y5lFuFLn97U6Z+Ke8h5nKZTOHUh84wl94/qPGj1nj1PX
	qLIAwBiMkXcaNt3kOocYBp39I4R2tJMVzgnqs=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=message-id:date:from:user-agent:mime-version:to:subject
	:content-type:content-transfer-encoding;
	b=UrxJEhaobl6nU6UrauHGc1HHCwSJJqlmLjt3p+6PlopF+0JWqocKxzunOzZp6wdXJ5
	VeytIsptQz+Vxf7sQiOUZkt5DxU52wHb57F2+2VvZ3BHgksPumgX2BJliwhYo6vfZCs+
	RWYM8980gzTHA+lA+Rqyd9I/lzUCviYmm9XGE=
Received: by 10.103.53.17 with SMTP id f17mr455082muk.87.1260968772526;
	Wed, 16 Dec 2009 05:06:12 -0800 (PST)
Received: from zoinx.mars (d133062.upc-d.chello.nl [213.46.133.62])
	by mx.google.com with ESMTPS id i5sm3200887mue.57.2009.12.16.05.06.10
	(version=SSLv3 cipher=RC4-MD5);
	Wed, 16 Dec 2009 05:06:11 -0800 (PST)
Message-ID: <4B28DBB6.5030304@gmail.com>
Date: Wed, 16 Dec 2009 14:08:06 +0100
From: Roel Kluin <roel.kluin@gmail.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
	rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-3.9.b4.fc12
	Thunderbird/3.0b4
MIME-Version: 1.0
To: Samuel Ortiz <samuel.ortiz@intel.com>, Zhu Yi <yi.zhu@intel.com>,
	Intel Linux Wireless <ilw@linux.intel.com>,
	linux-wireless@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] iwmc3200wifi: Fix test of unsigned in
	iwm_ntf_stop_resume_tx()
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


diff --git a/drivers/net/wireless/iwmc3200wifi/rx.c b/drivers/net/wireless/iwmc3200wifi/rx.c
index 1c57c1f..9ac72e4 100644
--- a/drivers/net/wireless/iwmc3200wifi/rx.c
+++ b/drivers/net/wireless/iwmc3200wifi/rx.c
@@ -1128,7 +1128,7 @@ static int iwm_ntf_stop_resume_tx(struct iwm_priv *iwm, u8 *buf,
 			struct iwm_tx_queue *txq;
 			u16 queue = iwm_tid_to_queue(bit);
 
-			if (queue < 0)
+			if (queue == -EINVAL)
 				continue;
 
 			txq = &iwm->txq[queue];