From patchwork Wed May 4 11:47:17 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Cavallari X-Patchwork-Id: 753422 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.3) with ESMTP id p44Bxf2D008919 for ; Wed, 4 May 2011 11:59:42 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754494Ab1EDL7k (ORCPT ); Wed, 4 May 2011 07:59:40 -0400 Received: from ext.lri.fr ([129.175.15.4]:55693 "EHLO ext.lri.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754486Ab1EDL7k (ORCPT ); Wed, 4 May 2011 07:59:40 -0400 X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Wed, 04 May 2011 11:59:42 +0000 (UTC) X-Greylist: delayed 729 seconds by postgrey-1.27 at vger.kernel.org; Wed, 04 May 2011 07:59:39 EDT Received: from localhost (localhost [127.0.0.1]) by ext.lri.fr (Postfix) with ESMTP id 316783FE87; Wed, 4 May 2011 13:47:30 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at lri.fr Received: from ext.lri.fr ([127.0.0.1]) by localhost (ext.lri.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bKcYulC4sMVl; Wed, 4 May 2011 13:47:30 +0200 (CEST) Received: from smtp-ng.lri.fr (smtp [129.175.3.73]) by ext.lri.fr (Postfix) with ESMTP id 14B2E3FDB9; Wed, 4 May 2011 13:47:30 +0200 (CEST) Received: from [129.175.11.132] (pc11-132 [129.175.11.132]) by smtp-ng.lri.fr (Postfix) with ESMTP id 0972C6091E; Wed, 4 May 2011 13:47:30 +0200 (CEST) Message-ID: <4DC13CC5.9050909@lri.fr> Date: Wed, 04 May 2011 13:47:17 +0200 From: Nicolas Cavallari User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.15) Gecko/20110402 Icedove/3.1.9 MIME-Version: 1.0 To: "John W. Linville" CC: linux-wireless , Christian Lamparter Subject: [PATCH] carl9170: fix allmulticast mode Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Currently, the driver only disable multicast filtering when the FIF_ALLMULTI driver flag has been just set (ie, if changed_flags& FIF_ALLMULTI and *new_flags& FIF_ALLMULTI) or else it will reenable multicast filtering. But next time, this condition will be false and multicast filtering will be reenabled, even through FIF_ALLMULTI is still set. This mean that allmulticast only works for less than two minutes in ad-hoc mode. This patch fixes that to disable multicast filtering as long as FIF_ALLMULTI is set. Signed-off-by: Nicolas Cavallari Acked-by: Christian Lamparter --- if (multicast != ar->cur_mc_hash) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/wireless/ath/carl9170/main.c b/drivers/net/wireless/ath/carl9170/main.c index 1638468..7d5c65e 100644 --- a/drivers/net/wireless/ath/carl9170/main.c +++ b/drivers/net/wireless/ath/carl9170/main.c @@ -883,7 +883,7 @@ static void carl9170_op_configure_filter(struct ieee80211_hw *hw, * then checking the error flags, later. */ - if (changed_flags& FIF_ALLMULTI&& *new_flags& FIF_ALLMULTI) + if (*new_flags& FIF_ALLMULTI) multicast = ~0ULL;