From patchwork Wed Nov 11 23:54:38 2009
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Larry Finger <Larry.Finger@lwfinger.net>
X-Patchwork-Id: 59460
Received: from vger.kernel.org (vger.kernel.org [209.132.176.167])
	by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id nABNsh9m030629
	for <patchwork-linux-wireless@patchwork.kernel.org>;
	Wed, 11 Nov 2009 23:54:43 GMT
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759450AbZKKXyg (ORCPT
	<rfc822;patchwork-linux-wireless@patchwork.kernel.org>);
	Wed, 11 Nov 2009 18:54:36 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759435AbZKKXyg
	(ORCPT <rfc822;linux-wireless-outgoing>);
	Wed, 11 Nov 2009 18:54:36 -0500
Received: from hrndva-omtalb.mail.rr.com ([71.74.56.124]:46202 "EHLO
	hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by
	vger.kernel.org with ESMTP id S1757535AbZKKXyf (ORCPT
	<rfc822;linux-wireless@vger.kernel.org>);
	Wed, 11 Nov 2009 18:54:35 -0500
Received: from larrylap.site ([65.28.92.235]) by hrndva-omta03.mail.rr.com
	with SMTP
	id <20091111235439648.IRJQ12367@hrndva-omta03.mail.rr.com>;
	Wed, 11 Nov 2009 23:54:39 +0000
Date: Wed, 11 Nov 2009 17:54:38 -0600
From: Larry Finger <Larry.Finger@lwfinger.net>
To: John W Linville <linville@tuxdriver.com>, chunkeey@web.de
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH] p54usb: Remove DMA buffer from stack
Message-ID: <4afb4ebe.aG/GwqejIBV6vYXK%Larry.Finger@lwfinger.net>
User-Agent: Heirloom mailx 12.2 01/07/07
MIME-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


Index: wireless-testing/drivers/net/wireless/p54/p54usb.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/p54/p54usb.c
+++ wireless-testing/drivers/net/wireless/p54/p54usb.c
@@ -426,12 +426,16 @@ static const char p54u_romboot_3887[] =
 static int p54u_firmware_reset_3887(struct ieee80211_hw *dev)
 {
 	struct p54u_priv *priv = dev->priv;
-	u8 buf[4];
+	u8 *buf;
 	int ret;
 
-	memcpy(&buf, p54u_romboot_3887, sizeof(buf));
+	buf = kmalloc(4, GFP_KERNEL);
+	if (!buf)
+		return -ENOMEM;
+ 	memcpy(buf, p54u_romboot_3887, 4);
 	ret = p54u_bulk_msg(priv, P54U_PIPE_DATA,
-			    buf, sizeof(buf));
+			    buf, 4);
+	kfree(buf);
 	if (ret)
 		dev_err(&priv->udev->dev, "(p54usb) unable to jump to "
 			"boot ROM (%d)!\n", ret);