From patchwork Wed Apr 30 14:39:17 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 4094501 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id F2E859F271 for ; Wed, 30 Apr 2014 14:39:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6497820265 for ; Wed, 30 Apr 2014 14:39:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B6822022D for ; Wed, 30 Apr 2014 14:39:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933787AbaD3OjV (ORCPT ); Wed, 30 Apr 2014 10:39:21 -0400 Received: from mail-ob0-f172.google.com ([209.85.214.172]:50127 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933648AbaD3OjU (ORCPT ); Wed, 30 Apr 2014 10:39:20 -0400 Received: by mail-ob0-f172.google.com with SMTP id wo20so2079603obc.3 for ; Wed, 30 Apr 2014 07:39:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type; bh=ex+mZVjID3hfDQ+WSwnfs0gp5qH2wKqbM1uTCjGb9jk=; b=dSHV9MPqYvm4sJ2se0TD+DR4y6xpK0ttzSS0xknCF6y1igOCrlJ1PeDCXmPHeQEhJ9 hXdDinhIOW0xJQ2fgZSkq8+ZwUl8vhIAkYxQ4HXJQVc4lP2Xh1BsMd6X1ptUPHuygpVb mjDYlXqMVVWSJXfQTPwJ4LDcl4jSkEMoGH0nbEGiPAlUFsHm6mysCCu3cToXI3nos2bn ulCbU/ScaxL5L2Y/4UqJDxmL5GbH5yHTDaW07A1G3Gof9I8vBpH3Xr+9KSOda19/2i5Y 5ZKHoVE2BEo1MtjJuFt9b/ew+0I89RyiPuDpWe/2tAreoqBl15dBs1x3jqrHfz3Z/9C2 XPYQ== X-Received: by 10.182.142.229 with SMTP id rz5mr4454649obb.12.1398868759559; Wed, 30 Apr 2014 07:39:19 -0700 (PDT) Received: from larrylap2.site (cpe-69-76-245-152.kc.res.rr.com. [69.76.245.152]) by mx.google.com with ESMTPSA id vh3sm51858016obb.9.2014.04.30.07.39.18 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 30 Apr 2014 07:39:18 -0700 (PDT) Message-ID: <53610B15.4000607@lwfinger.net> Date: Wed, 30 Apr 2014 09:39:17 -0500 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Sven Eckelmann CC: Tim Gardner , Nicolas Vaquero , linux-wireless Subject: Re: Kernel source References: <535E7741.1030607@lwfinger.net> <3262959.TlL8alHHte@bentobox> In-Reply-To: <3262959.TlL8alHHte@bentobox> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Sven and Tim, Attached is a one-line fix for the problem that shows up between 3.8.0-36 and 3.8.0-37. It is just a bare patch file, but feel free to add any explanatory text to make it a proper commit. I have no real understanding as to why this line of code does not cause any problems with later kernel versions, but it does here. In addition, I have not had any reports of problems with other users. That makes me suspect some kind of bad interaction with the user-space network control components in 12.04. Would it be helpful for Nicolas to prepare a bug report at Ubuntu? Larry Index: linux-3.8.37/drivers/net/wireless/rtlwifi/core.c =================================================================== --- linux-3.8.37.orig/drivers/net/wireless/rtlwifi/core.c +++ linux-3.8.37/drivers/net/wireless/rtlwifi/core.c @@ -187,7 +187,6 @@ static int rtl_op_add_interface(struct i rtlpriv->cfg->maps [RTL_IBSS_INT_MASKS]); } - mac->link_state = MAC80211_LINKED; break; case NL80211_IFTYPE_ADHOC: RT_TRACE(rtlpriv, COMP_MAC80211, DBG_LOUD,