From patchwork Fri Oct 24 16:39:17 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 5148861 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 35508C11AC for ; Fri, 24 Oct 2014 16:39:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6E7F020204 for ; Fri, 24 Oct 2014 16:39:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D0C5201F5 for ; Fri, 24 Oct 2014 16:39:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757059AbaJXQjZ (ORCPT ); Fri, 24 Oct 2014 12:39:25 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:50194 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756103AbaJXQjV (ORCPT ); Fri, 24 Oct 2014 12:39:21 -0400 Received: by mail-pa0-f44.google.com with SMTP id et14so1431481pad.17 for ; Fri, 24 Oct 2014 09:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type; bh=M0yUkAbzVbLndj8ZRHG0ZPKZs+DSvgykcbyxNsyYC/g=; b=h9W9JC+B5HBYNqZnET6bFCDBgSvbfGz/8JnFH0mw6HF4og3goIhMPBoHPfd78EDOKU 4Mczyd1+gVOFRBZLxcwousJynLF0/j+t00Z9kd+0GVVJCS+/YQ2qJKCthHo0qxRvzEjv g3frcXOm9VQX6N073nSEg/2QgqkPhHNyKCAJS6DNt0cfSBBSGACCG6KSxyAq4qmFvVFu WROH/gy42EFzcG0vMdchHwksm6GYU6aXejr+GQhH5WZY31SX9WB0+xYsA4jKtXqOmCM+ 2LNrW6os+D2XfHNRpSFOJbtrEeC50AyibS1+fcqLLQhs7jPHH57jWB/eXkA0x85Jb8Ey Qwcg== X-Received: by 10.68.69.7 with SMTP id a7mr3599522pbu.151.1414168760732; Fri, 24 Oct 2014 09:39:20 -0700 (PDT) Received: from linux.site (c-24-16-50-76.hsd1.wa.comcast.net. [24.16.50.76]) by mx.google.com with ESMTPSA id fn4sm4320547pab.39.2014.10.24.09.39.19 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Oct 2014 09:39:19 -0700 (PDT) Message-ID: <544A80B5.1090604@lwfinger.net> Date: Fri, 24 Oct 2014 11:39:17 -0500 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Mike Galbraith CC: linville@tuxdriver.com, linux-wireless@vger.kernel.org, troy_tan@realsil.com.cn, netdev@vger.kernel.org, Murilo Opsfelder Araujo , Thadeu Cascardo Subject: Re: [PATCH V3.18] rtlwifi: Add check for get_btc_status callback References: <1414081629-23002-1-git-send-email-Larry.Finger@lwfinger.net> <1414087731.5231.19.camel@marge.simpson.net> <5449478B.4070908@lwfinger.net> <1414116580.23080.10.camel@marge.simpson.net> In-Reply-To: <1414116580.23080.10.camel@marge.simpson.net> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 10/23/2014 09:09 PM, Mike Galbraith wrote: > On Thu, 2014-10-23 at 13:23 -0500, Larry Finger wrote: > >> I know "rtl8192se:rtl92se_get_desc(): ERR rxdesc :4 not process" messages will >> be fixed by the attached patch. Please send the logs after this is applied. > > Both applied. > > [ 17.717226] cfg80211: World regulatory domain updated: > [ 17.719760] cfg80211: DFS Master region: unset > [ 17.719801] cfg80211: (start_freq - end_freq @ bandwidth), (max_antenna_gain, max_eirp), (dfs_cac_time) > [ 17.724656] cfg80211: (2402000 KHz - 2472000 KHz @ 40000 KHz), (300 mBi, 2000 mBm), (N/A) > [ 17.727087] cfg80211: (2457000 KHz - 2482000 KHz @ 40000 KHz), (300 mBi, 2000 mBm), (N/A) > [ 17.729422] cfg80211: (2474000 KHz - 2494000 KHz @ 20000 KHz), (300 mBi, 2000 mBm), (N/A) > [ 17.731592] cfg80211: (5170000 KHz - 5250000 KHz @ 40000 KHz), (300 mBi, 2000 mBm), (N/A) > [ 17.733702] cfg80211: (5735000 KHz - 5835000 KHz @ 40000 KHz), (300 mBi, 2000 mBm), (N/A) > [ 17.858132] input: HDA Digital PCBeep as /devices/pci0000:00/0000:00:1b.0/sound/card0/hdaudioC0D0/input13 > [ 17.861052] input: HDA Intel Mic as /devices/pci0000:00/0000:00:1b.0/sound/card0/input14 > [ 17.863153] input: HDA Intel Headphone as /devices/pci0000:00/0000:00:1b.0/sound/card0/input15 > [ 17.865356] input: HDA Intel HDMI/DP,pcm=3 as /devices/pci0000:00/0000:00:1b.0/sound/card0/input16 > [ 18.259078] toshiba_acpi: Unknown key 401 > [ 18.661507] Adding 2096476k swap on /dev/sda2. Priority:-1 extents:1 across:2096476k FS > [ 18.984217] rtl8192se 0000:08:00.0: enabling device (0000 -> 0003) > [ 19.025036] rtl8192se: FW Power Save off (module option) > [ 19.027195] rtl8192se: Driver for Realtek RTL8192SE/RTL8191SE > [ 19.027195] Loading firmware rtlwifi/rtl8192sefw.bin > [ 19.095134] ieee80211 phy0: Selected rate control algorithm 'rtl_rc' > [ 19.152305] ------------[ cut here ]------------ > [ 19.154367] WARNING: CPU: 0 PID: 59 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x68/0x80() > [ 19.156445] sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:1c.5/0000:08:00.0/ieee80211/phy0' > [ 19.158562] Modules linked in: arc4 rtl8192se rtl_pci rtlwifi mac80211 snd_hda_codec_hdmi snd_hda_codec_conexant snd_hda_codec_generic uvcvideo btusb videobuf2_core coretemp snd_hda_intel snd_hda_controller snd_hda_codec iTCO_wdt iTCO_vendor_support bluetooth cfg80211 v4l2_common snd_hwdep microcode snd_pcm videodev lpc_ich snd_seq serio_raw snd_timer joydev i2c_i801 videobuf2_vmalloc videobuf2_memops mfd_core snd_seq_device toshiba_acpi sparse_keymap rfkill battery ac snd wmi toshiba_bluetooth toshiba_haps soundcore acpi_cpufreq sg autofs4 i915 drm_kms_helper drm i2c_algo_bit thermal video processor thermal_sys button scsi_dh_rdac scsi_dh_alua scsi_dh_emc scsi_dh_hp_sw scsi_dh netconsole atl1c > [ 19.170633] CPU: 0 PID: 59 Comm: kworker/0:3 Not tainted 3.18.0-master #52 > [ 19.173036] Hardware name: TOSHIBA ????????????????????????????????/????????????????????????????????, BIOS V1.70 09/29/2009 > [ 19.175634] Workqueue: events request_firmware_work_func > [ 19.178247] 0000000000000009 ffff8800379d7a98 ffffffff815878e0 0000000000000001 > [ 19.180947] ffff8800379d7ae8 ffff8800379d7ad8 ffffffff8104c801 00000000000035e0 > [ 19.183573] ffff88003706e000 ffff8800aff86d80 ffff8800b0093d48 ffff88013b027098 > [ 19.186231] Call Trace: > [ 19.188885] [] dump_stack+0x46/0x58 > [ 19.191545] [] warn_slowpath_common+0x81/0xa0 > [ 19.194173] [] warn_slowpath_fmt+0x46/0x50 > [ 19.196707] [] ? kernfs_path+0x48/0x60 > [ 19.199138] [] sysfs_warn_dup+0x68/0x80 > [ 19.201587] [] sysfs_create_dir_ns+0x8e/0xa0 > [ 19.204057] [] kobject_add_internal+0xc9/0x400 > [ 19.206495] [] kobject_add+0x60/0xb0 > [ 19.208938] [] ? mutex_lock+0x16/0x37 > [ 19.211321] [] device_add+0x104/0x600 > [ 19.213692] [] ? lazy_max_pages+0x1e/0x30 > [ 19.216100] [] wiphy_register+0x3fd/0x710 [cfg80211] > [ 19.218504] [] ? __vunmap+0xc2/0x110 > [ 19.220957] [] ? ieee80211_register_hw+0x1ec/0x9a0 [mac80211] > [ 19.223447] [] ieee80211_register_hw+0x368/0x9a0 [mac80211] > [ 19.225916] [] rtl92se_fw_cb+0xab/0x1d0 [rtl8192se] > [ 19.228362] [] request_firmware_work_func+0x30/0x60 > [ 19.230779] [] process_one_work+0x14d/0x3d0 > [ 19.233167] [] worker_thread+0x121/0x480 > [ 19.235498] [] ? process_one_work+0x3d0/0x3d0 > [ 19.237861] [] kthread+0xc9/0xe0 > [ 19.240213] [] ? kthread_create_on_node+0x180/0x180 > [ 19.242534] [] ret_from_fork+0x7c/0xb0 > [ 19.244830] [] ? kthread_create_on_node+0x180/0x180 > [ 19.247125] ---[ end trace 0734244a9269eff8 ]--- > [ 19.249416] ------------[ cut here ]------------ > [ 19.251626] WARNING: CPU: 0 PID: 59 at lib/kobject.c:240 kobject_add_internal+0x294/0x400() > [ 19.253876] kobject_add_internal failed for phy0 with -EEXIST, don't try to register things with the same name in the same directory. > [ 19.256197] Modules linked in: arc4 rtl8192se rtl_pci rtlwifi mac80211 snd_hda_codec_hdmi snd_hda_codec_conexant snd_hda_codec_generic uvcvideo btusb videobuf2_core coretemp snd_hda_intel snd_hda_controller snd_hda_codec iTCO_wdt iTCO_vendor_support bluetooth cfg80211 v4l2_common snd_hwdep microcode snd_pcm videodev lpc_ich snd_seq serio_raw snd_timer joydev i2c_i801 videobuf2_vmalloc videobuf2_memops mfd_core snd_seq_device toshiba_acpi sparse_keymap rfkill battery ac snd wmi toshiba_bluetooth toshiba_haps soundcore acpi_cpufreq sg autofs4 i915 drm_kms_helper drm i2c_algo_bit thermal video processor thermal_sys button scsi_dh_rdac scsi_dh_alua scsi_dh_emc scsi_dh_hp_sw scsi_dh netconsole atl1c > [ 19.269327] CPU: 0 PID: 59 Comm: kworker/0:3 Tainted: G W 3.18.0-master #52 > [ 19.271976] Hardware name: TOSHIBA ????????????????????????????????/????????????????????????????????, BIOS V1.70 09/29/2009 > [ 19.274674] Workqueue: events request_firmware_work_func > [ 19.277301] 0000000000000009 ffff8800379d7af8 ffffffff815878e0 0000000000000001 > [ 19.279875] ffff8800379d7b48 ffff8800379d7b38 ffffffff8104c801 ffff8800379d7b38 > [ 19.282376] ffff880137730350 00000000ffffffef ffff880036a9c940 ffff88013b027098 > [ 19.284844] Call Trace: > [ 19.287151] [] dump_stack+0x46/0x58 > [ 19.289474] [] warn_slowpath_common+0x81/0xa0 > [ 19.291751] [] warn_slowpath_fmt+0x46/0x50 > [ 19.293979] [] kobject_add_internal+0x294/0x400 > [ 19.296192] [] kobject_add+0x60/0xb0 > [ 19.298381] [] ? mutex_lock+0x16/0x37 > [ 19.300578] [] device_add+0x104/0x600 > [ 19.302734] [] ? lazy_max_pages+0x1e/0x30 > [ 19.304909] [] wiphy_register+0x3fd/0x710 [cfg80211] > [ 19.307110] [] ? __vunmap+0xc2/0x110 > [ 19.309305] [] ? ieee80211_register_hw+0x1ec/0x9a0 [mac80211] > [ 19.311512] [] ieee80211_register_hw+0x368/0x9a0 [mac80211] > [ 19.313767] [] rtl92se_fw_cb+0xab/0x1d0 [rtl8192se] > [ 19.315998] [] request_firmware_work_func+0x30/0x60 > [ 19.318260] [] process_one_work+0x14d/0x3d0 > [ 19.320501] [] worker_thread+0x121/0x480 > [ 19.322732] [] ? process_one_work+0x3d0/0x3d0 > [ 19.324987] [] kthread+0xc9/0xe0 > [ 19.327246] [] ? kthread_create_on_node+0x180/0x180 > [ 19.329517] [] ret_from_fork+0x7c/0xb0 > [ 19.331757] [] ? kthread_create_on_node+0x180/0x180 > [ 19.334039] ---[ end trace 0734244a9269eff9 ]--- > [ 19.336275] rtl8192se:rtl92se_fw_cb():<0-0> Can't register mac80211 hw > [ 20.108822] EXT4-fs (sda1): mounted filesystem with ordered data mode. Opts: acl > [ 24.761182] BUG: unable to handle kernel NULL pointer dereference at (null) > [ 24.762764] IP: [< (null)>] (null) > [ 24.764106] PGD 0 > [ 24.764106] Oops: 0010 [#1] SMP > [ 24.764106] Modules linked in: arc4 rtl8192se rtl_pci rtlwifi mac80211 snd_hda_codec_hdmi snd_hda_codec_conexant snd_hda_codec_generic uvcvideo btusb videobuf2_core coretemp snd_hda_intel snd_hda_controller snd_hda_codec iTCO_wdt iTCO_vendor_support bluetooth cfg80211 v4l2_common snd_hwdep microcode snd_pcm videodev lpc_ich snd_seq serio_raw snd_timer joydev i2c_i801 videobuf2_vmalloc videobuf2_memops mfd_core snd_seq_device toshiba_acpi sparse_keymap rfkill battery ac snd wmi toshiba_bluetooth toshiba_haps soundcore acpi_cpufreq sg autofs4 i915 drm_kms_helper drm i2c_algo_bit thermal video processor thermal_sys button scsi_dh_rdac scsi_dh_alua scsi_dh_emc scsi_dh_hp_sw scsi_dh netconsole atl1c > [ 24.764106] CPU: 1 PID: 54 Comm: kworker/1:2 Tainted: G W 3.18.0-master #52 > [ 24.764106] Hardware name: TOSHIBA ????????????????????????????????/????????????????????????????????, BIOS V1.70 09/29/2009 > [ 24.764106] Workqueue: rtl92s_pci rtl_watchdog_wq_callback [rtlwifi] > [ 24.764106] task: ffff88013614c350 ti: ffff880136150000 task.ti: ffff880136150000 > [ 24.764106] RIP: 0010:[<0000000000000000>] [< (null)>] (null) > [ 24.764106] RSP: 0018:ffff880136153d80 EFLAGS: 00010293 > [ 24.764106] RAX: ffffffffa05103c0 RBX: ffff8801377319c0 RCX: 0000000000000000 > [ 24.764106] RDX: 0000000000000001 RSI: 000000000000005d RDI: ffff880137730620 > [ 24.764106] RBP: ffff880136153df8 R08: ffff88013fd12380 R09: 0000000000000001 > [ 24.764106] R10: 0000000000000002 R11: 0000000000000293 R12: ffff880137730620 > [ 24.764106] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 > [ 24.764106] FS: 0000000000000000(0000) GS:ffff88013fd00000(0000) knlGS:0000000000000000 > [ 24.764106] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b > [ 24.764106] CR2: 0000000000000000 CR3: 000000013b249000 CR4: 00000000000407e0 > [ 24.764106] Stack: > [ 24.764106] ffffffffa051e51e ffff88013fd12b00 0000000000000000 ffff88013fd12b00 > [ 24.764106] 0000000000000000 0000000000000000 0000000000000000 0000000000000000 > [ 24.764106] 0000000000000000 ffff880136153e38 ffff880137731be0 ffff880136126b80 > [ 24.764106] Call Trace: > [ 24.764106] [] ? rtl_watchdog_wq_callback+0xfe/0x420 [rtlwifi] > [ 24.764106] [] process_one_work+0x14d/0x3d0 > [ 24.764106] [] worker_thread+0x121/0x480 > [ 24.764106] [] ? process_one_work+0x3d0/0x3d0 > [ 24.764106] [] kthread+0xc9/0xe0 > [ 24.764106] [] ? kthread_create_on_node+0x180/0x180 > [ 24.764106] [] ret_from_fork+0x7c/0xb0 > [ 24.764106] [] ? kthread_create_on_node+0x180/0x180 > [ 24.764106] Code: Bad RIP value. > [ 24.764106] RIP [< (null)>] (null) > [ 24.764106] RSP > [ 24.764106] CR2: 0000000000000000 > [ 24.764106] ---[ end trace 0734244a9269effa ]--- > [ 24.855146] IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready > [ 24.857620] BUG: unable to handle kernel paging request at ffffffffffffffd8 > [ 24.859873] IP: [] kthread_data+0x11/0x20 > [ 24.861381] PGD 1a16067 PUD 1a18067 PMD 0 > [ 24.861381] Oops: 0000 [#2] SMP > [ 24.861381] Modules linked in: arc4 rtl8192se rtl_pci rtlwifi mac80211 snd_hda_codec_hdmi snd_hda_codec_conexant snd_hda_codec_generic uvcvideo btusb videobuf2_core coretemp snd_hda_intel snd_hda_controller snd_hda_codec iTCO_wdt iTCO_vendor_support bluetooth cfg80211 v4l2_common snd_hwdep microcode snd_pcm videodev lpc_ich snd_seq serio_raw snd_timer joydev i2c_i801 videobuf2_vmalloc videobuf2_memops mfd_core snd_seq_device toshiba_acpi sparse_keymap rfkill battery ac snd wmi toshiba_bluetooth toshiba_haps soundcore acpi_cpufreq sg autofs4 i915 drm_kms_helper drm i2c_algo_bit thermal video processor thermal_sys button scsi_dh_rdac scsi_dh_alua scsi_dh_emc scsi_dh_hp_sw scsi_dh netconsole atl1c > [ 24.861381] CPU: 1 PID: 54 Comm: kworker/1:2 Tainted: G D W 3.18.0-master #52 > [ 24.861381] Hardware name: TOSHIBA ????????????????????????????????/????????????????????????????????, BIOS V1.70 09/29/2009 > [ 24.861381] task: ffff88013614c350 ti: ffff880136150000 task.ti: ffff880136150000 > [ 24.861381] RIP: 0010:[] [] kthread_data+0x11/0x20 > [ 24.861381] RSP: 0018:ffff880136153990 EFLAGS: 00010092 > [ 24.861381] RAX: 0000000000000000 RBX: 0000000000000001 RCX: 0000000171a414dc > [ 24.861381] RDX: 0000000000000000 RSI: 0000000000000001 RDI: ffff88013614c350 > [ 24.861381] RBP: ffff8801361539a8 R08: ffff88013614fcd0 R09: 00000000000003d9 > [ 24.861381] R10: 000000000000bc00 R11: 0000000000008ddc R12: ffff88013fd12b00 > [ 24.861381] R13: 0000000000000001 R14: 0000000000000000 R15: ffff88013614c350 > [ 24.861381] FS: 0000000000000000(0000) GS:ffff88013fd00000(0000) knlGS:0000000000000000 > [ 24.861381] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b > [ 24.861381] CR2: 0000000000000028 CR3: 0000000035eba000 CR4: 00000000000407e0 > [ 24.861381] Stack: > [ 24.861381] ffffffff81063145 ffff8801361539a8 ffff88013614c350 ffff880136153a18 > [ 24.861381] ffffffff8158a1ae ffff88013614c350 0000000000012b00 ffff880136153fd8 > [ 24.861381] 0000000000012b00 ffff880136153a08 ffff88013614c350 ffff88013614c350 > [ 24.861381] Call Trace: > [ 24.861381] [] ? wq_worker_sleeping+0x15/0xa0 > [ 24.861381] [] __schedule+0x53e/0x810 > [ 24.861381] [] schedule+0x29/0x70 > [ 24.861381] [] do_exit+0x6a2/0x9e0 > [ 24.861381] [] oops_end+0x8e/0xd0 > [ 24.861381] [] no_context+0x248/0x298 > [ 24.861381] [] __bad_area_nosemaphore+0x6d/0x1c6 > [ 24.861381] [] bad_area_nosemaphore+0x13/0x15 > [ 24.861381] [] __do_page_fault+0x9c/0x530 > [ 24.861381] [] ? cpumask_next_and+0x30/0x50 > [ 24.861381] [] ? load_balance+0x23e/0x830 > [ 24.861381] [] do_page_fault+0xc/0x10 > [ 24.861381] [] page_fault+0x22/0x30 > [ 24.861381] [] ? rtl_watchdog_wq_callback+0xfe/0x420 [rtlwifi] > [ 24.861381] [] process_one_work+0x14d/0x3d0 > [ 24.861381] [] worker_thread+0x121/0x480 > [ 24.861381] [] ? process_one_work+0x3d0/0x3d0 > [ 24.861381] [] kthread+0xc9/0xe0 > [ 24.861381] [] ? kthread_create_on_node+0x180/0x180 > [ 24.861381] [] ret_from_fork+0x7c/0xb0 > [ 24.861381] [] ? kthread_create_on_node+0x180/0x180 > [ 24.861381] Code: 48 89 e5 5d 48 8b 40 c8 48 c1 e8 02 83 e0 01 c3 66 2e 0f 1f 84 00 00 00 00 00 66 66 66 66 90 48 8b 87 60 04 00 00 55 48 89 e5 5d <48> 8b 40 d8 c3 66 2e 0f 1f 84 00 00 00 00 00 66 66 66 66 90 55 > [ 24.861381] RIP [] kthread_data+0x11/0x20 > [ 24.861381] RSP > [ 24.861381] CR2: ffffffffffffffd8 > [ 24.861381] ---[ end trace 0734244a9269effb ]--- > [ 24.861381] Fixing recursive fault but reboot is needed! > [ 24.861381] Kernel panic - not syncing: Watchdog detected hard LOCKUP on cpu 1 > [ 24.861381] Shutting down cpus with NMI > [ 24.861381] Kernel Offset: 0x0 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffff9fffffff) > [ 24.861381] drm_kms_helper: panic occurred, switching back to text console > [ 24.861381] Rebooting in 60 seconds.. Please try the attached patch. It replaces the second one I sent you. I will probably redo it before submitting the final copy, but this should work. Larry diff --git a/drivers/net/wireless/rtlwifi/base.c b/drivers/net/wireless/rtlwifi/base.c index 58ba718..a23ff78 100644 --- a/drivers/net/wireless/rtlwifi/base.c +++ b/drivers/net/wireless/rtlwifi/base.c @@ -1234,7 +1234,8 @@ EXPORT_SYMBOL_GPL(rtl_action_proc); static void setup_arp_tx(struct rtl_priv *rtlpriv, struct rtl_ps_ctl *ppsc) { rtlpriv->ra.is_special_data = true; - if (rtlpriv->cfg->ops->get_btc_status()) + if (rtlpriv->cfg->ops->get_btc_status && + rtlpriv->cfg->ops->get_btc_status()) rtlpriv->btcoexist.btc_ops->btc_special_packet_notify( rtlpriv, 1); rtlpriv->enter_ps = false; @@ -1629,7 +1630,8 @@ void rtl_watchdog_wq_callback(void *data) } } - if (rtlpriv->cfg->ops->get_btc_status()) + if (rtlpriv->cfg->ops->get_btc_status && + rtlpriv->cfg->ops->get_btc_status()) rtlpriv->btcoexist.btc_ops->btc_periodical(rtlpriv); rtlpriv->link_info.bcn_rx_inperiod = 0; diff --git a/drivers/net/wireless/rtlwifi/core.c b/drivers/net/wireless/rtlwifi/core.c index f6179bc..686d256 100644 --- a/drivers/net/wireless/rtlwifi/core.c +++ b/drivers/net/wireless/rtlwifi/core.c @@ -1133,7 +1133,8 @@ static void rtl_op_bss_info_changed(struct ieee80211_hw *hw, ppsc->report_linked = (mstatus == RT_MEDIA_CONNECT) ? true : false; - if (rtlpriv->cfg->ops->get_btc_status()) + if (rtlpriv->cfg->ops->get_btc_status && + rtlpriv->cfg->ops->get_btc_status()) rtlpriv->btcoexist.btc_ops->btc_mediastatus_notify( rtlpriv, mstatus); } @@ -1373,7 +1374,8 @@ static void rtl_op_sw_scan_start(struct ieee80211_hw *hw) return; } - if (rtlpriv->cfg->ops->get_btc_status()) + if (rtlpriv->cfg->ops->get_btc_status && + rtlpriv->cfg->ops->get_btc_status()) rtlpriv->btcoexist.btc_ops->btc_scan_notify(rtlpriv, 1); if (rtlpriv->dm.supp_phymode_switch) { @@ -1425,7 +1427,8 @@ static void rtl_op_sw_scan_complete(struct ieee80211_hw *hw) } rtlpriv->cfg->ops->scan_operation_backup(hw, SCAN_OPT_RESTORE); - if (rtlpriv->cfg->ops->get_btc_status()) + if (rtlpriv->cfg->ops->get_btc_status && + rtlpriv->cfg->ops->get_btc_status()) rtlpriv->btcoexist.btc_ops->btc_scan_notify(rtlpriv, 0); } diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c index 25daa87..ed3364d 100644 --- a/drivers/net/wireless/rtlwifi/pci.c +++ b/drivers/net/wireless/rtlwifi/pci.c @@ -1833,7 +1833,8 @@ static void rtl_pci_stop(struct ieee80211_hw *hw) unsigned long flags; u8 RFInProgressTimeOut = 0; - if (rtlpriv->cfg->ops->get_btc_status()) + if (rtlpriv->cfg->ops->get_btc_status && + rtlpriv->cfg->ops->get_btc_status()) rtlpriv->btcoexist.btc_ops->btc_halt_notify(); /* diff --git a/drivers/net/wireless/rtlwifi/ps.c b/drivers/net/wireless/rtlwifi/ps.c index b69321d..2278af9 100644 --- a/drivers/net/wireless/rtlwifi/ps.c +++ b/drivers/net/wireless/rtlwifi/ps.c @@ -261,7 +261,8 @@ void rtl_ips_nic_off_wq_callback(void *data) ppsc->in_powersavemode = true; /* call before RF off */ - if (rtlpriv->cfg->ops->get_btc_status()) + if (rtlpriv->cfg->ops->get_btc_status && + rtlpriv->cfg->ops->get_btc_status()) rtlpriv->btcoexist.btc_ops->btc_ips_notify(rtlpriv, ppsc->inactive_pwrstate); @@ -306,7 +307,8 @@ void rtl_ips_nic_on(struct ieee80211_hw *hw) ppsc->in_powersavemode = false; _rtl_ps_inactive_ps(hw); /* call after RF on */ - if (rtlpriv->cfg->ops->get_btc_status()) + if (rtlpriv->cfg->ops->get_btc_status && + rtlpriv->cfg->ops->get_btc_status()) rtlpriv->btcoexist.btc_ops->btc_ips_notify(rtlpriv, ppsc->inactive_pwrstate); } @@ -390,14 +392,16 @@ void rtl_lps_set_psmode(struct ieee80211_hw *hw, u8 rt_psmode) if (ppsc->p2p_ps_info.opp_ps) rtl_p2p_ps_cmd(hw , P2P_PS_ENABLE); - if (rtlpriv->cfg->ops->get_btc_status()) + if (rtlpriv->cfg->ops->get_btc_status && + rtlpriv->cfg->ops->get_btc_status()) rtlpriv->btcoexist.btc_ops->btc_lps_notify(rtlpriv, rt_psmode); } else { if (rtl_get_fwlps_doze(hw)) { RT_TRACE(rtlpriv, COMP_RF, DBG_DMESG, "FW LPS enter ps_mode:%x\n", ppsc->fwctrl_psmode); - if (rtlpriv->cfg->ops->get_btc_status()) + if (rtlpriv->cfg->ops->get_btc_status && + rtlpriv->cfg->ops->get_btc_status()) rtlpriv->btcoexist.btc_ops->btc_lps_notify(rtlpriv, rt_psmode); enter_fwlps = true; ppsc->pwr_mode = ppsc->fwctrl_psmode; diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/def.h b/drivers/net/wireless/rtlwifi/rtl8192se/def.h index 83c9867..593646e 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192se/def.h +++ b/drivers/net/wireless/rtlwifi/rtl8192se/def.h @@ -453,6 +453,9 @@ GET_RX_STATUS_DESC_RX_MCS(_pdesc) == DESC92_RATE5_5M ||\ GET_RX_STATUS_DESC_RX_MCS(_pdesc) == DESC92_RATE11M) +#define GET_RX_STATUS_DESC_BUFF_ADDR(__pdesc) \ + SHIFT_AND_MASK_LE(__pdesc + 24, 0, 32) + enum rf_optype { RF_OP_BY_SW_3WIRE = 0, RF_OP_BY_FW, diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/sw.c b/drivers/net/wireless/rtlwifi/rtl8192se/sw.c index 1bff2a0..aa99d97 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192se/sw.c +++ b/drivers/net/wireless/rtlwifi/rtl8192se/sw.c @@ -87,11 +87,8 @@ static void rtl92s_init_aspm_vars(struct ieee80211_hw *hw) static void rtl92se_fw_cb(const struct firmware *firmware, void *context) { struct ieee80211_hw *hw = context; - struct rtl_pci_priv *pcipriv = rtl_pcipriv(hw); struct rtl_priv *rtlpriv = rtl_priv(hw); - struct rtl_pci *rtlpci = rtl_pcidev(pcipriv); struct rt_firmware *pfirmware = NULL; - int err; RT_TRACE(rtlpriv, COMP_ERR, DBG_LOUD, "Firmware callback routine entered!\n"); @@ -112,20 +109,6 @@ static void rtl92se_fw_cb(const struct firmware *firmware, void *context) memcpy(pfirmware->sz_fw_tmpbuffer, firmware->data, firmware->size); pfirmware->sz_fw_tmpbufferlen = firmware->size; release_firmware(firmware); - - err = ieee80211_register_hw(hw); - if (err) { - RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG, - "Can't register mac80211 hw\n"); - return; - } else { - rtlpriv->mac80211.mac80211_registered = 1; - } - rtlpci->irq_alloc = 1; - set_bit(RTL_STATUS_INTERFACE_START, &rtlpriv->status); - - /*init rfkill */ - rtl_init_rfkill(hw); } static int rtl92s_init_sw_vars(struct ieee80211_hw *hw) diff --git a/drivers/net/wireless/rtlwifi/rtl8192se/trx.c b/drivers/net/wireless/rtlwifi/rtl8192se/trx.c index b358ebc..672fd3b 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192se/trx.c +++ b/drivers/net/wireless/rtlwifi/rtl8192se/trx.c @@ -640,6 +640,9 @@ u32 rtl92se_get_desc(u8 *desc, bool istx, u8 desc_name) case HW_DESC_RXPKT_LEN: ret = GET_RX_STATUS_DESC_PKT_LEN(desc); break; + case HW_DESC_RXBUFF_ADDR: + ret = GET_RX_STATUS_DESC_BUFF_ADDR(desc); + break; default: RT_ASSERT(false, "ERR rxdesc :%d not process\n", desc_name);