From patchwork Wed Nov 12 10:40:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arend van Spriel X-Patchwork-Id: 5287011 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id AB2B29F440 for ; Wed, 12 Nov 2014 10:41:06 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D33B920165 for ; Wed, 12 Nov 2014 10:41:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9BA2D2015A for ; Wed, 12 Nov 2014 10:41:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752492AbaKLKlB (ORCPT ); Wed, 12 Nov 2014 05:41:01 -0500 Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:53586 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751451AbaKLKk7 (ORCPT ); Wed, 12 Nov 2014 05:40:59 -0500 X-IronPort-AV: E=Sophos;i="5.07,368,1413270000"; d="scan'208";a="50471074" Received: from irvexchcas08.broadcom.com (HELO IRVEXCHCAS08.corp.ad.broadcom.com) ([10.9.208.57]) by mail-gw2-out.broadcom.com with ESMTP; 12 Nov 2014 03:06:57 -0800 Received: from IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) by IRVEXCHCAS08.corp.ad.broadcom.com (10.9.208.57) with Microsoft SMTP Server (TLS) id 14.3.174.1; Wed, 12 Nov 2014 02:40:58 -0800 Received: from mail-irva-13.broadcom.com (10.10.10.20) by IRVEXCHSMTP1.corp.ad.broadcom.com (10.9.207.51) with Microsoft SMTP Server id 14.3.174.1; Wed, 12 Nov 2014 02:40:57 -0800 Received: from [10.0.2.15] (unknown [10.177.252.193]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 4769340FE9; Wed, 12 Nov 2014 02:40:36 -0800 (PST) Message-ID: <54633939.6000400@broadcom.com> Date: Wed, 12 Nov 2014 11:40:57 +0100 From: Arend van Spriel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Felipe Contreras CC: linux-wireless Mailing List , Samuel Ortiz , "brcm80211-dev-list@broadcom.com" Subject: Re: brcmfmac not working on ECS LIVA References: <545F4611.3010207@broadcom.com> In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 11-11-14 23:32, Felipe Contreras wrote: > On Sun, Nov 9, 2014 at 4:46 AM, Arend van Spriel wrote: > >> Could you share the nvram obtained from EFI? Also please create a kernel log >> with debug=0xd416. > > There you go: > http://people.freedesktop.org/~felipec/dmesg-brcm.txt > It is using the sdhci-acpi driver for the sdio host controller. If I am not mistaken that one does runtime-pm. This has caused issues with our device. This is what happens: 1. driver sends control message and waits for firmware response. 2. runtime pm kicks in and suspends host controller. 3. host controller suspend disable sdio clock. 4. host controller does not detect firmware interrupt for response. 5. control message times out. You can disable it through sysfs, but the patch below may do it. Regards, Arend */ --- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wire index f754ffc..d231e65 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c @@ -27,6 +27,7 @@ #include #include #include +#include #include #include #include @@ -976,6 +977,12 @@ static int brcmf_sdiod_probe(struct brcmf_sdio_dev *sdiodev SG_MAX_SINGLE_ALLOC); sdiodev->max_segment_size = host->max_seg_size; + /* + * Several issues with the driver seem to occur when the SDIO host + * is using runtime-pm. Prevent host from doing runtime-pm here. + */ + __pm_runtime_use_autosuspend(&host->class_dev, false); + /* allocate scatter-gather table. sg support * will be disabled upon allocation failure.