| Message ID | 553DC280.6080503@linux.intel.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
On 04/27/15 07:00, Fu, Zhonghui wrote: > ACPI will manage WiFi chip's power state during suspend/resume > process on some tablet platforms(such as ASUS T100TA). This is > not supported by brcmfmac driver now, and the context of WiFi > chip will be damaged after resume. This patch disconnects the > relationship between WiFi chip and it's ACPI companion, and > prohibit ACPI PM for it. Nice. However, ACPI may contain configuration data that brcmfmac needs on some platforms and Adrian Hunter is looking into this. So it is probably better to do this operation at the end of the probe before returning successful. Regards, Arend > Signed-off-by: Zhonghui Fu<zhonghui.fu@linux.intel.com> > --- > drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 2015/4/27 16:59, Arend van Spriel wrote: > On 04/27/15 07:00, Fu, Zhonghui wrote: >> ACPI will manage WiFi chip's power state during suspend/resume >> process on some tablet platforms(such as ASUS T100TA). This is >> not supported by brcmfmac driver now, and the context of WiFi >> chip will be damaged after resume. This patch disconnects the >> relationship between WiFi chip and it's ACPI companion, and >> prohibit ACPI PM for it. > > Nice. However, ACPI may contain configuration data that brcmfmac needs on some platforms and Adrian Hunter is looking into this. So it is probably better to do this operation at the end of the probe before returning successful. Your comment is right. I introduced another implementation in new patch - "[PATCH v2] brcmfmac: prohibit ACPI power management for brcmfmac driver". Thanks, Zhonghui > > Regards, > Arend > >> Signed-off-by: Zhonghui Fu<zhonghui.fu@linux.intel.com> >> --- >> drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 5 +++++ >> 1 files changed, 5 insertions(+), 0 deletions(-) >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c index 9b508bd..fdf8feb 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c @@ -1114,6 +1114,7 @@ static int brcmf_ops_sdio_probe(struct sdio_func *func, int err; struct brcmf_sdio_dev *sdiodev; struct brcmf_bus *bus_if; + struct device *dev; brcmf_dbg(SDIO, "Enter\n"); brcmf_dbg(SDIO, "Class=%x\n", func->class); @@ -1121,6 +1122,10 @@ static int brcmf_ops_sdio_probe(struct sdio_func *func, brcmf_dbg(SDIO, "sdio device ID: 0x%04x\n", func->device); brcmf_dbg(SDIO, "Function#: %d\n", func->num); + /* prohibit ACPI power management for this device */ + dev = &func->dev; + dev->fwnode = NULL; + /* Consume func num 1 but dont do anything with it. */ if (func->num == 1) return 0;
ACPI will manage WiFi chip's power state during suspend/resume process on some tablet platforms(such as ASUS T100TA). This is not supported by brcmfmac driver now, and the context of WiFi chip will be damaged after resume. This patch disconnects the relationship between WiFi chip and it's ACPI companion, and prohibit ACPI PM for it. Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com> --- drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html