From patchwork Tue Jun 23 12:08:32 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Arend van Spriel X-Patchwork-Id: 6660451 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1028FC05AC for ; Tue, 23 Jun 2015 12:08:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6AEA7206B2 for ; Tue, 23 Jun 2015 12:08:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FC9020645 for ; Tue, 23 Jun 2015 12:08:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754661AbbFWMIh (ORCPT ); Tue, 23 Jun 2015 08:08:37 -0400 Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:25164 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754648AbbFWMIg (ORCPT ); Tue, 23 Jun 2015 08:08:36 -0400 X-IronPort-AV: E=Sophos;i="5.13,665,1427785200"; d="scan'208,223";a="68286130" Received: from irvexchcas07.broadcom.com (HELO IRVEXCHCAS07.corp.ad.broadcom.com) ([10.9.208.55]) by mail-gw1-out.broadcom.com with ESMTP; 23 Jun 2015 06:04:43 -0700 Received: from IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) by IRVEXCHCAS07.corp.ad.broadcom.com (10.9.208.55) with Microsoft SMTP Server (TLS) id 14.3.235.1; Tue, 23 Jun 2015 05:08:35 -0700 Received: from mail-sj1-12.sj.broadcom.com (10.10.10.20) by IRVEXCHSMTP2.corp.ad.broadcom.com (10.9.207.52) with Microsoft SMTP Server id 14.3.235.1; Tue, 23 Jun 2015 05:08:34 -0700 Received: from [10.176.128.60] (xl-bun-02.bun.broadcom.com [10.176.128.60]) by mail-sj1-12.sj.broadcom.com (Postfix) with ESMTP id 2412A27A81; Tue, 23 Jun 2015 05:08:33 -0700 (PDT) Message-ID: <55894C40.1070108@broadcom.com> Date: Tue, 23 Jun 2015 14:08:32 +0200 From: Arend van Spriel User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.24) Gecko/20111103 Lightning/1.0b2 Thunderbird/3.1.16 MIME-Version: 1.0 To: =?UTF-8?B?SsO2cmcgS3JhdXNl?= CC: Arend van Spriel , "linux-wireless@vger.kernel.org" , brcm80211-dev-list Subject: Re: brcmfmac: Failed to create interface p2p-dev-p2p0: -28 (No space left on device) References: <1433766944.28058.16.camel@embedded.rocks> <55758D7E.3000603@broadcom.com> <1433771289.28058.24.camel@embedded.rocks> <5575C6FA.6030104@broadcom.com> <1433794640.28058.26.camel@embedded.rocks> <557605CC.6070907@broadcom.com> <1434448766.21949.9.camel@embedded.rocks> <55803214.2030204@broadcom.com> <1434608018.5481.4.camel@embedded.rocks> <55828106.7060004@broadcom.com> <1434658050.2532.6.camel@embedded.rocks> <55872A3C.7030704@gmail.com> <1435059083.4765.2.camel@embedded.rocks> In-Reply-To: <1435059083.4765.2.camel@embedded.rocks> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 06/23/15 13:31, Jörg Krause wrote: > Hi Arend, > > On So, 2015-06-21 at 23:18 +0200, Arend van Spriel wrote: >> >> My bad. The patch removes p2pdev from interface modes, but it is >> still >> listed in the interface combinations and cfg80211 will complain about >> it. Have to extend the patch. I better do that after a good nights >> sleep. > > Never mind! Did you had a good night sleep already :-) ? Several ;-) Did not get to this earlier. Thanks for the reminder. Had a closer look at wiphy_verify_combinations() and I am hopeful the attached patch will fix the wiphy_register() failure. Regards, Arend > Best regards > Jörg Krause From f490a7cdb2a754ac79af9d9082b8526812164d4f Mon Sep 17 00:00:00 2001 From: Arend van Spriel Date: Tue, 23 Jun 2015 13:59:23 +0200 Subject: [PATCH] brcmfmac: no p2pdev limit needed when p2pon=1 is used Avoid failure upon wiphy_register() by not providing the limit for iftype P2P_DEVICE. Signed-off-by: Arend van Spriel --- drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c index 10eaabf..ffa9aca 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c @@ -5802,6 +5802,10 @@ static int brcmf_setup_wiphy(struct wiphy *wiphy, struct brcmf_if *ifp) ifc_combo.n_limits = ARRAY_SIZE(brcmf_iface_limits_mbss), ifc_combo.limits = brcmf_iface_limits_mbss; } + /* don't give p2pdev limit when p2pon is set */ + if (ifp->drvr->iflist[1]) + ifc_combo.limits--; + wiphy->iface_combinations = kmemdup(&ifc_combo, sizeof(ifc_combo), GFP_KERNEL);