From patchwork Thu Oct 15 12:09:51 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruno Randolf X-Patchwork-Id: 7405561 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D278BBEEA4 for ; Thu, 15 Oct 2015 12:17:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0582C2084D for ; Thu, 15 Oct 2015 12:17:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 118A620848 for ; Thu, 15 Oct 2015 12:17:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753123AbbJOMRf (ORCPT ); Thu, 15 Oct 2015 08:17:35 -0400 Received: from postler.einfach.org ([5.9.2.179]:47474 "EHLO postler.einfach.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752623AbbJOMRd (ORCPT ); Thu, 15 Oct 2015 08:17:33 -0400 X-Greylist: delayed 459 seconds by postgrey-1.27 at vger.kernel.org; Thu, 15 Oct 2015 08:17:33 EDT Received: from [192.168.5.9] (unknown [46.24.114.32]) by postler.einfach.org (Postfix) with ESMTPSA id 1121FC11; Thu, 15 Oct 2015 12:09:52 +0000 (UTC) Subject: Re: [PATCH 1/1] New driver: rtl8xxxu (mac80211) To: Jes.Sorensen@redhat.com, kvalo@codeaurora.org References: <1444869891-21174-1-git-send-email-Jes.Sorensen@redhat.com> <1444869891-21174-2-git-send-email-Jes.Sorensen@redhat.com> Cc: linux-wireless@vger.kernel.org, Larry.Finger@lwfinger.net From: Bruno Randolf X-Enigmail-Draft-Status: N1110 Message-ID: <561F978F.8080408@einfach.org> Date: Thu, 15 Oct 2015 13:09:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1444869891-21174-2-git-send-email-Jes.Sorensen@redhat.com> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (postler.einfach.org [0.0.0.0]); Thu, 15 Oct 2015 12:09:53 +0000 (UTC) X-Virus-Scanned: clamav-milter 0.98.7 at bced1da0f74a X-Virus-Status: Clean Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Jens, I just tested your driver with a RTL8188CU rev A ("Vilros" ID 0bda:8176) and it works well so far! I'm missing monitor mode however. Do you see any chance to add that? Your patch seems to be correct, but in your own git, branch 'rtl8723au-mac80211' you seem to be missing the below part: On 10/15/2015 01:44 AM, Jes.Sorensen@redhat.com wrote: > --- a/drivers/net/wireless/realtek/Makefile > +++ b/drivers/net/wireless/realtek/Makefile > @@ -5,4 +5,5 @@ > obj-$(CONFIG_RTL8180) += rtl818x/ > obj-$(CONFIG_RTL8187) += rtl818x/ > obj-$(CONFIG_RTLWIFI) += rtlwifi/ > +obj-$(CONFIG_RTL8XXXU) += rtl8xxxu/ And it has that leftover in drivers/net/wireless/Makefile: obj-$(CONFIG_RTL8XXXU) += rtl8xxxu.o I had to add the following change to my local tree in order to be able to build: Greetings, bruno --- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/wireless/Makefile b/drivers/net/wireless/Makefile index bc44950..740fdd3 100644 --- a/drivers/net/wireless/Makefile +++ b/drivers/net/wireless/Makefile @@ -37,8 +37,6 @@ obj-$(CONFIG_LIBERTAS_THINFIRM) += libertas_tf/ obj-$(CONFIG_ADM8211) += adm8211.o -obj-$(CONFIG_RTL8XXXU) += rtl8xxxu.o - obj-$(CONFIG_MWL8K) += mwl8k.o obj-$(CONFIG_IWLWIFI) += iwlwifi/ diff --git a/drivers/net/wireless/realtek/Makefile b/drivers/net/wireless/realtek/Makefile index 3489b98..9c78deb 100644 --- a/drivers/net/wireless/realtek/Makefile +++ b/drivers/net/wireless/realtek/Makefile @@ -5,4 +5,5 @@ obj-$(CONFIG_RTL8180) += rtl818x/ obj-$(CONFIG_RTL8187) += rtl818x/ obj-$(CONFIG_RTLWIFI) += rtlwifi/ +obj-$(CONFIG_RTL8XXXU) += rtl8xxxu/