From patchwork Thu Nov 24 01:26:06 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kirtika Ruchandani X-Patchwork-Id: 9444659 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EBC72600BA for ; Thu, 24 Nov 2016 01:26:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E2A0C2621B for ; Thu, 24 Nov 2016 01:26:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D33FC26223; Thu, 24 Nov 2016 01:26:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4AB302621B for ; Thu, 24 Nov 2016 01:26:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936266AbcKXB0c (ORCPT ); Wed, 23 Nov 2016 20:26:32 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:33854 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934630AbcKXB0b (ORCPT ); Wed, 23 Nov 2016 20:26:31 -0500 Received: by mail-pg0-f67.google.com with SMTP id e9so2201532pgc.1 for ; Wed, 23 Nov 2016 17:26:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=PSlxB/YKSeAt9dJNce8maocDNeDPSWJQuEsYiICp2v8=; b=HM/bYPuhTCazUQSolipigUSfC7qgxrSMN1sMNTvLuUCfT7JW52lt8WbYaRtIVqu1Co kQJWDgDa9dSHFlpkWAJVR0U4D53U2Wum/+gQLGmsP652fqMHVS1Th/MXxNbpECwjFikG 2oReVdq5DdhGrBdvxFLNNXqbDBcGyA3ZzR/j4FoD7kti3xWXs+JwSQDQxy+7vkmpHfK1 FiriDi0lxuF0AbBmxGMfN6nSkERkklojnB5CqQlDosHkA31CaD/intkqaK0IXe4vqIcT nHpo0W0mexU2JnSFopHOLWRk4LEiJJ2YD8LJkO53S85osBcA9ss7ck1EVwyYFwYSSdc9 lgqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=PSlxB/YKSeAt9dJNce8maocDNeDPSWJQuEsYiICp2v8=; b=VoUQxGlT4ybNSjEH6sBSHk7oM9vajGdqeyJiuCmRS2revQCfDDZi99o9OEDrIR4vjS PxCNAHF9DAj+4prlRCkRkGUJ2zsVw7mUaj9Sv53ROkVXgXPuSnZSiUkHKJBNYHrQbTDN IH4x9RZoykLVL1uLuFtjGaEDaoExn0BJIpJz5Mldg1Ac0Z4+AX+BOVBaRziz2pVyHV8o eddxwnMlF6n2hxJTaUUehwpXHk65f7IxM6iKEIjYb79p8QiJ8HGiM6JQP0pFDyDBvSl+ y6OadDJSuBesO/Lj1TWrxYNkpsNXYsWWJkx5uGpi0ZL6ZZr1pVnUroYKp3JX5ldyadZk weww== X-Gm-Message-State: AKaTC00bZBt71ctkZwoW6Yav6lc2KVRK+HNh9ghVNmVXbjj/viKvH/5EiULoPcjFKVMvoA== X-Received: by 10.99.137.66 with SMTP id v63mr10158450pgd.117.1479950791132; Wed, 23 Nov 2016 17:26:31 -0800 (PST) Received: from google.com ([2620:0:1000:1301:7c:c779:de59:30f3]) by smtp.gmail.com with ESMTPSA id l11sm55400441pfb.28.2016.11.23.17.26.29 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 23 Nov 2016 17:26:30 -0800 (PST) From: Kirtika Ruchandani X-Google-Original-From: Kirtika Ruchandani Date: Wed, 23 Nov 2016 17:26:06 -0800 To: Amitkumar Karwar Cc: Arnd Bergmann , Kalle Valo , linux-wireless@vger.kernel.org, Nishant Sarmukadam , Zhaoyang Liu , Bing Zhao , Xinming Hu , Avinash Patil Subject: [PATCH v2 5/7] mwifiex: Remove unused 'pm_flag' variable Message-ID: <56d02b0bc8845cf71da212aa006ee15eb95023c9.1479950323.git.kirtika@google.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP mwifiex_sdio_resume() intializes pm_flag, just like mwifiex_sdio_suspend(), but does not use it. Compiling with W=1 gives the following warning, fix it. mwifiex/sdio.c: In function ‘mwifiex_sdio_resume’: mwifiex/sdio.c:234:16: warning: variable ‘pm_flag’ set but not used [-Wunused-but-set-variable] sdio_get_host_pm_caps() is just an acessor, so the call to it is safe to remove. The unused variable seems to be present since 5e6e3a92b9a4 which introduced mwifiex_sdio_resume(). Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver") Cc: Bing Zhao Cc: Amitkumar Karwar Signed-off-by: Kirtika Ruchandani --- drivers/net/wireless/marvell/mwifiex/sdio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c index 0d00db5..6c9f16e 100644 --- a/drivers/net/wireless/marvell/mwifiex/sdio.c +++ b/drivers/net/wireless/marvell/mwifiex/sdio.c @@ -186,9 +186,7 @@ static int mwifiex_sdio_resume(struct device *dev) struct sdio_func *func = dev_to_sdio_func(dev); struct sdio_mmc_card *card; struct mwifiex_adapter *adapter; - mmc_pm_flag_t pm_flag = 0; - pm_flag = sdio_get_host_pm_caps(func); card = sdio_get_drvdata(func); if (!card || !card->adapter) { dev_err(dev, "resume: invalid card or adapter\n");