From patchwork Mon Apr 11 19:04:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oleksij Rempel X-Patchwork-Id: 8805261 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9E1B9C0553 for ; Mon, 11 Apr 2016 19:05:11 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id ECA2D2021F for ; Mon, 11 Apr 2016 19:05:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16A4E20148 for ; Mon, 11 Apr 2016 19:05:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754479AbcDKTFH (ORCPT ); Mon, 11 Apr 2016 15:05:07 -0400 Received: from mout.gmx.net ([212.227.17.20]:50425 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754201AbcDKTFF (ORCPT ); Mon, 11 Apr 2016 15:05:05 -0400 Received: from [192.168.2.104] ([93.237.216.109]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0LtlG5-1bps1A3moX-011DpN; Mon, 11 Apr 2016 21:05:01 +0200 Subject: Re: [PATCH] Revert regression in ath9k on AR9281 To: Gustav Frederiksen , Julian Calaby References: <998e52a27823047910627da08e917c06@openmailbox.org> <6567cc33c0ca681364c6510a7797c459@openmailbox.org> Cc: linux-wireless From: Oleksij Rempel Message-ID: <570BF557.40705@rempel-privat.de> Date: Mon, 11 Apr 2016 21:04:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <6567cc33c0ca681364c6510a7797c459@openmailbox.org> X-Provags-ID: V03:K0:FJGvLBLPt+aeUB3qbG4p0vcdSEwcijkFW92YPTkwQ/I3B67E0Fn nDZvoFrhXj1ICOyCzg3nMc+NJsuc/pEBo3H9R7NdkNwOaACaSaLPJrH9UIPzdKnOGU+HLz+ n74KrOU00amUOQKB37lNSLTm0JQp4kTY2a4jQUdHCz8emxqtcsK37zXs2F+M5VML/aNEKwu Kf+owwK0n3JYnVgzBNLeg== X-UI-Out-Filterresults: notjunk:1; V01:K0:suPQ09WQkAE=:lqCSkXQ5uxsfs0qFU0UVFS HYOYkDU/kxERS7VqRV+i/NUIgmlRSY8pOQxBIQ8pTHpYBImkeFh7P2uO+zqAH2enfkNaPfGeM noMX3vW1ljIqlSap4fl9WVrW/KqHcO2j1hK/tIidH2vncs2f7c1psYyDdyyYcoiEc0bNRar5/ w9ZVYE/bwHmYbOGqbTugXfdPb/+gnkPBJcUydeZl+gQLJjJgA5PBSiawhfvUUJmtLdvTxPTct 0P83MBWSr6EjFseeJEMvwMPtZIE6QgA5OhiiWNUu4AJKVNvL4jY8e+om5BuHWjXpxGV5ZhHg4 BU9iYEBG+D8ApEVL9jdGOKGDftNNfvnKhi6d+9Edfh90iNPovvEQRyVHAfNErt+E4OsTVXC2+ QaYb+FhZuGVefhF4F+UJTVirNgiXJwhdEN8+5jjxiA7uJxn7zdiPwh30bI6X2+eZPS/bfKPVT 1M18Ht5vMQJvyG5FaRLRP/u8qIGhQ/+3UieVHVDv7vAmC6Jp2qEij8HK0RPpOn7WtzOc4IfxH 1amV8+h9A3U304FtF1AQiHWf/rm/ZsRoRk6S7NGY5RobCsi+s7hQ3jzGGeAiQs28ioK9eM1dT Vo62OnZNMb7HBZet/mwdjwhyP8lf0QL57xXOLwptKfpWtJ4UhHXDEe57CicxhoulDDooZVQgr YLiHxYHkzEJnVC20FV9s2LgOJYI3BvIhUnSFcGEt3d2e60j8xqp3hDsU1QjPmzi5J0RqSp4JK lTn0bVef0P61yDOdA27eiUO3PV/3bLQw3TdcuKuLDWDn/EobxBIjyeYWxls= Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_TVD_MIME_EPI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Gustav, thank you for your work. Can you please test attached patch. Am 11.04.2016 um 04:28 schrieb Gustav Frederiksen: > Hi, > thank you for taking the time to answer my previous email and for > providing those useful tips. .... diff --git a/drivers/net/wireless/ath/ath9k/ar5008_phy.c b/drivers/net/wireless/ath/ath9k/ar5008_phy.c index 8f87930..1b271b9 100644 --- a/drivers/net/wireless/ath/ath9k/ar5008_phy.c +++ b/drivers/net/wireless/ath/ath9k/ar5008_phy.c @@ -274,6 +274,9 @@ void ar5008_hw_cmn_spur_mitigate(struct ath_hw *ah, }; static const int inc[4] = { 0, 100, 0, 0 }; + memset(&mask_m, 0, sizeof(int8_t) * 123); + memset(&mask_p, 0, sizeof(int8_t) * 123); + cur_bin = -6000; upper = bin + 100; lower = bin - 100; @@ -424,14 +427,9 @@ static void ar5008_hw_spur_mitigate(struct ath_hw *ah, int tmp, new; int i; - int8_t mask_m[123]; - int8_t mask_p[123]; int cur_bb_spur; bool is2GHz = IS_CHAN_2GHZ(chan); - memset(&mask_m, 0, sizeof(int8_t) * 123); - memset(&mask_p, 0, sizeof(int8_t) * 123); - for (i = 0; i < AR_EEPROM_MODAL_SPURS; i++) { cur_bb_spur = ah->eep_ops->get_spur_channel(ah, i, is2GHz); if (AR_NO_SPUR == cur_bb_spur) diff --git a/drivers/net/wireless/ath/ath9k/ar9002_phy.c b/drivers/net/wireless/ath/ath9k/ar9002_phy.c index db66245..53d7445 100644 --- a/drivers/net/wireless/ath/ath9k/ar9002_phy.c +++ b/drivers/net/wireless/ath/ath9k/ar9002_phy.c @@ -178,14 +178,9 @@ static void ar9002_hw_spur_mitigate(struct ath_hw *ah, int i; struct chan_centers centers; - int8_t mask_m[123]; - int8_t mask_p[123]; int cur_bb_spur; bool is2GHz = IS_CHAN_2GHZ(chan); - memset(&mask_m, 0, sizeof(int8_t) * 123); - memset(&mask_p, 0, sizeof(int8_t) * 123); - ath9k_hw_get_channel_centers(ah, chan, ¢ers); freq = centers.synth_center;