From patchwork Fri Jun 10 18:43:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Greear X-Patchwork-Id: 9170275 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 47819607D9 for ; Fri, 10 Jun 2016 18:43:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 38D5F28319 for ; Fri, 10 Jun 2016 18:43:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2C55028342; Fri, 10 Jun 2016 18:43:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9908828319 for ; Fri, 10 Jun 2016 18:43:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932099AbcFJSni (ORCPT ); Fri, 10 Jun 2016 14:43:38 -0400 Received: from mail2.candelatech.com ([208.74.158.173]:39483 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752101AbcFJSnh (ORCPT ); Fri, 10 Jun 2016 14:43:37 -0400 Received: from [192.168.100.149] (firewall.candelatech.com [50.251.239.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail2.candelatech.com (Postfix) with ESMTPSA id DA84140A539; Fri, 10 Jun 2016 11:43:36 -0700 (PDT) Subject: Re: [PATCH-v2 1/2] mac80211: Take bitrates into account when building IEs. To: Johannes Berg , linux-wireless@vger.kernel.org References: <1445361858-24976-1-git-send-email-greearb@candelatech.com> <1453807009.2759.23.camel@sipsolutions.net> <56A78E8F.1080505@candelatech.com> <1454576521.2564.6.camel@sipsolutions.net> <56B38FD1.40902@candelatech.com> <1455827536.2084.35.camel@sipsolutions.net> <56C62C4E.7020600@candelatech.com> <1455828330.2084.38.camel@sipsolutions.net> <56C630B7.7020604@candelatech.com> <1455830078.2084.47.camel@sipsolutions.net> <56C63D8B.9020900@candelatech.com> <1456225589.2041.24.camel@sipsolutions.net> <56E1B556.4080004@candelatech.com> <1458051349.2871.19.camel@sipsolutions.net> <56E833FE.1080904@candelatech.com> <1458073224.2871.22.camel@sipsolutions.net> From: Ben Greear Organization: Candela Technologies Message-ID: <575B0A58.8070408@candelatech.com> Date: Fri, 10 Jun 2016 11:43:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1458073224.2871.22.camel@sipsolutions.net> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 03/15/2016 01:20 PM, Johannes Berg wrote: > On Tue, 2016-03-15 at 09:10 -0700, Ben Greear wrote: >> >> The logic I wrote is basically exactly this. It uses the configured >> rates to specify which of the hardware's rates are allowed and >> disabled. >> > > I understand that. I just take issue with the fact that we have to > sprinkle "magic pixie dust" (in form of the override function calls) > everywhere throughout the code. > > johannes > So, I never could think up a way to make this more acceptable and meet my own goals. Any chance I could get just the netlink enum in place, even if it is called something like 'api_placeholder_x'? Otherwise, it is about impossible for me to keep any sane forward/back compatibility with my hostap patches.... Or, is there some other way to handle out-of-tree netlink stuff better? Thanks, Ben diff --git a/include/uapi/linux/nl80211.h b/include/uapi/linux/nl80211.h index c0ab6b0..4573f87 100644 --- a/include/uapi/linux/nl80211.h +++ b/include/uapi/linux/nl80211.h @@ -2130,6 +2130,8 @@ enum nl80211_attrs { NL80211_ATTR_REG_INDOOR, + NL80211_ATTR_TX_ADVERT_RATEMASK, + /* add attributes here, update the policy in nl80211.c */ __NL80211_ATTR_AFTER_LAST,