From patchwork Sun May 13 09:16:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: kabe@sra-tohoku.co.jp X-Patchwork-Id: 10396133 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7381F600D0 for ; Sun, 13 May 2018 09:17:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 613BC29069 for ; Sun, 13 May 2018 09:17:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 543982906D; Sun, 13 May 2018 09:17:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5DDEE29069 for ; Sun, 13 May 2018 09:16:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751406AbeEMJQ4 (ORCPT ); Sun, 13 May 2018 05:16:56 -0400 Received: from mail-pl0-f67.google.com ([209.85.160.67]:38365 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751052AbeEMJQz (ORCPT ); Sun, 13 May 2018 05:16:55 -0400 Received: by mail-pl0-f67.google.com with SMTP id c11-v6so5677443plr.5 for ; Sun, 13 May 2018 02:16:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sra-tohoku-co-jp.20150623.gappssmtp.com; s=20150623; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-transfer-encoding; bh=Y3zSHgnb8HO6UlUesMRH3NBnOwwPja6cvmeQhF8dv54=; b=DSUupg2a4MvuZQqFG6tfkR3OB2ZCWvFcPT0O3jMhF02+JYH1RbR9wKgDmASqzlfkfu c/5WEfgFCnkNVfOb3seD4VHTKanv0ovoyAAvM4S/xVoJaWBkOv3Pahvd6qVCbdzff9SP KXv7L7Kwkwf8SfcN8UPFKXP/sFXY2KQN2XUR747hW9M/pIEr9jkjFomGub7RoDCQfU8I 7TmYT0m7isQTyVQD0RSfGxaAhPZtDLWwzI5PSASr/Jt59+32/nBr2TQPaaC3iQztvwd8 p6e/U2PKVZkBbe01ifR8LEE7KZFLiHXmkClXndHy/sxWvSOucb48oduiO770WMDvsMeA lnYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-transfer-encoding; bh=Y3zSHgnb8HO6UlUesMRH3NBnOwwPja6cvmeQhF8dv54=; b=L9MPxkSTaArSxtgYDGvGeSFlFSSbx5KZEA21JNKcjHKFy5gtSMI3DSvfWXK64g81wT 0z7l24cpW1otpbgVznSDGOoYHDXDH56S6bTogc6cTCZT6vxbRbFqqy5v2roH+DSVh+S0 B2qwsGg2Is+4l76F1Le4GnmR26aAiha7iHgY8JudWk4gtRWu+J4BeFtQbVmGZp09s7E/ /fREDFfPOyv2gCJ0VzjMO0MkMd2IZaqsJXbDNQnXcvrxpPz2K6RpQHRQkC98uf0whIvc I0S8uKILp4lUWd0NUN3/XKcFFI/IS6nBSWieKzF+1FMmxtLxzfXbbbozIqqWr8E/yfk9 SAmw== X-Gm-Message-State: ALKqPwdyfTso6IT2AILp34NJ6w+z495yDok/+zhnACXceQ13ozftJv2T D13+Jgh589WvSyQV0ezSR6UAz9oY X-Google-Smtp-Source: AB8JxZpChprOKpL6nX6x+VkCFv+TSiHqQR2IKTOH79n7eTu6IJGK+mcqjKk4QWd/98ilir3dhANNeg== X-Received: by 2002:a17:902:481:: with SMTP id e1-v6mr5398918ple.377.1526203014599; Sun, 13 May 2018 02:16:54 -0700 (PDT) Received: from [10.5.0.101] (w0109-49-135-20-237.uqwimax.jp. [49.135.20.237]) by smtp.googlemail.com with ESMTPSA id e126-v6sm13432445pfh.5.2018.05.13.02.16.51 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 13 May 2018 02:16:54 -0700 (PDT) Message-ID: <5AF80278.9000501@sra-tohoku.co.jp> Date: Sun, 13 May 2018 18:16:40 +0900 From: Taketo Kabe User-Agent: Thunderbird 2.0.0.24 (Windows/20100228) MIME-Version: 1.0 To: linux-wireless@vger.kernel.org CC: kabe@sra-tohoku.co.jp, b43-dev@lists.infradead.org Subject: [PATCH v3] b43: fix transmit failure when VT is switched References: <5AF41F55.4060606@sra-tohoku.co.jp> <20180512085053.8637A60618@smtp.codeaurora.org> In-Reply-To: <20180512085053.8637A60618@smtp.codeaurora.org> Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Taketo Kabe Setup: Using BCM4306 rev.03 chip based CardBus wireless card. IRQ is shared with yenta (cardbus bridge) and i915 (display) driver. For firmware, installed latest but dated openfwwf 5.2 (http://netweb.ing.unibs.it/~openfwwf/) How-to-reproduce: Do "ssh ", then "ls -lR /" to generate traffic, then repeatedly switch VTs by Alt-F1<>Alt-F2. Eventually (within a minute) the card stops working. You can receive traffic but no transmission. For unknown reason it doesn't occur when just generating traffic by "ssh ls -lR /". With CONFIG_B43_DEBUG=y kernel config, when it stops, the debug message shows kernel: b43-phy1 debug: Out of order TX status report on DMA ring 1. Expected 148, but got 180 The slot offset I observed so far was always 32. When err_out2 is not set to make error messages successive, the debug output will be like this: kernel: b43-phy1 debug: Out of order TX status report on DMA ring 1. Expected 116, but got 148 kernel: b43-phy1 debug: Out of order TX status report on DMA ring 1. Expected 116, but got 150 kernel: b43-phy1 debug: Out of order TX status report on DMA ring 1. Expected 116, but got 120 kernel: b43-phy1 debug: Out of order TX status report on DMA ring 1. Expected 116, but got 152 kernel: b43-phy1 debug: Out of order TX status report on DMA ring 1. Expected 116, but got 122 kernel: b43-phy1 debug: Out of order TX status report on DMA ring 1. Expected 116, but got 154 kernel: b43-phy1 debug: Out of order TX status report on DMA ring 1. Expected 116, but got 124 kernel: b43-phy1 debug: Out of order TX status report on DMA ring 1. Expected 116, but got 156 kernel: b43-phy1 debug: Out of order TX status report on DMA ring 1. Expected 116, but got 126 The TX ring alternates between 2 sequences; the ring seems to be completely confused. Controller restart is needed. Workaround(1): This problem doesn't occur when using propriatory firmware you will extract by b43-fwcutter, so it may be a bug in openfwwf firmware, as the comment in the b43_dma_handle_txstatus() suggests. I wasn't able to find a bug in the terse openfwwf code though. Workaround(2): Using "pio=1" option to not use DMA makes this problem to not occur. Description of the patch: This patch will forcibly reset the controller to make it work again. Very kludgy and doesn't look right, but the traffic will continue to flow. Signed-off-by: Taketo Kabe Reviewed-by: Michael Buesch --- drivers/net/wireless/broadcom/b43/dma.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) Changes since last edition: - Remove now unused err_out2 variable. - Regenerated the patch using "git format-patch" against wireless-drivers-next.git . diff --git a/drivers/net/wireless/broadcom/b43/dma.c b/drivers/net/wireless/broadcom/b43/dma.c index 6837064..6b0e1ec 100644 --- a/drivers/net/wireless/broadcom/b43/dma.c +++ b/drivers/net/wireless/broadcom/b43/dma.c @@ -1484,7 +1484,7 @@ void b43_dma_handle_txstatus(struct b43_wldev *dev, int slot, firstused; bool frame_succeed; int skip; - static u8 err_out1, err_out2; + static u8 err_out1; ring = parse_cookie(dev, status->cookie, &slot); if (unlikely(!ring)) @@ -1518,13 +1518,13 @@ void b43_dma_handle_txstatus(struct b43_wldev *dev, } } else { /* More than a single header/data pair were missed. - * Report this error once. + * Report this error, and reset the controller to + * revive operation. */ - if (!err_out2) - b43dbg(dev->wl, - "Out of order TX status report on DMA ring %d. Expected %d, but got %d\n", - ring->index, firstused, slot); - err_out2 = 1; + b43dbg(dev->wl, + "Out of order TX status report on DMA ring %d. Expected %d, but got %d\n", + ring->index, firstused, slot); + b43_controller_restart(dev, "Out of order TX"); return; } }