| Message ID | 877g8fd32c.fsf@kamboji.qca.qualcomm.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 28 February 2014 10:00, Kalle Valo <kvalo@qca.qualcomm.com> wrote: > Michal Kazior <michal.kazior@tieto.com> writes: > >> HTT Rx endpoint processes both frame rx >> indications and frame tx completion indications. >> >> Those completions typically come in batches and >> may be mixed so it makes sense to defer processing >> hoping to get a bunch of them and take advantage >> of hot caches. >> >> Signed-off-by: Michal Kazior <michal.kazior@tieto.com> > > [...] > >> +void ath10k_htt_txrx_compl_task(unsigned long ptr) >> +{ >> + struct ath10k_htt *htt = (struct ath10k_htt *)ptr; >> + struct htt_resp *resp; >> + struct sk_buff *skb; > > I think this can be a static function. Is it ok if I change this patch > with the diff below? I don't really mind. Micha? -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- a/drivers/net/wireless/ath/ath10k/htt.h +++ b/drivers/net/wireless/ath/ath10k/htt.h @@ -1360,6 +1360,5 @@ int ath10k_htt_tx_alloc_msdu_id(struct ath10k_htt *htt); void ath10k_htt_tx_free_msdu_id(struct ath10k_htt *htt, u16 msdu_id); int ath10k_htt_mgmt_tx(struct ath10k_htt *htt, struct sk_buff *); int ath10k_htt_tx(struct ath10k_htt *htt, struct sk_buff *); -void ath10k_htt_txrx_compl_task(unsigned long ptr); #endif diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c index e362358240e8..3a02e654d871 100644 --- a/drivers/net/wireless/ath/ath10k/htt_rx.c +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c @@ -43,7 +43,7 @@ static int ath10k_htt_rx_get_csum_state(struct sk_buff *skb); - +static void ath10k_htt_txrx_compl_task(unsigned long ptr); static int ath10k_htt_rx_ring_size(struct ath10k_htt *htt) { @@ -1347,7 +1347,7 @@ void ath10k_htt_t2h_msg_handler(struct ath10k *ar, struct sk_buff *skb) dev_kfree_skb_any(skb); } -void ath10k_htt_txrx_compl_task(unsigned long ptr) +static void ath10k_htt_txrx_compl_task(unsigned long ptr) { struct ath10k_htt *htt = (struct ath10k_htt *)ptr; struct htt_resp *resp;