From patchwork Wed Feb 4 08:33:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 5775341 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 75DD2BF440 for ; Wed, 4 Feb 2015 08:33:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9F19E202DD for ; Wed, 4 Feb 2015 08:33:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69AA62021A for ; Wed, 4 Feb 2015 08:33:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932413AbbBDIdt (ORCPT ); Wed, 4 Feb 2015 03:33:49 -0500 Received: from wolverine02.qualcomm.com ([199.106.114.251]:63868 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754253AbbBDIdt (ORCPT ); Wed, 4 Feb 2015 03:33:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qca.qualcomm.com; i=@qca.qualcomm.com; q=dns/txt; s=qcdkim; t=1423038830; x=1454574830; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=MaZm+cNvjiQrNQS8gkaxtEVdN2fN7zZ2Xsz1BqY3PyA=; b=r/yX2nIH3eLKRkroeuUdGVYk5RkM+NnnRaXHTyZ/ysi8C52DyoxY/zW9 Cm1TH4KPqVZ8lmsVgr/90TtmdSA95zoBlIYUK+Ta0EHCIF+zT1TuXa3Ky B6ywNZyBMQYC0OA1pvx++g3fo4GWN+/GV2io/JJzL7awF83+TMGbpA5Lm E=; X-IronPort-AV: E=McAfee;i="5600,1067,7701"; a="193732757" Received: from ironmsg03-lv.qualcomm.com ([10.47.202.181]) by wolverine02.qualcomm.com with ESMTP; 04 Feb 2015 00:33:49 -0800 X-IronPort-AV: E=Sophos;i="5.09,517,1418112000"; d="scan'208";a="25773537" Received: from nalasexr01g.na.qualcomm.com ([10.49.56.53]) by ironmsg03-lv.qualcomm.com with ESMTP/TLS/RC4-SHA; 04 Feb 2015 00:33:48 -0800 Received: from potku.adurom.net (10.80.80.8) by NALASEXR01G.na.qualcomm.com (10.49.56.53) with Microsoft SMTP Server (TLS) id 15.0.995.29; Wed, 4 Feb 2015 00:33:45 -0800 From: Kalle Valo To: CC: , Subject: Re: [PATCH 3/8] ath10k: fix spelling mistakes and add details to mac logging. References: <1421087564-10384-1-git-send-email-greearb@candelatech.com> <1421087564-10384-3-git-send-email-greearb@candelatech.com> Date: Wed, 4 Feb 2015 10:33:37 +0200 In-Reply-To: <1421087564-10384-3-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Mon, 12 Jan 2015 10:32:39 -0800") Message-ID: <87d25qulcu.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: NASANEXM01D.na.qualcomm.com (10.85.0.84) To NALASEXR01G.na.qualcomm.com (10.49.56.53) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP greearb@candelatech.com writes: > From: Ben Greear > > A bit of general cleanup to make debug messages more useful. > > Signed-off-by: Ben Greear [...] > - ath10k_warn(ar, "failed to synchronise monitor vdev %i: %d\n", > + ath10k_warn(ar, "failed to synchronize monitor vdev %i: %d (stop)\n", Hehe, spelling fixes? You know not everyone speak "American" ;) Anyway, I changed the patch in pending branch to follow the style with other similar warning messages: diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 40c666615993..f4ab3d0a5fa0 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -608,7 +608,7 @@ static int ath10k_monitor_vdev_start(struct ath10k *ar, int vdev_id) ret = ath10k_vdev_setup_sync(ar); if (ret) { - ath10k_warn(ar, "failed to synchronize setup for monitor vdev %i: %d (start)\n", + ath10k_warn(ar, "failed to synchronize setup for monitor vdev %i start: %d\n", vdev_id, ret); return ret; } @@ -655,7 +655,7 @@ static int ath10k_monitor_vdev_stop(struct ath10k *ar) ret = ath10k_vdev_setup_sync(ar); if (ret) - ath10k_warn(ar, "failed to synchronize monitor vdev %i: %d (stop)\n", + ath10k_warn(ar, "failed to synchronize monitor vdev %i stop: %d\n", ar->monitor_vdev_id, ret); ath10k_dbg(ar, ATH10K_DBG_MAC, "mac monitor vdev %i stopped\n", @@ -924,8 +924,9 @@ static int ath10k_vdev_start_restart(struct ath10k_vif *arvif, bool restart) ret = ath10k_vdev_setup_sync(ar); if (ret) { - ath10k_warn(ar, "failed to synchronize setup for vdev %i: %d (restart %d)\n", - arg.vdev_id, ret, restart); + ath10k_warn(ar, + "failed to synchronize setup for vdev %i restart %d: %d\n", + arg.vdev_id, restart, ret); return ret; } @@ -963,7 +964,7 @@ static int ath10k_vdev_stop(struct ath10k_vif *arvif) ret = ath10k_vdev_setup_sync(ar); if (ret) { - ath10k_warn(ar, "failed to synchronize setup for vdev %i: %d (stop)\n", + ath10k_warn(ar, "failed to synchronize setup for vdev %i stop: %d\n", arvif->vdev_id, ret); return ret; }