From patchwork Mon Dec 1 14:19:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 5412741 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1EA63BEEA8 for ; Mon, 1 Dec 2014 14:19:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 41BA1202A1 for ; Mon, 1 Dec 2014 14:19:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE17E201BC for ; Mon, 1 Dec 2014 14:19:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753625AbaLAOTh (ORCPT ); Mon, 1 Dec 2014 09:19:37 -0500 Received: from wolverine01.qualcomm.com ([199.106.114.254]:64161 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753458AbaLAOTg (ORCPT ); Mon, 1 Dec 2014 09:19:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qca.qualcomm.com; i=@qca.qualcomm.com; q=dns/txt; s=qcdkim; t=1417443576; x=1448979576; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=26BDnBFY5m99UWelZUfBTTtnynJr49x1V9jxOqhQzR0=; b=E0NCQ4lPmcrKN1BQMZfU00d/EXjjNiANQ7bd+COUMQ6FOVLq8gNtJcNJ 12TF3QU00lJSwOdYLpJhdFCF1IXevgP8yexp1v+u8TZgP6ONgr//9dz0O 8twmgia1vYUU6YKoTx2jM30XEYSy4VIvK6qWRRUrJSgLms31DWORwBsgm I=; X-IronPort-AV: E=McAfee;i="5600,1067,7638"; a="90115551" Received: from ironmsg02-lv.qualcomm.com ([10.47.202.183]) by wolverine01.qualcomm.com with ESMTP; 01 Dec 2014 06:19:36 -0800 X-IronPort-AV: E=Sophos;i="5.07,494,1413270000"; d="scan'208";a="31136458" Received: from nasanexm01g.na.qualcomm.com ([10.85.0.33]) by ironmsg02-lv.qualcomm.com with ESMTP/TLS/RC4-SHA; 01 Dec 2014 06:19:35 -0800 Received: from potku.adurom.net.qca.qualcomm.com (10.80.80.8) by NASANEXM01G.na.qualcomm.com (10.85.0.33) with Microsoft SMTP Server (TLS) id 15.0.913.22; Mon, 1 Dec 2014 06:19:33 -0800 From: Kalle Valo To: Michal Kazior CC: "ath10k@lists.infradead.org" , linux-wireless Subject: Re: [PATCH v2 7/7] ath10k: implement wmi-tlv backend References: <1417079481-22255-1-git-send-email-michal.kazior@tieto.com> <1417079481-22255-8-git-send-email-michal.kazior@tieto.com> Date: Mon, 1 Dec 2014 16:19:23 +0200 In-Reply-To: (Michal Kazior's message of "Fri, 28 Nov 2014 15:39:01 +0100") Message-ID: <87wq6bpi50.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: NASANEXM01D.na.qualcomm.com (10.85.0.84) To NASANEXM01G.na.qualcomm.com (10.85.0.33) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Michal Kazior writes: > On 27 November 2014 at 10:11, Michal Kazior wrote: >> Latest main firmware branch introduced a new WMI >> ABI called wmi-tlv. It is not a tlv strictly >> speaking but something that resembles it because >> it is ordered and may have duplicate id entries. >> >> This prepares ath10k to support new hw. >> >> Signed-off-by: Michal Kazior > [...] >> @@ -215,6 +254,42 @@ static inline char *wmi_service_name(int service_id) >> SVCSTR(WMI_SERVICE_BURST); >> SVCSTR(WMI_SERVICE_SMART_ANTENNA_SW_SUPPORT); >> SVCSTR(WMI_SERVICE_SMART_ANTENNA_HW_SUPPORT); >> + SVCSTR(WMI_SERVICE_ROAM_SCAN_OFFLOAD); >> + SVCSTR(WMI_SERVICE_AP_PS_DETECT_OUT_OF_SYNC); >> + SVCSTR(WMI_SERVICE_EARLY_RX); > [...] >> + SVCSTR(WMI_SERVICE_RX_FULL_REORDER); >> + SVCSTR(WMI_SERVICE_DHCP_OFFLOAD); > > I've added 3 new service enums in v2: > WMI_SERVICE_STA_RX_IPA_OFFLOAD_SUPPORT, WMI_SERVICE_MDNS_OFFLOAD, > WMI_SERVICE_SAP_AUTH_OFFLOAD but apparently I forgot to add SVCSTR() > for that.. I added those in my not-yet-submitted v3: diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h index a31a3028a847..7d091a74d3f3 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.h +++ b/drivers/net/wireless/ath/ath10k/wmi.h @@ -290,6 +290,9 @@ static inline char *wmi_service_name(int service_id) SVCSTR(WMI_SERVICE_ROAM_HO_OFFLOAD); SVCSTR(WMI_SERVICE_RX_FULL_REORDER); SVCSTR(WMI_SERVICE_DHCP_OFFLOAD); + SVCSTR(WMI_SERVICE_STA_RX_IPA_OFFLOAD_SUPPORT); + SVCSTR(WMI_SERVICE_MDNS_OFFLOAD); + SVCSTR(WMI_SERVICE_SAP_AUTH_OFFLOAD); default: return NULL; }