| Message ID | 9633ea7d9b0cb2f997d784df86ba92e67659f29b.1602589096.git.mchehab+huawei@kernel.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | None | expand |
On 2020-10-13 04:54, Mauro Carvalho Chehab wrote: > Changeset df78a0c0b67d ("nl80211: S1G band and channel definitions") > added a new parameter, but didn't add the corresponding kernel-doc > markup, as repoted when doing "make htmldocs": > > ./include/net/cfg80211.h:471: warning: Function parameter or member > 's1g_cap' not described in 'ieee80211_supported_band' > > Add a documentation for it. Sorry about that. Patch looks good. > Fixes: df78a0c0b67d ("nl80211: S1G band and channel definitions") > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> Signed-off-by: Thomas Pedersen <thomas@adapt-ip.com>
Thanks Mauro. On Tue, 2020-10-13 at 13:54 +0200, Mauro Carvalho Chehab wrote: > Changeset df78a0c0b67d ("nl80211: S1G band and channel definitions") > added a new parameter, but didn't add the corresponding kernel-doc > markup, as repoted when doing "make htmldocs": > > ./include/net/cfg80211.h:471: warning: Function parameter or member 's1g_cap' not described in 'ieee80211_supported_band' > > Add a documentation for it. Should I take this through my tree, or is that part of a larger set that'll go somewhere else? johannes
Em Tue, 13 Oct 2020 20:47:47 +0200 Johannes Berg <johannes@sipsolutions.net> escreveu: > Thanks Mauro. > > > On Tue, 2020-10-13 at 13:54 +0200, Mauro Carvalho Chehab wrote: > > Changeset df78a0c0b67d ("nl80211: S1G band and channel definitions") > > added a new parameter, but didn't add the corresponding kernel-doc > > markup, as repoted when doing "make htmldocs": > > > > ./include/net/cfg80211.h:471: warning: Function parameter or member 's1g_cap' not described in 'ieee80211_supported_band' > > > > Add a documentation for it. > > Should I take this through my tree, or is that part of a larger set > that'll go somewhere else? Whatever works best for you ;-) If you don't pick it via your tree, I'm planning to send it together with the other patches likely on Thursday. Thanks, Mauro
On Tue, 2020-10-13 at 22:41 +0200, Mauro Carvalho Chehab wrote: > Em Tue, 13 Oct 2020 20:47:47 +0200 > Johannes Berg <johannes@sipsolutions.net> escreveu: > > > Thanks Mauro. > > > > > > On Tue, 2020-10-13 at 13:54 +0200, Mauro Carvalho Chehab wrote: > > > Changeset df78a0c0b67d ("nl80211: S1G band and channel definitions") > > > added a new parameter, but didn't add the corresponding kernel-doc > > > markup, as repoted when doing "make htmldocs": > > > > > > ./include/net/cfg80211.h:471: warning: Function parameter or member 's1g_cap' not described in 'ieee80211_supported_band' > > > > > > Add a documentation for it. > > > > Should I take this through my tree, or is that part of a larger set > > that'll go somewhere else? > > Whatever works best for you ;-) > > If you don't pick it via your tree, I'm planning to send it > together with the other patches likely on Thursday. OK, please do, and here's an Acked-by: Johannes Berg <johannes@sipsolutions.net> I don't think I can get it this quickly through net-next at this point, and there's just no point if you have stuff to send anyway :-) Thanks! johannes
diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h index d9e6b9fbd95b..fb6aece00549 100644 --- a/include/net/cfg80211.h +++ b/include/net/cfg80211.h @@ -449,6 +449,7 @@ struct ieee80211_sta_s1g_cap { * @n_bitrates: Number of bitrates in @bitrates * @ht_cap: HT capabilities in this band * @vht_cap: VHT capabilities in this band + * @s1g_cap: S1G capabilities in this band * @edmg_cap: EDMG capabilities in this band * @n_iftype_data: number of iftype data entries * @iftype_data: interface type data entries. Note that the bits in
Changeset df78a0c0b67d ("nl80211: S1G band and channel definitions") added a new parameter, but didn't add the corresponding kernel-doc markup, as repoted when doing "make htmldocs": ./include/net/cfg80211.h:471: warning: Function parameter or member 's1g_cap' not described in 'ieee80211_supported_band' Add a documentation for it. Fixes: df78a0c0b67d ("nl80211: S1G band and channel definitions") Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- include/net/cfg80211.h | 1 + 1 file changed, 1 insertion(+)