From patchwork Thu Nov 24 08:01:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kirtika Ruchandani X-Patchwork-Id: 9444937 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 88C0560779 for ; Thu, 24 Nov 2016 08:04:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7EB29212EE for ; Thu, 24 Nov 2016 08:04:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 72BA9271BC; Thu, 24 Nov 2016 08:04:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 20F8E212EE for ; Thu, 24 Nov 2016 08:04:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756828AbcKXIEQ (ORCPT ); Thu, 24 Nov 2016 03:04:16 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36730 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756010AbcKXIEP (ORCPT ); Thu, 24 Nov 2016 03:04:15 -0500 Received: by mail-pf0-f194.google.com with SMTP id c4so1609174pfb.3; Thu, 24 Nov 2016 00:02:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=PT74FcZ3utPtv7DsuJXctqyi/guBqIO+3XHfPrjwRnM=; b=SGbOdmVeh6yXRlYlbFRTcJ/fhzadJGJ3k0EArM1JfHB2swiCFRnhPZTwN4yCjfEgS1 bhjx4LIE7VeZvLM4g8FghxtFKW4oMWiJLn7NHenKdT64ik5kzEWuotGN/DaiTJuXguuS vXZiSDfLwkNcW/dioKboxPnAXCAHnHNGLjbEFR2GCYYlpaj2ZUPibA985j5JqihamAJN a7TZEt9Q/4gi6DBnIow8Y6W7HsXZZEpdjdu0KX0D5gHgQqaKi/VRfUYpL5wxSTRP/eGL 5bwUxmqevXYGRRXxGbZKV419XJV0UTy4vs6mcClVMZL8rE5d8pzIIaDuOBj9tZcraY+/ JHBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=PT74FcZ3utPtv7DsuJXctqyi/guBqIO+3XHfPrjwRnM=; b=bJRsk2CX/YshD6hOzMH4wylyu71dAHvQsS6UNSEnJT/bYy85/Zrr6WOlcrsOTBo2RH 2KVnJ6ohXqiFPEzy+oPDRNp0x2o9p171+ZkhLo3McV1+j1A52rNe0ID6dc1EB9lYRe6K TL+5YUkp6jwF2KTh4mnxX302Lyw7cm2OoQMA6fxJ9KFhFJT3hGsEkB+PYwVWCmpV/zw4 yuZ4lwH5dosKi4N9x/VCybU7arsvOz00Io5aBA4Am7Bwl2lZG8rMGazzw2nD5IusHmCR /+X8XTQE7KGhvSHuh73yWIkgCowJkTGqx2jHnOGNvmAlvcBTtueK1DM4FLghM5hMSMGS n1Jg== X-Gm-Message-State: AKaTC02o5Cc1WNKf95SfkcmRmBe9gTdnkaq+qYT2e9cFkxxyQNObdg35gZv1CRcWlkrYAw== X-Received: by 10.84.216.80 with SMTP id f16mr2628952plj.25.1479974523578; Thu, 24 Nov 2016 00:02:03 -0800 (PST) Received: from google.com ([2620:0:1000:1301:e80d:edf6:fd55:23d6]) by smtp.gmail.com with ESMTPSA id t25sm14904335pgo.9.2016.11.24.00.02.02 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 24 Nov 2016 00:02:02 -0800 (PST) From: Kirtika Ruchandani X-Google-Original-From: Kirtika Ruchandani Date: Thu, 24 Nov 2016 00:01:58 -0800 To: Kalle Valo Cc: Arnd Bergmann , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, Raja Mani , Michal Kazior Subject: [PATCH 3/5] ath10k: Remove unused wmi_p2p_noa_descriptor 'noa' in wmi-tlv Message-ID: <99d0ff42e57d5f62560e72d926b4d69d5d7c418b.1479974100.git.kirtika@chromium.org> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit ca996ec56608 (ath10k: implement wmi-tlv backend) introduced ath10k_wmi_tlv_op_gen_vdev_start() where 'struct wmi_p2p_noa_descriptor *noa' is defined and set but not used. Compiling with W=1 gives the following warning, fix it. drivers/net/wireless/ath/ath10k/wmi-tlv.c: In function ‘ath10k_wmi_tlv_op_gen_vdev_start’: drivers/net/wireless/ath/ath10k/wmi-tlv.c:1647:33: warning: variable ‘noa’ set but not used [-Wunused-but-set-variable] Fixes: ca996ec56608 ("ath10k: implement wmi-tlv backend") Cc: Michal Kazior Cc: Kalle Valo Signed-off-by: Kirtika Ruchandani --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 -- 1 file changed, 2 deletions(-) -- 2.8.0.rc3.226.g39d4020 diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c index e64f593..0e4bd29 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c @@ -1644,7 +1644,6 @@ ath10k_wmi_tlv_op_gen_vdev_start(struct ath10k *ar, { struct wmi_tlv_vdev_start_cmd *cmd; struct wmi_channel *ch; - struct wmi_p2p_noa_descriptor *noa; struct wmi_tlv *tlv; struct sk_buff *skb; size_t len; @@ -1702,7 +1701,6 @@ ath10k_wmi_tlv_op_gen_vdev_start(struct ath10k *ar, tlv = ptr; tlv->tag = __cpu_to_le16(WMI_TLV_TAG_ARRAY_STRUCT); tlv->len = 0; - noa = (void *)tlv->value; /* Note: This is a nested TLV containing: * [wmi_tlv][wmi_p2p_noa_descriptor][wmi_tlv]..