From patchwork Sat Jul 22 19:53:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arend van Spriel X-Patchwork-Id: 9858183 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 11CCD601C0 for ; Sat, 22 Jul 2017 19:54:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F2B2E28484 for ; Sat, 22 Jul 2017 19:54:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E6CDA284B5; Sat, 22 Jul 2017 19:54:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6280128484 for ; Sat, 22 Jul 2017 19:54:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750864AbdGVTyA (ORCPT ); Sat, 22 Jul 2017 15:54:00 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:38342 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750735AbdGVTx7 (ORCPT ); Sat, 22 Jul 2017 15:53:59 -0400 Received: by mail-wm0-f49.google.com with SMTP id w191so37343748wmw.1 for ; Sat, 22 Jul 2017 12:53:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dxXhlM6R0bz9tzZkBTwEpd5nY+RW5AocmcDzmOFp4JM=; b=THGlG6XVwwHb8OWLy04EL373ruQR1QSqCsXzmzYjrG1xD0IJDQS63DnXYVoG7MrlVo jdI35xEI36HVcvjDJk2nEhMcnD5cqXA7FRCXN89XRySyFjXKuK37eYmWX1ccngR0Bna8 19zlfe/Qm7mafPB5O2ZIEd3Kvm5SLckA9XD6g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dxXhlM6R0bz9tzZkBTwEpd5nY+RW5AocmcDzmOFp4JM=; b=UDQEmaPi9JyS1M++oYyUMWE/yUVDTosOidYpEjxobr2K/oAzyWTDvQqb+bKT2rgVoW cMCg0wSbHhzaOYjm2nB36mjuxkDi/QUaKRDTN5dSP/n2eiVSjTDg5qlIQ1OeImqXT5ma J1pN+S0FgNnIRlMtxx9DtLXoQnOQVs9XoWXqdSMMEVyp48+hgrKZeNxAeHaxcjiwQJMc wZxWTlFJLuktrBS4kOZaLOHtFEzrR7NjrHKGslhuNUz5F7bE4sZlkBqjiN0ratG45MCz 0ADg0PMEgeI7yAlFbq0JHz5IexySRQO/DiAcsdTVVwecf/dbX4hpNESiGw9nqvFfhh8O qJeg== X-Gm-Message-State: AIVw113AzkguUCooXH08TG6PmbggPNo6PkDYJL6eTJcPdJ8WIDuBZp4y rhOsR1sykhL3eXTAWPYEgQ== X-Received: by 10.80.190.205 with SMTP id e13mr9095827edk.12.1500753237759; Sat, 22 Jul 2017 12:53:57 -0700 (PDT) Received: from [192.168.178.39] (f140230.upc-f.chello.nl. [80.56.140.230]) by smtp.gmail.com with ESMTPSA id s26sm4400037edc.95.2017.07.22.12.53.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Jul 2017 12:53:57 -0700 (PDT) Subject: Re: brcm43430 sdio wifi regression with 4.13-rc1 To: Ian Molton , Hans de Goede Cc: russianneuromancer , linux-wireless , brcm80211-dev-list.pdl@broadcom.com References: <03779c4f-b48b-444f-59c5-e10324dc77bd@mnementh.co.uk> <04f1050f-966e-b0c8-7714-ee5065ba69cf@mnementh.co.uk> From: Arend van Spriel Message-ID: <9e616361-da87-6f46-8ee3-4a4f673c3c80@broadcom.com> Date: Sat, 22 Jul 2017 21:53:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <04f1050f-966e-b0c8-7714-ee5065ba69cf@mnementh.co.uk> Content-Language: en-US Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 22-07-17 21:19, Ian Molton wrote: > On 22/07/17 20:18, Ian Molton wrote: >> On 22/07/17 19:43, Hans de Goede wrote: >>> Hi, >>> >>> When upgrading my devel environment to 4.13-rc1+ I noticed that >>> the brcm43430 sdio wifi on a Chuwi Hi8 plus stopped working: >> >> There is a fix for this: >> >> https://patchwork.kernel.org/patch/9836383/ > > Sorry, ignore me - this was a fix for the other 4.13-rc1 regression. > Arend is looking into he other one. It affects me too. > > It appears to be the firmware going astray. It is still an enigma although admittedly I did not put much time in it this week. The change below fixes it as the device goes haywire from this command. At least this was reported by Stefan Wahren ("brcmfmac: BCM43431 won't get probed on Raspberry Pi Zero W") on linux-wireless mailing list. Still I can not explain it. Could be that there is not enough free memory on the device. Regards, Arend --- brcmf_feat_iovar_int_get(ifp, BRCMF_FEAT_WOWL, "wowl"); diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c index d21258d..def120c 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c @@ -159,8 +159,9 @@ void brcmf_feat_attach(struct brcmf_pub *drvr) brcmf_feat_firmware_capabilities(ifp); memset(&gscan_cfg, 0, sizeof(gscan_cfg)); - brcmf_feat_iovar_data_set(ifp, BRCMF_FEAT_GSCAN, "pfn_gscan_cfg", - &gscan_cfg, sizeof(gscan_cfg)); + if (drvr->bus_if->chip != BRCM_CC_43430_CHIP_ID) + brcmf_feat_iovar_data_set(ifp, BRCMF_FEAT_GSCAN, "pfn_gscan_cfg", + &gscan_cfg, sizeof(gscan_cfg)); brcmf_feat_iovar_int_get(ifp, BRCMF_FEAT_PNO, "pfn"); if (drvr->bus_if->wowl_supported)