From patchwork Sun Jul 8 09:57:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernd Edlinger X-Patchwork-Id: 10513063 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3DC11603D7 for ; Sun, 8 Jul 2018 09:57:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2C3F228961 for ; Sun, 8 Jul 2018 09:57:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 20AA628965; Sun, 8 Jul 2018 09:57:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D3DEC28961 for ; Sun, 8 Jul 2018 09:57:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932365AbeGHJ52 (ORCPT ); Sun, 8 Jul 2018 05:57:28 -0400 Received: from mail-oln040092069044.outbound.protection.outlook.com ([40.92.69.44]:38483 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753952AbeGHJ50 (ORCPT ); Sun, 8 Jul 2018 05:57:26 -0400 Received: from HE1EUR02FT032.eop-EUR02.prod.protection.outlook.com (10.152.10.58) by HE1EUR02HT153.eop-EUR02.prod.protection.outlook.com (10.152.11.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.930.16; Sun, 8 Jul 2018 09:57:23 +0000 Received: from AM5PR0701MB2657.eurprd07.prod.outlook.com (10.152.10.55) by HE1EUR02FT032.mail.protection.outlook.com (10.152.10.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.930.16 via Frontend Transport; Sun, 8 Jul 2018 09:57:23 +0000 Received: from AM5PR0701MB2657.eurprd07.prod.outlook.com ([fe80::b1fe:1b4f:88c3:5243]) by AM5PR0701MB2657.eurprd07.prod.outlook.com ([fe80::b1fe:1b4f:88c3:5243%7]) with mapi id 15.20.0952.013; Sun, 8 Jul 2018 09:57:23 +0000 From: Bernd Edlinger To: Johannes Berg , "David S. Miller" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH] Add a missing break in parse_station_flags Thread-Topic: [PATCH] Add a missing break in parse_station_flags Thread-Index: AQHUFqIR6lIzyDCKGUCOieYfX7oQqQ== Date: Sun, 8 Jul 2018 09:57:22 +0000 Message-ID: Accept-Language: en-US, en-GB, de-DE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0165.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::33) To AM5PR0701MB2657.eurprd07.prod.outlook.com (2603:10a6:203:75::7) x-incomingtopheadermarker: OriginalChecksum:7957AAB8A38B2A4132689E7CE1B81F513BA6757C4FC7801138BC76323CAD6AF2; UpperCasedChecksum:FB361BDA253CAC81E2963C398400F629D504E417FF822607AE0E1D89CAAE2A74; SizeAsReceived:7538; Count:47 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [k6qkRq5BA9pgfDEddE9/7nQU9KUplzzr] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1EUR02HT153; 7:uAyCLY7sxVlTBP9MRxL3ixmx7YVCpy9IjSQOy8psAe8aVgA8eWyUJiavAyHYU6GmAtxhzbZe6uXDXkw+MTD58W6sE5FJykHSHNs55HlTp0F+I/0ulb9alRC9IsdD6makeqdK5ezbGilc1LfdfXfcvNG2okvQlDirVFiqo89ynwS0tKw4AhbqUetlFU34nkjd1Zepyvo9kHSRj9v3EWfGUdbxgHQAhZd752WemE4Lh9JeMvfCuf69yBt5YQtrJGRo x-incomingheadercount: 47 x-eopattributedmessage: 0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1601125500)(1603101448)(1701031045); SRVR:HE1EUR02HT153; x-ms-traffictypediagnostic: HE1EUR02HT153: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(82015058); SRVR:HE1EUR02HT153; BCL:0; PCL:0; RULEID:; SRVR:HE1EUR02HT153; x-forefront-prvs: 0727122FC6 x-forefront-antispam-report: SFV:NSPM; SFS:(7070007)(189003)(199004)(97736004)(104016004)(74316002)(14454004)(33656002)(305945005)(25786009)(5250100002)(2501003)(73972006)(75402003)(106356001)(44832011)(105586002)(81156014)(8936002)(74482002)(2900100001)(8676002)(486006)(7696005)(86362001)(386003)(6506007)(55016002)(6436002)(26005)(1857600001)(102836004)(6346003)(5660300001)(9686003)(110136005)(82202002)(2201001)(99286004)(68736007)(14444005)(476003)(256004); DIR:OUT; SFP:1901; SCL:1; SRVR:HE1EUR02HT153; H:AM5PR0701MB2657.eurprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:; received-spf: None (protection.outlook.com: hotmail.de does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=bernd.edlinger@hotmail.de; x-microsoft-antispam-message-info: fleZy/OX1tLB7uTWsn9i0gMopCpYh7iJGdJMoIP90iU8kAj6Bm80hX6BPK8F30d1GKFYNFUfu/kQCTOvM0eEQqDY8gjfWEHqJHhzdoijBoJbFdfHz4LGhwHkNi5rB6WJelvL1QqeYHlchnLhgOXbK1tw5Qt/2+6eeTyALqZnGtaN8MBWs2HEIwWt1d8pjV+EGbV0KvDR8oa3XpRgqs9Bz1b6Vb6Q1uGZ/qO/WhZstFE= Content-ID: <1F3AB3A58BC9AE408FE0239353463F2C@eurprd07.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: d4d70346-2c10-4f39-8c00-e767963926d9 X-MS-Exchange-CrossTenant-Network-Message-Id: 9191f344-d90d-4a85-587e-08d5e4b9334e X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: d4d70346-2c10-4f39-8c00-e767963926d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2018 09:57:23.1148 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR02HT153 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I was looking at usually suppressed gcc warnings, [-Wimplicit-fallthrough=] in this case: The code definitely looks like a break is missing here. However I am not able to test the NL80211_IFTYPE_MESH_POINT, nor do I actually know what might be :) So please use this patch with caution and only if you are able to do some testing. Signed-off-by: Bernd Edlinger --- net/wireless/nl80211.c | 1 + 1 file changed, 1 insertion(+) -- 1.9.1 diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 4eece06..6537b5d 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -4409,6 +4409,7 @@ static int parse_station_flags(struct genl_info *info, params->sta_flags_mask = BIT(NL80211_STA_FLAG_AUTHENTICATED) | BIT(NL80211_STA_FLAG_MFP) | BIT(NL80211_STA_FLAG_AUTHORIZED); + break; default: return -EINVAL; }