From patchwork Tue Mar 25 09:47:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 3886431 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 557419F334 for ; Tue, 25 Mar 2014 09:47:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 72E63202DD for ; Tue, 25 Mar 2014 09:47:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9E97820170 for ; Tue, 25 Mar 2014 09:47:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752745AbaCYJru (ORCPT ); Tue, 25 Mar 2014 05:47:50 -0400 Received: from mail-ob0-f170.google.com ([209.85.214.170]:36676 "EHLO mail-ob0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751411AbaCYJrt convert rfc822-to-8bit (ORCPT ); Tue, 25 Mar 2014 05:47:49 -0400 Received: by mail-ob0-f170.google.com with SMTP id uz6so234444obc.29 for ; Tue, 25 Mar 2014 02:47:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=jMggHoFkiMiRmKFA7GZjrP3uJMFQiMmWlAZ70ccaXbM=; b=R47YvEe5+rEeDeeUt55fDEaL7aeH0GQ6FsesUFJHjGmoYFIjpMx+J4cu8R3w9SANrs tlBaTvhmcmde9NseN9E9r4jB8M4lT4UYvo25FvogHidKlPM9fK0RgCvCYVMVmypP5h6Z G5Z62fsYpfqvwCDbNxddCeF2gqLeslma+sOwA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=jMggHoFkiMiRmKFA7GZjrP3uJMFQiMmWlAZ70ccaXbM=; b=ETVV8mQAc65arMojg+CZSbLQQpvRoZxyxv4B6bpYbFN3eS3uqYKRGouqq4zBTO0ybN O6a0MIACpJwmwHD86E6EQZ4rObNEsJ2sURFOofoZsEXjvm/lnwzBPX2XrOBJ5XfEskFv QizyU33/AWxHF8APr3/I+dxDm4cfy8ndp48lD4yB2ITQw7PQk5gERYg1XUq7vV2EMyCo oidC9KcXfkqstdiUhlAq9ERtZ2zIfS0HQyTRMYKuCEmF6V+jdOVjP4xddY2X+18S3J+d 4fpUs8dA8CXGxt5m4WvjyI+R2kwBu6n6BO3ddgJvR8GT50YDbCJ6ymewCKV5RsgG2Tzd kZyw== X-Gm-Message-State: ALoCoQkLAs2/EwlQ1nQcH4+85ZL/0TBnvzen9Dg1dhz0ovXNPRxPjC1gsnH9eQtAmTH02Fq0G4W7Y4vAklDS5DHXTM2ibSbPsnW6WL34cPovcXi/M1lPFjU= MIME-Version: 1.0 X-Received: by 10.182.176.10 with SMTP id ce10mr30671842obc.31.1395740869107; Tue, 25 Mar 2014 02:47:49 -0700 (PDT) Received: by 10.76.130.211 with HTTP; Tue, 25 Mar 2014 02:47:49 -0700 (PDT) In-Reply-To: References: <1395734146-10907-1-git-send-email-yeohchunyeow@gmail.com> Date: Tue, 25 Mar 2014 10:47:49 +0100 Message-ID: Subject: Re: [PATCH] ath10k: fix printing of peer stats in non-AP firmware From: Michal Kazior To: Yeoh Chun-Yeow Cc: "ath10k@lists.infradead.org" , linux-wireless , Kalle Valo X-DomainID: tieto.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 25 March 2014 10:38, Yeoh Chun-Yeow wrote: >> I don't think that's true for 10.1 firmware and AP interface types. > > I try to play around with 10.1 firmware as AP (3 connected STAs) and I > get the following: > > The first WMI_UPDATE_STATS_EVENTID as follow: > [ 338.290000] ath10k: pdev 0 vdev 0 peer 3 > [ 338.300000] ath10k: MAC 04:f0:21:0c:a5:44 > [ 338.300000] ath10k: RSSI 60 > [ 338.300000] ath10k: Tx 1170000 > [ 338.310000] ath10k: Rx 1170000 > [ 338.310000] ath10k: MAC 04:f0:21:0c:a5:19 > [ 338.320000] ath10k: RSSI 64 > [ 338.320000] ath10k: Tx 1300000 > [ 338.320000] ath10k: Rx 975000 > [ 338.320000] ath10k: MAC 04:f0:21:0c:a5:1c > [ 338.330000] ath10k: RSSI 71 > [ 338.330000] ath10k: Tx 975000 > [ 338.330000] ath10k: Rx 1300000 > > I think that above is correct. > > The second WMI_UPDATE_STATS_EVENTID as follow: > [ 338.340000] ath10k: pdev 1 vdev 0 peer 1 > [ 338.350000] ath10k: MAC a8:02:00:00:00:00 > [ 338.350000] ath10k: RSSI 0 > [ 338.350000] ath10k: Tx 565 > [ 338.360000] ath10k: Rx 0 > > Although indicating 1 peer, but the data seems to be not the peer > stats, not even self STA stats. Any idea? Yes. The second stats event has pdev stats. As per my other mail, 10.1 has extra pdev stats. Since ath10k doesn't account that it reads peer stats too early from the buffer. What you see is a tail of pdev stats for 10.1. You can try the following to test *10.1*: Micha? --- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/net/wireless/ath/ath10k/wmi.h +++ b/drivers/net/wireless/ath/ath10k/wmi.h @@ -2804,6 +2804,12 @@ struct wmi_pdev_stats { __le32 phy_err_count; /* Phy error count */ __le32 chan_tx_pwr; /* channel tx power */ struct wal_dbg_stats wal; /* WAL dbg stats */ + __le32 ack_rx_bad; + __le32 rts_bad; + __le32 rts_good; + __le32 fcs_bad; + __le32 no_beacons; + __le32 mib_int_count; } __packed;