| Message ID | CAGh4K3LLy0fnFMJ-e+yqCM7cpONo41-cP_o7dQvsAesd-hdvuQ@mail.gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Hi Christopher, On Mon, Aug 6, 2012 at 11:01 AM, Christopher Sacchi <chris.sacchi@gmail.com> wrote: > Hey guys, this should work now. I see the changes you made, however you're not going to get them accepted in this format. See Documentation/SubmittingPatches Online here: https://git.kernel.org/?p=linux/kernel/git/linville/wireless-testing.git;a=blob;f=Documentation/SubmittingPatches;h=c379a2a6949f1c1cac04fb6f185c633512f37061;hb=HEAD > -- > --- main.c 2012-07-21 20:58:29.000000000 +0000 > +++ mainnew.c 2012-08-05 20:00:37.000000000 +0000 > @@ -32,7 +32,7 @@ > #include "led.h" > #include "cfg.h" > #include "debugfs.h" > - Why are you removing the blank line - it's required as part of the kernel coding style. > +#include "net/rfkill/rfkill.h" You don't seem to actually be adding any code that uses anything in this header and don't explain why it's needed. > static struct lock_class_key ieee80211_rx_skb_queue_class; > > void ieee80211_configure_filter(struct ieee80211_local *local) > @@ -183,6 +183,7 @@ > * > */ > /* WARN_ON(ret); */ > + WARN_ON(1) What bug is this fixing? What problem is this solving? Thanks,
--- main.c 2012-07-21 20:58:29.000000000 +0000 +++ mainnew.c 2012-08-05 20:00:37.000000000 +0000 @@ -32,7 +32,7 @@ #include "led.h" #include "cfg.h" #include "debugfs.h" - +#include "net/rfkill/rfkill.h" static struct lock_class_key ieee80211_rx_skb_queue_class; void ieee80211_configure_filter(struct ieee80211_local *local) @@ -183,6 +183,7 @@ * */ /* WARN_ON(ret); */ + WARN_ON(1) } return ret;