From patchwork Fri Aug 24 05:25:30 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 1369861 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 1010CDF264 for ; Fri, 24 Aug 2012 05:25:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756779Ab2HXFZd (ORCPT ); Fri, 24 Aug 2012 01:25:33 -0400 Received: from mail-qa0-f46.google.com ([209.85.216.46]:38697 "EHLO mail-qa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761Ab2HXFZc (ORCPT ); Fri, 24 Aug 2012 01:25:32 -0400 Received: by qaas11 with SMTP id s11so293399qaa.19 for ; Thu, 23 Aug 2012 22:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=FvA2b9l46iY90D8ztKAQDQ8ZuWr2OhEb5MsxvsOUSQw=; b=ETWfEotpgcyUewzFVedEe2M1tDVVpDQHZLdoD/1N8jHfAueMh4TXpiWrN9ts5fF8k0 +nAciwX75whCY/cU9U4YeF8NQHmeKsyKdB9IRoI5hqnpMdq+nEchh3y2qCvWixRGFEoc BE9bV6+FU7inWGWdq/oiTG9Z9OehewPjKQFo7S5mB3gWityIlClzh+RTtAJYyNg3nyPE Kg4FsoEpet+ZobGbR6waCM7EIPDPx0oVcGsf4UbKqbtsh7AY6mCIa+RZItMky1PtJBXL BGqqc5vfg1swwOXGKxuJFfOhm2AbDT7HK3XSeMYwC+yfKp/7RlKxaUq2vMbrkmQ/ynBG eUng== MIME-Version: 1.0 Received: by 10.224.173.82 with SMTP id o18mr6804955qaz.96.1345785930366; Thu, 23 Aug 2012 22:25:30 -0700 (PDT) Received: by 10.229.146.194 with HTTP; Thu, 23 Aug 2012 22:25:30 -0700 (PDT) Date: Fri, 24 Aug 2012 13:25:30 +0800 Message-ID: Subject: [PATCH v2] mwifiex: use is_broadcast_ether_addr() instead of memcmp() From: Wei Yongjun To: bzhao@marvell.com, linville@tuxdriver.com Cc: yongjun_wei@trendmicro.com.cn, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Wei Yongjun Using is_broadcast_ether_addr() instead of directly use memcmp() to determine if the ethernet address is broadcast address. Signed-off-by: Wei Yongjun Acked-by: Bing Zhao --- drivers/net/wireless/mwifiex/sta_cmd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/wireless/mwifiex/sta_cmd.c b/drivers/net/wireless/mwifiex/sta_cmd.c index df3a33c..323b91b 100644 --- a/drivers/net/wireless/mwifiex/sta_cmd.c +++ b/drivers/net/wireless/mwifiex/sta_cmd.c @@ -551,7 +551,6 @@ mwifiex_cmd_802_11_key_material(struct mwifiex_private *priv, struct host_cmd_tlv_mac_addr *tlv_mac; u16 key_param_len = 0, cmd_size; int ret = 0; - const u8 bc_mac[] = { 0xff, 0xff, 0xff, 0xff, 0xff, 0xff }; cmd->command = cpu_to_le16(HostCmd_CMD_802_11_KEY_MATERIAL); key_material->action = cpu_to_le16(cmd_action); @@ -593,7 +592,7 @@ mwifiex_cmd_802_11_key_material(struct mwifiex_private *priv, /* set 0 when re-key */ key_material->key_param_set.key[1] = 0; - if (0 != memcmp(enc_key->mac_addr, bc_mac, sizeof(bc_mac))) { + if (!is_broadcast_ether_addr(enc_key->mac_addr)) { /* WAPI pairwise key: unicast */ key_material->key_param_set.key_info |= cpu_to_le16(KEY_UNICAST);