From patchwork Tue Aug 28 13:11:34 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 1381421 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 234993FC85 for ; Tue, 28 Aug 2012 13:11:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752714Ab2H1NLh (ORCPT ); Tue, 28 Aug 2012 09:11:37 -0400 Received: from mail-qa0-f46.google.com ([209.85.216.46]:45812 "EHLO mail-qa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752064Ab2H1NLg (ORCPT ); Tue, 28 Aug 2012 09:11:36 -0400 Received: by qaas11 with SMTP id s11so2620228qaa.19 for ; Tue, 28 Aug 2012 06:11:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=zy9KIrfdtN/PCZV8iWCbu06bcsdWocqfJvAbsq5npfA=; b=Sv4ShD+kB7ncx1Tma6j1xFI0DDaMtti1GwMlyzNi02NC2L/om/i4xziwLb31V32oHc n7j8pYH+jPZZDqty0jslJGDs0U3jbXh3D159yKkcSlvOoG7zGbBkug1tNI3XC51tbuPK dAMiw0+zlknbxFcLyTdWds7aSb/T8TcmHDpQei5wwbyGnrmiAFe6ofpwJ4euRLQ6hyUS jDpluTLWf5Y2eqlbtZmb5BqybGxOBKsozMeN+Vwii9/ysMC9amIVci5HcCkLhBx3CsI+ +mMJ7FVxd2WiqJZeGJTGndWrV5X05ars4tPEE5UImseioDQnyQRQlQ3VSky9kR9T+aQ7 LH/w== MIME-Version: 1.0 Received: by 10.224.70.209 with SMTP id e17mr29877269qaj.38.1346159494729; Tue, 28 Aug 2012 06:11:34 -0700 (PDT) Received: by 10.229.146.194 with HTTP; Tue, 28 Aug 2012 06:11:34 -0700 (PDT) Date: Tue, 28 Aug 2012 21:11:34 +0800 Message-ID: Subject: [PATCH] rtlwifi: rtl8192de: remove pointless conditional before kfree_skb() From: Wei Yongjun To: Larry.Finger@lwfinger.net, chaoming_li@realsil.com.cn, linville@tuxdriver.com Cc: yongjun_wei@trendmicro.com.cn, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Wei Yongjun Remove pointless conditional before kfree_skb(). Signed-off-by: Wei Yongjun Acked-by: Larry Finger --- drivers/net/wireless/rtlwifi/rtl8192de/fw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/fw.c b/drivers/net/wireless/rtlwifi/rtl8192de/fw.c index 895ae6c..a3aede0 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192de/fw.c +++ b/drivers/net/wireless/rtlwifi/rtl8192de/fw.c @@ -570,8 +570,7 @@ static bool _rtl92d_cmd_send_packet(struct ieee80211_hw *hw, ring = &rtlpci->tx_ring[BEACON_QUEUE]; pskb = __skb_dequeue(&ring->queue); - if (pskb) - kfree_skb(pskb); + kfree_skb(pskb); spin_lock_irqsave(&rtlpriv->locks.irq_th_lock, flags); pdesc = &ring->desc[idx]; /* discard output from call below */