From patchwork Fri Apr 19 02:10:03 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 2463021 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id E41ADDF2E5 for ; Fri, 19 Apr 2013 02:16:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967571Ab3DSCQ5 (ORCPT ); Thu, 18 Apr 2013 22:16:57 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:40951 "EHLO mail-bk0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967156Ab3DSCQ4 (ORCPT ); Thu, 18 Apr 2013 22:16:56 -0400 Received: by mail-bk0-f44.google.com with SMTP id jk13so1520654bkc.17 for ; Thu, 18 Apr 2013 19:16:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to:cc :content-type; bh=JQ3QbUuq+NW4F/Cpz7KoZ8WQ/LWTRDCek/9r9g5rZD8=; b=o2C97C45WSH0K6pNzu1kU2mYHSe7ZwwEWaTomTxXBnSl83uaT3inUGX3VFVO38OS6J 6oNOhpqB1JhCNIjS02K5gsRkehkgF5+C7fvwv6oKOxms6BPISvXXEZFJgkovisRA0u1K 2JWLrjAf9A44fu9uQmYaUOSWSqsFX9agVsuhcoF7dMGPIkqup0D4oIwJpAkJeCmVRwjo cKPCtqvI5nwdaJatmGS3MH2xhCxL48w2wlvE9eZhmPXj6YJIee3WNcUb9knBOGm4zAnM Qh0+WiOaFLcu7jRnttdLk3dmjwROOFBRzkly3Bfl34a3QgUuDUv/qe0hJ1EuVaKGXc38 dDsg== MIME-Version: 1.0 X-Received: by 10.204.172.200 with SMTP id m8mr4886376bkz.7.1366337403627; Thu, 18 Apr 2013 19:10:03 -0700 (PDT) Received: by 10.204.0.74 with HTTP; Thu, 18 Apr 2013 19:10:03 -0700 (PDT) Date: Fri, 19 Apr 2013 10:10:03 +0800 Message-ID: Subject: [PATCH -next] brcmfmac: fix error return code in brcmf_fws_init() From: Wei Yongjun To: brudley@broadcom.com, arend@broadcom.com, frankyl@broadcom.com, meuleman@broadcom.com, linville@tuxdriver.com, pieterpg@broadcom.com, phaber@broadcom.com Cc: yongjun_wei@trendmicro.com.cn, linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Wei Yongjun Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c index 1bcd58c..df2ac2f 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/fwsignal.c @@ -1875,8 +1875,9 @@ int brcmf_fws_init(struct brcmf_pub *drvr) goto fail; } - if (brcmf_fweh_register(drvr, BRCMF_E_FIFO_CREDIT_MAP, - brcmf_fws_notify_credit_map)) { + rc = brcmf_fweh_register(drvr, BRCMF_E_FIFO_CREDIT_MAP, + brcmf_fws_notify_credit_map); + if (rc) { brcmf_err("register credit map handler failed\n"); goto fail; }