From patchwork Sat Sep 8 01:53:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 1425941 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id B20BD3FC71 for ; Sat, 8 Sep 2012 01:53:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759333Ab2IHBxq (ORCPT ); Fri, 7 Sep 2012 21:53:46 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:33327 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751487Ab2IHBxp (ORCPT ); Fri, 7 Sep 2012 21:53:45 -0400 Received: by mail-qc0-f174.google.com with SMTP id o28so128834qcr.19 for ; Fri, 07 Sep 2012 18:53:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=bCvRXM8e60wZNoJXodfhKpCDGjuQbO0Ju5PHMYcV/vo=; b=t9yOd8jotbeCc/2CG8SEXoqG4xHxN8Ck7FraJlSWNyr6a5mjQgyIO49uGWZXU6C1F3 OtT5YddLTk6rNQtO3nPdrJMVR+vTT06G3kjTss1TTdZLAI2V7Vgo9NGHLg7Y+Zl2YBEB NL9iHVQq0OI1sxd5h/0az/rtt6fJZL1790KzBgK8STxHVbEd43e72tv5r00I8D8HYp+H SM+AALC+LbZH6xNO2+JsfpPcTtq0wH0yLHu88zP4GgnhcL6Uwl/c4oqzHqp5Wg9P65Dq gv/4hZindKtEZyBy5CqACTQhfEOM8RTsScg1JQUzeVfLxTwmzZrRKyv7Mg0IxzPixMwT QLBg== MIME-Version: 1.0 Received: by 10.229.134.200 with SMTP id k8mr2308230qct.135.1347069225133; Fri, 07 Sep 2012 18:53:45 -0700 (PDT) Received: by 10.229.146.194 with HTTP; Fri, 7 Sep 2012 18:53:45 -0700 (PDT) Date: Sat, 8 Sep 2012 09:53:45 +0800 Message-ID: Subject: [PATCH v2] NFC: pn544_hci: move the dereference below the NULL test From: Wei Yongjun To: lauro.venancio@openbossa.org, aloisio.almeida@openbossa.org, sameo@linux.intel.com Cc: yongjun_wei@trendmicro.com.cn, linux-wireless@vger.kernel.org Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Wei Yongjun The dereference should be moved below the NULL test. spatch with a semantic match is used to found this. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun --- drivers/nfc/pn544_hci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/nfc/pn544_hci.c b/drivers/nfc/pn544_hci.c index aa71807..7b20f2d 100644 --- a/drivers/nfc/pn544_hci.c +++ b/drivers/nfc/pn544_hci.c @@ -341,13 +341,14 @@ flush: static irqreturn_t pn544_hci_irq_thread_fn(int irq, void *dev_id) { struct pn544_hci_info *info = dev_id; - struct i2c_client *client = info->i2c_dev; + struct i2c_client *client; struct sk_buff *skb = NULL; int r; BUG_ON(!info); BUG_ON(irq != info->i2c_dev->irq); + client = info->i2c_dev; dev_dbg(&client->dev, "IRQ\n"); if (info->hard_fault != 0)