From patchwork Sun Jan 6 00:02:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernd Edlinger X-Patchwork-Id: 10749413 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 419FB1399 for ; Sun, 6 Jan 2019 00:02:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 324812880A for ; Sun, 6 Jan 2019 00:02:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2618928816; Sun, 6 Jan 2019 00:02:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AE66F2880A for ; Sun, 6 Jan 2019 00:02:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726413AbfAFACV (ORCPT ); Sat, 5 Jan 2019 19:02:21 -0500 Received: from mail-oln040092065018.outbound.protection.outlook.com ([40.92.65.18]:6316 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726363AbfAFACV (ORCPT ); Sat, 5 Jan 2019 19:02:21 -0500 Received: from HE1EUR01FT038.eop-EUR01.prod.protection.outlook.com (10.152.0.53) by HE1EUR01HT086.eop-EUR01.prod.protection.outlook.com (10.152.1.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1471.13; Sun, 6 Jan 2019 00:02:18 +0000 Received: from DB7PR07MB5353.eurprd07.prod.outlook.com (10.152.0.58) by HE1EUR01FT038.mail.protection.outlook.com (10.152.1.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1471.13 via Frontend Transport; Sun, 6 Jan 2019 00:02:18 +0000 Received: from DB7PR07MB5353.eurprd07.prod.outlook.com ([fe80::e1f9:8635:f629:eb8e]) by DB7PR07MB5353.eurprd07.prod.outlook.com ([fe80::e1f9:8635:f629:eb8e%4]) with mapi id 15.20.1516.010; Sun, 6 Jan 2019 00:02:18 +0000 From: Bernd Edlinger To: Ping-Ke Shih , Larry Finger , Kalle Valo , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Andrew Lunn Subject: [PATCH v3 1/4] rtl8723ae: Take the FW LPS mode handling out Thread-Topic: [PATCH v3 1/4] rtl8723ae: Take the FW LPS mode handling out Thread-Index: AQHUpVMW1dQwmrtP7EOElJ7UgzyQKg== Date: Sun, 6 Jan 2019 00:02:18 +0000 Message-ID: Accept-Language: en-US, en-GB, de-DE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: AM6PR06CA0023.eurprd06.prod.outlook.com (2603:10a6:20b:14::36) To DB7PR07MB5353.eurprd07.prod.outlook.com (2603:10a6:10:6e::26) x-incomingtopheadermarker: OriginalChecksum:7434CD7A7CBDF37EA75775B21C64AF86C4E0027572DABBD425845E654302B87B;UpperCasedChecksum:E11E6CAA021AADF9EAE791181A4E67B86955EA041951C5B437D2941725462D94;SizeAsReceived:8745;Count:62 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [Jpt4U8OvZLIkbVR/1i9d496jGx1/qWYN] x-microsoft-original-message-id: x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;HE1EUR01HT086;6:fgy8urWg2oRDZfDbOKKTAZX91U0O351eY7iT1bZd7k4/Ki7L1cH4Yc7PB9ATVPx+CA66ZaBM5wa04mETF/cMvtrMeuKejEp+a0Fphnl0/ovZNKzsD3SHPOA1qAgTgp+AT+GzzlyfV6g7fG8mIDvh/+b0XztJL0S6oycu83eoJqUvounFwJS+LHwOFnoTfj8zN0KPk0QMeqQc4kLDXC7VZO8ul9gCY36X2JSIoncHdNIuI4vanHdQZWdohj5ZOBVXZZpAtxAeWwY+V/t6zLqEn6qHW6snbDczyQm6Ta+EqYMEjy5WMOuR0iXxY3GgyrGqW5JZuNXI9NM9W9wuP0B2yoptcyBMk4RGq3zW1i8VyDjjW7So+5FIP+kdYIvR/K9jGbKZ8/FbcXPCxxRVEQCH5H0/cwZvebukD5b7cp9Z/XsOrl7N1XVFrNXZ2jt9/zci9i57Ya7E86T+L1xTvX/SNA==;5:2vf/qXrW8VT8GKKAsFQcjYQP3c/Wg+SqQZTCJVxTpwch6733qdENDs/l1xM1G5gkfhNx3Bf7azBPtBfSNu1IdIKlP5PEMepsFANY5PGU1pBkAZEU/xH8fj4LVJSSR2JEzWbvcp8OR7u9qSxheM+QZ8MR36l6JLbIFeEX08D8Nx4=;7:KuJyP+OWmZUNehoSxBKOOOOKvTf+qpj4ipFSrP0aMDDBVCYvlMuPaSBAD+h/xoKFVWYnwCDBY0mC9GO2UrdGBlSB7mxzQUzcU0j0xy07fPNodHY4Ixln+jaR+LO9fxy+trhDAiqKCcrci1w2BMSUFg== x-incomingheadercount: 62 x-eopattributedmessage: 0 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031323274)(2017031324274)(2017031322404)(1601125500)(1603101475)(1701031045);SRVR:HE1EUR01HT086; x-ms-traffictypediagnostic: HE1EUR01HT086: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(4566010)(82015058);SRVR:HE1EUR01HT086;BCL:0;PCL:0;RULEID:;SRVR:HE1EUR01HT086; x-microsoft-antispam-message-info: Zw6Flr9qXOa4V4bNDmNKavRpMS4+zcrVadlLyZTQ1GaY+QTXierz6/U3p6VZ4oAP Content-ID: <4DA994C4C2184140A706F188E9BA2980@eurprd07.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: d4d70346-2c10-4f39-8c00-e767963926d9 X-MS-Exchange-CrossTenant-Network-Message-Id: 8b478c00-df2e-490f-d7c1-08d6736a38e8 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: d4d70346-2c10-4f39-8c00-e767963926d9 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2019 00:02:17.4108 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR01HT086 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This appears to trigger a firmware bug and causes severe problems with rtl8723ae PCI devices. When the power save mode is activated for longer periods of time the firmware stops to receive any packets. This problem was exposed by commit 873ffe154ae0 ("rtlwifi: Fix logic error in enter/exit power-save mode"). Previously the power save mode was only active rarely and only for a short time so that the problem was not noticeable. Signed-off-by: Bernd Edlinger --- v2: Adjust the defaults of swlps and fwlps module parameters to match the firmware capabilities instead of removing the whole code, so it can be easily re-activated once a firmware update is available. v3: Make the title fit in one line. --- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c index 07b82700d1..3103151 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/sw.c @@ -266,8 +266,8 @@ static bool is_fw_header(struct rtlwifi_firmware_header *hdr) static struct rtl_mod_params rtl8723e_mod_params = { .sw_crypto = false, .inactiveps = true, - .swctrl_lps = false, - .fwctrl_lps = true, + .swctrl_lps = true, + .fwctrl_lps = false, .aspm_support = 1, .debug_level = 0, .debug_mask = 0, @@ -395,8 +395,8 @@ static bool is_fw_header(struct rtlwifi_firmware_header *hdr) bool, 0444); MODULE_PARM_DESC(swenc, "Set to 1 for software crypto (default 0)\n"); MODULE_PARM_DESC(ips, "Set to 0 to not use link power save (default 1)\n"); -MODULE_PARM_DESC(swlps, "Set to 1 to use SW control power save (default 0)\n"); -MODULE_PARM_DESC(fwlps, "Set to 1 to use FW control power save (default 1)\n"); +MODULE_PARM_DESC(swlps, "Set to 1 to use SW control power save (default 1)\n"); +MODULE_PARM_DESC(fwlps, "Set to 1 to use FW control power save (default 0)\n"); MODULE_PARM_DESC(msi, "Set to 1 to use MSI interrupts mode (default 0)\n"); MODULE_PARM_DESC(aspm, "Set to 1 to enable ASPM (default 1)\n"); MODULE_PARM_DESC(debug_level, "Set debug level (0-5) (default 0)");