From patchwork Sun May 14 08:21:50 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arend van Spriel X-Patchwork-Id: 9725563 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5E05960384 for ; Sun, 14 May 2017 08:22:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4338628935 for ; Sun, 14 May 2017 08:22:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 34BE128937; Sun, 14 May 2017 08:22:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C013C28935 for ; Sun, 14 May 2017 08:22:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751091AbdENIWB (ORCPT ); Sun, 14 May 2017 04:22:01 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:34670 "EHLO mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750882AbdENIV7 (ORCPT ); Sun, 14 May 2017 04:21:59 -0400 Received: by mail-pf0-f176.google.com with SMTP id 9so8807416pfj.1 for ; Sun, 14 May 2017 01:21:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=3sUzmYgqnNYjTeuu1i+u+it86auOxw1pTMlISEaq7mI=; b=gz41HnRhLA6v67rX+9JB0D78Sy8WolXoW+NuKaOivrKgFNNyjcZakZ2TbFUHHJl3su 9UQ+IVFs/L3pr1ZD3CYVIFnyITqU+qthWL7/+Wm4Elod26CI76aW8JfyFrwkD+7JsE5J g4Kr4MLNOODQMb9sxiE8TKawemqLWhQ3isi90= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=3sUzmYgqnNYjTeuu1i+u+it86auOxw1pTMlISEaq7mI=; b=qus8xcV6fPQQybzelE1SUNmwR55eHoEktGYkZJ/kE64mc7Drc4XboqRFXG8Md5U91u 0uLiyFI6sOGjMU0mnMSVqUjnUjKjX/2TqQEAX81Hp9qeWNo5242by67u0pv8V+tu2c8s WXS8TZ2IcLMGifu+5sUz3paYeyL+MyPDiyrfqoksB0T6/VGC/SHlpkQZWTT/YH3vpt7j aN3M+rTadEknw7Wf4wizWCIh15t+08qIItvZPxvJ3oXhHOXiwFQLpvR236yOnif/ucxG lF/koGbH1tnR2PXCUvXPiGQz3UGV3kKfDfEsZ5hzm9d0BCqU+ia4VDhP5m21wjQviM5f PEbg== X-Gm-Message-State: AODbwcAiVbHZwovrbWCr6OvIYsG3Vume8hU0dtqmoul43IUni6LtrHgR rJy1AWp+gm38I1Fl X-Received: by 10.84.173.195 with SMTP id p61mr587990plb.83.1494750119095; Sun, 14 May 2017 01:21:59 -0700 (PDT) Received: from [10.177.251.173] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id n5sm13613696pfa.78.2017.05.14.01.21.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 May 2017 01:21:58 -0700 (PDT) Subject: Re: New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not multiple of 8 To: Hans de Goede , Heiner Kallweit , Franky Lin , Hante Meuleman , Kalle Valo References: <540e89cd-c222-e81a-5e34-600ae0aa052e@redhat.com> <701cc6a7-b66b-8a51-8755-13dd584cbebd@gmail.com> Cc: linux-wireless , brcm80211-dev-list.pdl@broadcom.com From: Arend Van Spriel Message-ID: Date: Sun, 14 May 2017 10:21:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 13-5-2017 16:55, Hans de Goede wrote: > Hi, > > On 13-05-17 15:39, Heiner Kallweit wrote: >> Am 13.05.2017 um 14:35 schrieb Hans de Goede: >>> >>> >>> Hi, >>> >>> On 13-05-17 14:19, Hans de Goede wrote: >>>> Hi, >>>> >>>> I've just rebased my personal kernel tree to what will soon be 4.12-rc1 >>>> and I'm getting my dmesg log filled with the following errors: >>>> >>>> [ 32.528271] brcmfmac: brcmf_sdio_rxglom: sublen 524 not multiple >>>> of 8 >>>> [ 32.528296] brcmfmac: brcmf_sdio_rxglom: sublen 84 not multiple of 8 >>>> [ 33.063241] brcmfmac: brcmf_sdio_rxglom: sublen 1492 not multiple >>>> of 8 >>>> >> After a brief look at the code I'm not sure that the check actually >> checks >> for an error condition. Apart from the error messages: >> Do you face issues with the functionality of the driver? > > Yes after a while I get -ETIMEOUT errors for any sdio transfers > to the device. But I'm not sure if this is caused by this commit, > I think I've seen this once with 4.11 too. > > I've reverted the commit for now, but I'm fine with instead of > doing the revert dropping the error check if the brcmfmac developers > think that is ok. Currently the ETIMEOUT seems to be gone, so > if dropping the revert causes it to re-appear then we know more. Instead of reverting please give this patch a try and let me know if it works for you. Regards, Arend diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/n index fc64b89..e034500 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c @@ -3422,7 +3422,7 @@ static int brcmf_sdio_bus_preinit(struct device *dev) /* otherwise, set txglomalign */ value = sdiodev->settings->bus.sdio.sd_sgentry_align; /* SDIO ADMA requires at least 32 bit alignment */ - value = max_t(u32, value, 4); + value = max_t(u32, value, ALIGNMENT); err = brcmf_iovar_data_set(dev, "bus:txglomalign", &value, sizeof(u32)); }