From patchwork Sun Feb 16 14:31:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gang ZHAO X-Patchwork-Id: 3658111 Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D772B9F2CD for ; Sun, 16 Feb 2014 14:32:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 03A1A201DE for ; Sun, 16 Feb 2014 14:32:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1C938201BC for ; Sun, 16 Feb 2014 14:32:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752487AbaBPOcf (ORCPT ); Sun, 16 Feb 2014 09:32:35 -0500 Received: from mail-pd0-f173.google.com ([209.85.192.173]:52340 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752280AbaBPOcW (ORCPT ); Sun, 16 Feb 2014 09:32:22 -0500 Received: by mail-pd0-f173.google.com with SMTP id y10so13845422pdj.32 for ; Sun, 16 Feb 2014 06:32:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=vFKEvJ1qlnQRZTCskvhWo+5g95/hDBFe6oy9RfnMBvc=; b=B92//K44gAA20bvqMxO+FtZXSS6KpP0pEk1UBJQKFjKrRBl5V31JO98BF6mJtS18SE zmkwreiJTfGp060nE0rM9Rpo+RE1aSdvA+4/g5Rxk+qIMegZu/c4wWAWZbBsx5ejG9FN AtCt5B4LTWLZzIZK82DVRX4JRCz3Gr06JbWlw4UK03w+VK1uxXWaCl9bOgvKMTAKFrGw ZIKhsarUeEThSJm6hIo8s8IH/xWNv+bhmn6U1m7hFqByUKL7mMZM49vPXJsa5CkceKmH +sU5R6Os5iHbqnfv3Mx+fxAcB/q+AFcySETI8WSCx4Qg5nLQRWrjNOB/dpHEPv2af6Xx ZWDQ== X-Received: by 10.67.8.102 with SMTP id dj6mr20913916pad.10.1392561141561; Sun, 16 Feb 2014 06:32:21 -0800 (PST) Received: from will.lan ([175.153.40.98]) by mx.google.com with ESMTPSA id hb10sm36484838pbd.1.2014.02.16.06.32.18 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Feb 2014 06:32:21 -0800 (PST) From: "Zhao, Gang" To: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= , "John W. Linville" Cc: , Subject: [PATCH 2/2] b43: return true / false instead of numbers in functions which return bool value Date: Sun, 16 Feb 2014 22:31:38 +0800 Message-Id: X-Mailer: git-send-email 1.8.5.3 In-Reply-To: References: In-Reply-To: References: Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Zhao, Gang --- drivers/net/wireless/b43/debugfs.h | 2 +- drivers/net/wireless/b43/phy_common.c | 4 ++-- drivers/net/wireless/b43/pio.c | 10 +++++----- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/b43/debugfs.h b/drivers/net/wireless/b43/debugfs.h index 822aad88..50517b8 100644 --- a/drivers/net/wireless/b43/debugfs.h +++ b/drivers/net/wireless/b43/debugfs.h @@ -86,7 +86,7 @@ void b43_debugfs_log_txstat(struct b43_wldev *dev, static inline bool b43_debug(struct b43_wldev *dev, enum b43_dyndbg feature) { - return 0; + return false; } static inline void b43_debugfs_init(void) diff --git a/drivers/net/wireless/b43/phy_common.c b/drivers/net/wireless/b43/phy_common.c index f01676a..dbaa518 100644 --- a/drivers/net/wireless/b43/phy_common.c +++ b/drivers/net/wireless/b43/phy_common.c @@ -133,9 +133,9 @@ void b43_phy_exit(struct b43_wldev *dev) bool b43_has_hardware_pctl(struct b43_wldev *dev) { if (!dev->phy.hardware_power_control) - return 0; + return false; if (!dev->phy.ops->supports_hwpctl) - return 0; + return false; return dev->phy.ops->supports_hwpctl(dev); } diff --git a/drivers/net/wireless/b43/pio.c b/drivers/net/wireless/b43/pio.c index a73ff8c..a4ff5e2 100644 --- a/drivers/net/wireless/b43/pio.c +++ b/drivers/net/wireless/b43/pio.c @@ -637,7 +637,7 @@ static bool pio_rx_frame(struct b43_pio_rxqueue *q) ctl = b43_piorx_read32(q, B43_PIO8_RXCTL); if (!(ctl & B43_PIO8_RXCTL_FRAMERDY)) - return 0; + return false; b43_piorx_write32(q, B43_PIO8_RXCTL, B43_PIO8_RXCTL_FRAMERDY); for (i = 0; i < 10; i++) { @@ -651,7 +651,7 @@ static bool pio_rx_frame(struct b43_pio_rxqueue *q) ctl = b43_piorx_read16(q, B43_PIO_RXCTL); if (!(ctl & B43_PIO_RXCTL_FRAMERDY)) - return 0; + return false; b43_piorx_write16(q, B43_PIO_RXCTL, B43_PIO_RXCTL_FRAMERDY); for (i = 0; i < 10; i++) { @@ -662,7 +662,7 @@ static bool pio_rx_frame(struct b43_pio_rxqueue *q) } } b43dbg(q->dev->wl, "PIO RX timed out\n"); - return 1; + return true; data_ready: /* Get the preamble (RX header) */ @@ -759,7 +759,7 @@ data_ready: b43_rx(q->dev, skb, rxhdr); - return 1; + return true; rx_error: if (err_msg) @@ -769,7 +769,7 @@ rx_error: else b43_piorx_write16(q, B43_PIO_RXCTL, B43_PIO_RXCTL_DATARDY); - return 1; + return true; } void b43_pio_rx(struct b43_pio_rxqueue *q)