From patchwork Fri Mar 18 02:23:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julian Calaby X-Patchwork-Id: 8615781 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-linux-wireless@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D65D99F3D1 for ; Fri, 18 Mar 2016 02:23:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0690420306 for ; Fri, 18 Mar 2016 02:23:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2165D202FE for ; Fri, 18 Mar 2016 02:23:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752620AbcCRCXe (ORCPT ); Thu, 17 Mar 2016 22:23:34 -0400 Received: from mail-pf0-f171.google.com ([209.85.192.171]:36274 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751361AbcCRCXd (ORCPT ); Thu, 17 Mar 2016 22:23:33 -0400 Received: by mail-pf0-f171.google.com with SMTP id u190so146112294pfb.3 for ; Thu, 17 Mar 2016 19:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=68+uIzGRYxYZCT2wTai7SYfTZU1yN23TFbxy+8lQ9bg=; b=HuJpmjo/ngzD0YD5jNUgMzfBfhP0CPby2usHwYdKL3IXoetsr3pDEFVWEublntSBLP z9HrfcD+9fE1VZ3YZ0jmtzpq+ebP8jowlo5/82ZVkfjuqxsxzgK/R+l8Q+gXvG66Rt/T My0K6PKjWE2k1uPc/W3JMNeVTJx6Gt2EQInrP4vVw29q2R+QzxnvWWDud8opkvJDkf5x qFTwRQPjydXUoQOEciDC1UtemZQowI8OmAQr8aO8RPaGsUs2pyZ+FoDpP3E+Ks2irYFM kxmrkiArlU/BzNaYe1k7fMLKvugf2NeC4yb4P0IJGifTk3RLuweV4cc0OrID2ZAUP9Fq Gtcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=68+uIzGRYxYZCT2wTai7SYfTZU1yN23TFbxy+8lQ9bg=; b=bI3u6Gw1Fhx1NVDHSVaL6EXrmm+pzYomDPezkPZufCj9AN+fvuh5AWaKajlZEU7Xfi M3mDD0HsBpZ5HM1MEiKjjyaTLPtb5GMBa//sfPKUjHrq0zhD18rMf9ftGWBwY1lqV1DN rCL5+rDDEpznd1kFjXiroSrtQHA3MN15cdkReD3STLv5D6e15FJ85L5uFPLv6HmxIBfu yonYKqXwCuN+jOOOTVe8l0hTzLrHLnhB54RuCukaEz4m8e1ZDhW3ZrTw5LreetYOGVVt tbHe/TPixlGbQQPeZlYVJuvXlUkiXWXE0icviCuMkSQOxMUFFIrRLB8p5e0T0WG6+ksr GvaA== X-Gm-Message-State: AD7BkJL5lB94RoGvMRbvvWXOfZcRELOm5MdOmILEq9Jr+9e+Kyf6Fl+FlR22fyg5CXmpMw== X-Received: by 10.67.5.9 with SMTP id ci9mr19813833pad.101.1458267812139; Thu, 17 Mar 2016 19:23:32 -0700 (PDT) Received: from multimedia.lan (C-59-101-14-180.hay.connect.net.au. [59.101.14.180]) by smtp.gmail.com with ESMTPSA id 8sm16368684pfk.69.2016.03.17.19.23.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 Mar 2016 19:23:31 -0700 (PDT) From: Julian Calaby To: Kalle Valo Cc: Brett Rudley , Arend van Spriel , Franky Lin , Hante Meuleman , Pieter-Paul Giesberts , linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com, Markus Elfring Subject: [PATCH 07/19] brcmfmac: Delete unnecessary variable initialisation Date: Fri, 18 Mar 2016 13:23:24 +1100 Message-Id: X-Mailer: git-send-email 2.7.0 In-Reply-To: References: Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring In brcmf_sdio_download_firmware(), bcmerror is set by the call to brcmf_sdio_download_code_file(), before it's checked in the following line. Signed-off-by: Markus Elfring Acked-by: Arend van Spriel [Rewrote commit message] Signed-off-by: Julian Calaby --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c index 43fd3f4..fa2179d 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c @@ -3261,7 +3261,7 @@ static int brcmf_sdio_download_firmware(struct brcmf_sdio *bus, const struct firmware *fw, void *nvram, u32 nvlen) { - int bcmerror = -EFAULT; + int bcmerror; u32 rstvec; sdio_claim_host(bus->sdiodev->func[1]);