From patchwork Wed Mar 14 12:45:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: hariprasath.elango@gmail.com X-Patchwork-Id: 10282055 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 219DE602BD for ; Wed, 14 Mar 2018 12:45:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 127D3288D9 for ; Wed, 14 Mar 2018 12:45:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 06EE9288DE; Wed, 14 Mar 2018 12:45:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C4D58288D9 for ; Wed, 14 Mar 2018 12:45:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751758AbeCNMpg (ORCPT ); Wed, 14 Mar 2018 08:45:36 -0400 Received: from mail-pl0-f67.google.com ([209.85.160.67]:39117 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751470AbeCNMpe (ORCPT ); Wed, 14 Mar 2018 08:45:34 -0400 Received: by mail-pl0-f67.google.com with SMTP id k22-v6so790515pls.6; Wed, 14 Mar 2018 05:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=X3wyjJMi6kk7rg04JRPZeD+yK3TPTnJlYU/fBWqfdlY=; b=e+SJGr6fvSeBrYkVX09q98ChJnCw0Oxgvqr4NeCKH2qT1WisivCeptIRuwCkRZCxFt oDm3rTOwlLc9nHNA3LXxIWqOPO+uDXGuBnMxAFuVxqIK+SVi9ffSce+gbqoh8OLSxVmM TjoMyF9uRehgwSi2WP2QJHTYCOOmdNqQAY8hDFsF6Evv2TEhpVg1eoi6JRa9LEeawZT3 QlqVnoEKNjA42VyplPkCnjoMuLSm1XDyvUVELVlhWgSfE4mR5MS92VPkyHl5moQ45H3v o7fFIAnHlhet0mIKNgabp1iU7BW0+Xd1ethpPrYwuECB8WBX7G5QFtZMI2H2AqwA1Nfc mnfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=X3wyjJMi6kk7rg04JRPZeD+yK3TPTnJlYU/fBWqfdlY=; b=e/qcxFCt03UeQtQScSr9AB9+i34+gv2zwmQeKpEJdX9AM+/4hD0zKDukn0NuU2C1H4 2LJ3iwC6vC3pP3i8IpgWxs3JnkO3dyO1NdxVdh+J3hF/AGzA2pjcbsawqBpMr18lPlJe 8YalXF3PVFarAfDdWLwetRunDg02qsJxo7ZDBYlJs0GE5EzNL+lFfzU15Cle46H3aKfT 2hKt9BTdhgraBLDbpivcShuH0sSF1wshCBZAo84WHSQcDeMZD0rl0QB4E3sElgHnWVbx 02SxgzsUpMeLmuUb3KRPnTk/+3hiwnO/Be8RWN0utYj/YjFGI9EbpmZ5uyDJ8HzjKA2B 0cDw== X-Gm-Message-State: AElRT7HRh+APWiY0/pwwexhx944zivVIb/nDrniTM2CCFYDoooM4ZFvC NmiaEakrwzzER+AJejzHrSo= X-Google-Smtp-Source: AG47ELuxm7mwEQt9NnVZbz8dwpAmyzBXe9b2osw5sySnVIs+EE0qxhV9JOh2g4PpfYhrldTxcOWk+g== X-Received: by 2002:a17:902:f64:: with SMTP id 91-v6mr4003775ply.232.1521031533740; Wed, 14 Mar 2018 05:45:33 -0700 (PDT) Received: from localhost.localdomain ([2405:204:7142:9212:3d49:8166:4647:f07f]) by smtp.gmail.com with ESMTPSA id y14sm3999982pff.81.2018.03.14.05.45.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Mar 2018 05:45:32 -0700 (PDT) From: hariprasath.elango@gmail.com To: aditya.shankar@microchip.com, gregkh@linuxfoundation.org, ganesh.krishna@microchip.com Cc: hariprasath.elango@gmail.com, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/7] staging: wilc1000: use kmemdup instead of kmalloc and memcpy Date: Wed, 14 Mar 2018 18:15:01 +0530 Message-Id: X-Mailer: git-send-email 2.10.0.GIT In-Reply-To: References: In-Reply-To: References: Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: HariPrasath Elango Kmalloc followed by memcpy can be replaced by kmemdup. Signed-off-by: HariPrasath Elango Reviewed-by: Ajay Singh --- drivers/staging/wilc1000/linux_mon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c index f93f411..c6fd6b3 100644 --- a/drivers/staging/wilc1000/linux_mon.c +++ b/drivers/staging/wilc1000/linux_mon.c @@ -146,7 +146,7 @@ static int mon_mgmt_tx(struct net_device *dev, const u8 *buf, size_t len) if (!mgmt_tx) return -ENOMEM; - mgmt_tx->buff = kmalloc(len, GFP_ATOMIC); + mgmt_tx->buff = kmemdup(buf, len, GFP_ATOMIC); if (!mgmt_tx->buff) { kfree(mgmt_tx); return -ENOMEM; @@ -154,7 +154,6 @@ static int mon_mgmt_tx(struct net_device *dev, const u8 *buf, size_t len) mgmt_tx->size = len; - memcpy(mgmt_tx->buff, buf, len); wilc_wlan_txq_add_mgmt_pkt(dev, mgmt_tx, mgmt_tx->buff, mgmt_tx->size, mgmt_tx_complete);