mbox series

[wpan/next,v4,0/8] net: ieee802154: Improve filtering support

Message ID 20221007085310.503366-1-miquel.raynal@bootlin.com (mailing list archive)
Headers show
Series net: ieee802154: Improve filtering support | expand

Message

Miquel Raynal Oct. 7, 2022, 8:53 a.m. UTC
Hello,

A fourth version of this series, where we try to improve filtering
support to ease scan integration. Will then come a short series about
the coordinator interfaces and then the proper scan series.

Thanks,
Miquèl

Changes in v4:
* Added a condition upon which the packets for a given interface would be
  dropped: in case AACK and/or address filtering was expected, but
  another interface has disabled it on the PHY.
* Changed the way Alexander's patch behaves regarding the handling of
  the different filtering levels. I added a third variable which shows
  the default filtering level for the interface. There is a second
  (per-interface) field giving the expected filtering level for this
  interface and finally we keep the per-PHY actual filtering level
  information. With this we can safely go back to the right level after
  a scan and also we can detect any wrong situation where ACKs would not
  be sent while expected and drop the frames if in this situation.
* Moved all the additional filtering logic out of the core and put it
  into hwsim's in-driver receive path, so that it can act like any other
  transceiver depending on the filtering level requested.
* Dropped the addition of the support for the ieee802154 promiscuous
  filtering mode which is anyway not usable yet.
* Dropped the "net:" prefixes in many patches to fit what Alexander
  does.

Changes in v3:
* Full rework of the way the promiscuous mode is handled, with new
  filtering levels, one per-phy and the actual one on the device.
* Dropped all the manual acking, everything is happenging on hardware.
* Better handling of the Acks in atusb to report the trac status.



Alexander Aring (2):
  mac802154: move receive parameters above start
  mac802154: set filter at drv_start()

Miquel Raynal (6):
  mac802154: Introduce filtering levels
  ieee802154: hwsim: Record the address filter values
  ieee802154: hwsim: Implement address filtering
  mac802154: Drop IEEE802154_HW_RX_DROP_BAD_CKSUM
  mac802154: Avoid delivering frames received in a non satisfying
    filtering mode
  mac802154: Ensure proper scan-level filtering

 drivers/net/ieee802154/mac802154_hwsim.c | 150 +++++++++++-
 include/linux/ieee802154.h               |  24 ++
 include/net/cfg802154.h                  |   7 +-
 include/net/ieee802154_netdev.h          |   8 +
 include/net/mac802154.h                  |   4 -
 net/mac802154/cfg.c                      |   2 +-
 net/mac802154/driver-ops.h               | 281 ++++++++++++++---------
 net/mac802154/ieee802154_i.h             |  12 +
 net/mac802154/iface.c                    |  44 ++--
 net/mac802154/rx.c                       |  25 +-
 10 files changed, 409 insertions(+), 148 deletions(-)

Comments

Alexander Aring Oct. 11, 2022, 1:01 a.m. UTC | #1
Hi,

On Fri, Oct 7, 2022 at 4:53 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> Hello,
>
> A fourth version of this series, where we try to improve filtering
> support to ease scan integration. Will then come a short series about
> the coordinator interfaces and then the proper scan series.
>

I think this patch series goes into the right direction. So I would
give it a go:

Acked-by: Alexander Aring <aahringo@redhat.com>

- Alex
Stefan Schmidt Oct. 12, 2022, 10:59 a.m. UTC | #2
Hello Miquel.

On 11.10.22 03:01, Alexander Aring wrote:
> Hi,
> 
> On Fri, Oct 7, 2022 at 4:53 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>>
>> Hello,
>>
>> A fourth version of this series, where we try to improve filtering
>> support to ease scan integration. Will then come a short series about
>> the coordinator interfaces and then the proper scan series.
>>
> 
> I think this patch series goes into the right direction. So I would
> give it a go:
> 
> Acked-by: Alexander Aring <aahringo@redhat.com>


Besides patch 8 these patches have been applied to the wpan-next tree 
and will be part of the next pull request to net-next. Thanks!

regards
Stefan Schmidt